Solved

Transact SQL nested select

Posted on 2008-10-06
11
935 Views
Last Modified: 2008-10-06
Dont know if I am going about this the right way. I am trying:

SELECT     Industries.IndustryDesc, sum(LinkClientItems.Value) as CoreExpenses,

(
SELECT    sum(LinkClientItems.Value) as Sell
FROM         Industries INNER JOIN
                      Categories ON Industries.IndustryID = Categories.IndustryID INNER JOIN
                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN
                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID
WHERE     (LinkClientItems.ItemUseID = 2)

)as Sell
FROM         Industries INNER JOIN
                      Categories ON Industries.IndustryID = Categories.IndustryID INNER JOIN
                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN
                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID
WHERE     (LinkClientItems.ItemUseID = 1)

group by industries.industrydesc


This is giving :

Advertising; Media; Printi      700.00      223.00
Building; Construction      5300.00      223.00
Manufacturing      500.00      223.00
Professional                            500.00      223.00

The first sum column is correct, but the second is simply the first sum repeated. Not grouping properly (or something). My knowledge of SQL is not great and I dont usually go past simple joins for queries. Any help would be appreciated.
0
Comment
Question by:subversivetech
  • 6
  • 5
11 Comments
 
LVL 59

Expert Comment

by:Kevin Cross
ID: 22655181
Think you want to filter the subquery based on the current industry you are on.
SELECT     a.IndustryDesc, sum(LinkClientItems.Value) as CoreExpenses,
 

(

SELECT    sum(LinkClientItems.Value) as Sell

FROM         Industries b INNER JOIN

                      Categories ON Industries.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 2 AND a.IndustryDesc = b.IndustryDesc)
 

)as Sell

FROM         Industries a INNER JOIN

                      Categories ON a.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 1)
 

group by a.industrydesc

Open in new window

0
 
LVL 59

Expert Comment

by:Kevin Cross
ID: 22655183
Think you want to filter the subquery based on the current industry you are on.
SELECT     a.IndustryDesc, sum(LinkClientItems.Value) as CoreExpenses,
 

(

SELECT    sum(LinkClientItems.Value) as Sell

FROM         Industries b INNER JOIN

                      Categories ON Industries.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 2 AND a.IndustryDesc = b.IndustryDesc)
 

)as Sell

FROM         Industries a INNER JOIN

                      Categories ON a.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 1)
 

group by a.industrydesc

Open in new window

0
 

Author Comment

by:subversivetech
ID: 22655230
Executing that gives:

Msg 4104, Level 16, State 1, Line 1
The multi-part identifier "Industries.IndustryID" could not be bound.
0
 
LVL 59

Expert Comment

by:Kevin Cross
ID: 22655264
Sorry I missed one.  You have to qualify all the references of Industries by aliases if used and used aliases to tell which one I intend since crossing between outer query and inner one in where clause.
SELECT     a.IndustryDesc, sum(LinkClientItems.Value) as CoreExpenses,

 

(

SELECT    sum(LinkClientItems.Value) as Sell

FROM         Industries b INNER JOIN

                      Categories ON b.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 2 AND a.IndustryDesc = b.IndustryDesc)

 

)as Sell

FROM         Industries a INNER JOIN

                      Categories ON a.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 1)

 

group by a.industrydesc

Open in new window

0
 

Author Comment

by:subversivetech
ID: 22655263
This works the way I want on some test data:

SELECT industry, sum(Value) as Boating,
(
SELECT sum(Value) as Cars
FROM Test
where category = 'Cars'
) as Cars

FROM Test
where category = 'Boating'

group by industry
This is against a single table with 3 fields:
Industry , category, value
0
Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

 
LVL 59

Expert Comment

by:Kevin Cross
ID: 22655273
That will get you exactly what you have above.  If that is what you intend then the result is correct.

You are getting a sum of all the values where category = 'Cars' regardless of industry or whatever else is being used in outer query.  If you have multiple rows in the outer query, all the rows will have the same sum.  

If you want different sums by row, you must use a value from each row as the criteria for the sum.

Hope that helps.
0
 

Author Comment

by:subversivetech
ID: 22655316
You solution is very close to what I am looking for. It is looking good, but it does not give rows that have a null value for the 'coreexpenses' column. Any idea to make sure they are included?
Your solution gives:
Advertising; Media; Printing  700.00   NULL
Building; Construction         5300.00   23.00
Manufacturing                        500.00     NULL
Professional                          500.00    NULL
But it should include
Health                                   null            200
Cheers for the help!
0
 

Author Comment

by:subversivetech
ID: 22655402
Further,
I need every IndustryDesc returned regardless of whether there are any LinkClientItems for that Industry
0
 
LVL 59

Accepted Solution

by:
Kevin Cross earned 500 total points
ID: 22655535
Well for that you needed a LEFT JOIN in your original query.
SELECT     a.IndustryDesc, sum(LinkClientItems.Value) as CoreExpenses,

 

(

SELECT    sum(LinkClientItems.Value) as Sell

FROM         Industries b INNER JOIN

                      Categories ON b.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID INNER JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (LinkClientItems.ItemUseID = 2 AND a.IndustryDesc = b.IndustryDesc)

 

)as Sell

FROM         Industries a INNER JOIN

                      Categories ON a.IndustryID = Categories.IndustryID INNER JOIN

                      Items ON Categories.CategoryID = Items.CategoryID LEFT JOIN

                      LinkClientItems ON Items.ItemID = LinkClientItems.ItemID

WHERE     (IsNull(LinkClientItems.ItemUseID,1) = 1)

 

group by a.industrydesc

Open in new window

0
 

Author Comment

by:subversivetech
ID: 22655613
Mate you are a legend!
Thanks from down under. I am finding it difficult to get my head around the more advanced T-SQL. I find that the Microsoft docs and MSDN alway use overly complex examples. Not sure if you could recommend a resource to use as a reference as I work my way up?
 
Cheers.
0
 
LVL 59

Expert Comment

by:Kevin Cross
ID: 22655745
I usually find the "In A Nutshell" books from O'Reilly and/or the Wrox books pretty helpful.
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Suggested Solutions

Occasionally there is a need to clean table columns, especially if you have inherited legacy data. There are obviously many ways to accomplish that, including elaborate UPDATE queries with anywhere from one to numerous REPLACE functions (even within…
In this article I will describe the Backup & Restore method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
In this seventh video of the Xpdf series, we discuss and demonstrate the PDFfonts utility, which lists all the fonts used in a PDF file. It does this via a command line interface, making it suitable for use in programs, scripts, batch files — any pl…
You have products, that come in variants and want to set different prices for them? Watch this micro tutorial that describes how to configure prices for Magento super attributes. Assigning simple products to configurable: We assigned simple products…

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now