Solved

Resizing multiple images runs out of memory

Posted on 2008-10-07
3
833 Views
Last Modified: 2012-05-05
Hi all,

Below is a function that I wrote that resizes images for a website. After it processes about 250 images, I run out of memory, leading me to believe that my dispose isn't working? There are 900 photos to process total. What have I missed?
Function resizeImage(ByVal imageName As String, ByVal newWidth As Integer, ByVal imageType As String, ByVal homeDirectory As String) As String
 

        Dim originalFileName As String

        Dim newFileName As String

        Dim tmpImage As Drawing.Bitmap

        Dim newImage As Drawing.Bitmap

        Dim g As Graphics

        Dim newHeight As Integer
 

        originalFileName = pickupFolder & imageName

        If File.Exists(originalFileName) = True Then

            Try

                tmpImage = New Bitmap(Bitmap.FromFile(originalFileName))

                newHeight = (newWidth * tmpImage.Height) / tmpImage.Width
 

                newImage = New Bitmap(newWidth, newHeight)

                g = Graphics.FromImage(newImage)
 
 

                ' draw it with the new size

                g.DrawImage(tmpImage, 0, 0, newWidth, newHeight)
 

                newFileName = imageType & Replace(imageName, " ", "")

                newImage.Save("c:\inetpub\wwwroot\" & homeDirectory & "\photos\" & newFileName, Drawing.Imaging.ImageFormat.Jpeg)

                g.Dispose()

                newImage.Dispose()

                tmpImage.Dispose()
 

                tmpImage = Nothing

                newImage = Nothing

                g = Nothing
 

                resizeImage = newFileName
 

            Catch ex As Exception
 

                streamWriter.WriteLine(originalFileName & " gave error: " & ex.Message)

                Console.WriteLine(originalFileName & " gave error: " & ex.Message)
 

            End Try
 

        Else

            streamWriter.WriteLine(originalFileName & " does not exist")

            Console.WriteLine(originalFileName & " does not exist")

        End If
 

        tmpImage = Nothing

        newImage = Nothing

        g = Nothing
 

    End Function

Open in new window

0
Comment
Question by:DEWebWorks
  • 2
3 Comments
 
LVL 14

Accepted Solution

by:
rachitkohli earned 500 total points
ID: 22658453
I would suggest making an image from the file using file stream object.

Dim fs as IO.FileStream
fs=new IO.FileStream("FILEPATH", ACCESSTYPE)
fs.close

tmpImage=Bitmap.FromStream(fs)

'Please check for the syntax, as am directly typing here without testing it...
0
 

Author Closing Comment

by:DEWebWorks
ID: 31503786
Very nice! Thanks.
0
 

Author Comment

by:DEWebWorks
ID: 22658504
Here's the final code:

    Function resizeImage(ByVal imageName As String, ByVal newWidth As Integer, ByVal imageType As String, ByVal homeDirectory As String) As String
 

        Dim originalFileName As String

        Dim newFileName As String

        Dim tmpImage As Drawing.Bitmap

        Dim newImage As Drawing.Bitmap

        Dim g As Graphics

        Dim newHeight As Integer
 

        '---

        Dim fs As IO.FileStream

        '---
 

        originalFileName = pickupFolder & imageName

        If File.Exists(originalFileName) = True Then

            Try

                'tmpImage = New Bitmap(Bitmap.FromFile(originalFileName))

                '---

                fs = New IO.FileStream(originalFileName, FileMode.Open)
 

                tmpImage = Bitmap.FromStream(fs)

                fs.Close()

                '---
 

                newHeight = (newWidth * tmpImage.Height) / tmpImage.Width
 

                newImage = New Bitmap(newWidth, newHeight)

                g = Graphics.FromImage(newImage)
 
 

                ' draw it with the new size

                g.DrawImage(tmpImage, 0, 0, newWidth, newHeight)

                g.Dispose()
 

                newFileName = imageType & Replace(imageName, " ", "")

                newImage.Save("c:\inetpub\wwwroot\" & homeDirectory & "\photos\" & newFileName, Drawing.Imaging.ImageFormat.Jpeg)
 

                newImage.Dispose()

                tmpImage.Dispose()
 

                tmpImage = Nothing

                newImage = Nothing

                g = Nothing
 

                resizeImage = newFileName
 

            Catch ex As Exception
 

                streamWriter.WriteLine(originalFileName & " gave error: " & ex.Message)

                Console.WriteLine(originalFileName & " gave error: " & ex.Message)
 

            End Try
 

        Else

            streamWriter.WriteLine(originalFileName & " does not exist")

            Console.WriteLine(originalFileName & " does not exist")

        End If
 

        tmpImage = Nothing

        newImage = Nothing

        g = Nothing
 

    End Function

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Since .Net 2.0, Visual Basic has made it easy to create a splash screen and set it via the "Splash Screen" drop down in the Project Properties.  A splash screen set in this manner is automatically created, displayed and closed by the framework itsel…
Creating an analog clock UserControl seems fairly straight forward.  It is, after all, essentially just a circle with several lines in it!  Two common approaches for rendering an analog clock typically involve either manually calculating points with…
This is a video that shows how the OnPage alerts system integrates into ConnectWise, how a trigger is set, how a page is sent via the trigger, and how the SENT, DELIVERED, READ & REPLIED receipts get entered into the internal tab of the ConnectWise …
Concerto provides fully managed cloud services and the expertise to provide an easy and reliable route to the cloud. Our best-in-class solutions help you address the toughest IT challenges, find new efficiencies and deliver the best application expe…

947 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now