Solved

Resizing multiple images runs out of memory

Posted on 2008-10-07
3
840 Views
Last Modified: 2012-05-05
Hi all,

Below is a function that I wrote that resizes images for a website. After it processes about 250 images, I run out of memory, leading me to believe that my dispose isn't working? There are 900 photos to process total. What have I missed?
Function resizeImage(ByVal imageName As String, ByVal newWidth As Integer, ByVal imageType As String, ByVal homeDirectory As String) As String
 
        Dim originalFileName As String
        Dim newFileName As String
        Dim tmpImage As Drawing.Bitmap
        Dim newImage As Drawing.Bitmap
        Dim g As Graphics
        Dim newHeight As Integer
 
        originalFileName = pickupFolder & imageName
        If File.Exists(originalFileName) = True Then
            Try
                tmpImage = New Bitmap(Bitmap.FromFile(originalFileName))
                newHeight = (newWidth * tmpImage.Height) / tmpImage.Width
 
                newImage = New Bitmap(newWidth, newHeight)
                g = Graphics.FromImage(newImage)
 
 
                ' draw it with the new size
                g.DrawImage(tmpImage, 0, 0, newWidth, newHeight)
 
                newFileName = imageType & Replace(imageName, " ", "")
                newImage.Save("c:\inetpub\wwwroot\" & homeDirectory & "\photos\" & newFileName, Drawing.Imaging.ImageFormat.Jpeg)
                g.Dispose()
                newImage.Dispose()
                tmpImage.Dispose()
 
                tmpImage = Nothing
                newImage = Nothing
                g = Nothing
 
                resizeImage = newFileName
 
            Catch ex As Exception
 
                streamWriter.WriteLine(originalFileName & " gave error: " & ex.Message)
                Console.WriteLine(originalFileName & " gave error: " & ex.Message)
 
            End Try
 
        Else
            streamWriter.WriteLine(originalFileName & " does not exist")
            Console.WriteLine(originalFileName & " does not exist")
        End If
 
        tmpImage = Nothing
        newImage = Nothing
        g = Nothing
 
    End Function

Open in new window

0
Comment
Question by:DEWebWorks
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
3 Comments
 
LVL 14

Accepted Solution

by:
rachitkohli earned 500 total points
ID: 22658453
I would suggest making an image from the file using file stream object.

Dim fs as IO.FileStream
fs=new IO.FileStream("FILEPATH", ACCESSTYPE)
fs.close

tmpImage=Bitmap.FromStream(fs)

'Please check for the syntax, as am directly typing here without testing it...
0
 

Author Closing Comment

by:DEWebWorks
ID: 31503786
Very nice! Thanks.
0
 

Author Comment

by:DEWebWorks
ID: 22658504
Here's the final code:

    Function resizeImage(ByVal imageName As String, ByVal newWidth As Integer, ByVal imageType As String, ByVal homeDirectory As String) As String
 
        Dim originalFileName As String
        Dim newFileName As String
        Dim tmpImage As Drawing.Bitmap
        Dim newImage As Drawing.Bitmap
        Dim g As Graphics
        Dim newHeight As Integer
 
        '---
        Dim fs As IO.FileStream
        '---
 
        originalFileName = pickupFolder & imageName
        If File.Exists(originalFileName) = True Then
            Try
                'tmpImage = New Bitmap(Bitmap.FromFile(originalFileName))
                '---
                fs = New IO.FileStream(originalFileName, FileMode.Open)
 
                tmpImage = Bitmap.FromStream(fs)
                fs.Close()
                '---
 
                newHeight = (newWidth * tmpImage.Height) / tmpImage.Width
 
                newImage = New Bitmap(newWidth, newHeight)
                g = Graphics.FromImage(newImage)
 
 
                ' draw it with the new size
                g.DrawImage(tmpImage, 0, 0, newWidth, newHeight)
                g.Dispose()
 
                newFileName = imageType & Replace(imageName, " ", "")
                newImage.Save("c:\inetpub\wwwroot\" & homeDirectory & "\photos\" & newFileName, Drawing.Imaging.ImageFormat.Jpeg)
 
                newImage.Dispose()
                tmpImage.Dispose()
 
                tmpImage = Nothing
                newImage = Nothing
                g = Nothing
 
                resizeImage = newFileName
 
            Catch ex As Exception
 
                streamWriter.WriteLine(originalFileName & " gave error: " & ex.Message)
                Console.WriteLine(originalFileName & " gave error: " & ex.Message)
 
            End Try
 
        Else
            streamWriter.WriteLine(originalFileName & " does not exist")
            Console.WriteLine(originalFileName & " does not exist")
        End If
 
        tmpImage = Nothing
        newImage = Nothing
        g = Nothing
 
    End Function

Open in new window

0

Featured Post

Salesforce Has Never Been Easier

Improve and reinforce salesforce training & adoption using WalkMe's digital adoption platform. Start saving on costly employee training by creating fast intuitive Walk-Thrus for Salesforce. Claim your Free Account Now

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I think the Typed DataTable and Typed DataSet are very good options when working with data, but I don't like auto-generated code. First, I create an Abstract Class for my DataTables Common Code.  This class Inherits from DataTable. Also, it can …
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
There's a multitude of different network monitoring solutions out there, and you're probably wondering what makes NetCrunch so special. It's completely agentless, but does let you create an agent, if you desire. It offers powerful scalability …
Sometimes it takes a new vantage point, apart from our everyday security practices, to truly see our Active Directory (AD) vulnerabilities. We get used to implementing the same techniques and checking the same areas for a breach. This pattern can re…

617 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question