Solved

Resizing multiple images runs out of memory

Posted on 2008-10-07
3
837 Views
Last Modified: 2012-05-05
Hi all,

Below is a function that I wrote that resizes images for a website. After it processes about 250 images, I run out of memory, leading me to believe that my dispose isn't working? There are 900 photos to process total. What have I missed?
Function resizeImage(ByVal imageName As String, ByVal newWidth As Integer, ByVal imageType As String, ByVal homeDirectory As String) As String
 
        Dim originalFileName As String
        Dim newFileName As String
        Dim tmpImage As Drawing.Bitmap
        Dim newImage As Drawing.Bitmap
        Dim g As Graphics
        Dim newHeight As Integer
 
        originalFileName = pickupFolder & imageName
        If File.Exists(originalFileName) = True Then
            Try
                tmpImage = New Bitmap(Bitmap.FromFile(originalFileName))
                newHeight = (newWidth * tmpImage.Height) / tmpImage.Width
 
                newImage = New Bitmap(newWidth, newHeight)
                g = Graphics.FromImage(newImage)
 
 
                ' draw it with the new size
                g.DrawImage(tmpImage, 0, 0, newWidth, newHeight)
 
                newFileName = imageType & Replace(imageName, " ", "")
                newImage.Save("c:\inetpub\wwwroot\" & homeDirectory & "\photos\" & newFileName, Drawing.Imaging.ImageFormat.Jpeg)
                g.Dispose()
                newImage.Dispose()
                tmpImage.Dispose()
 
                tmpImage = Nothing
                newImage = Nothing
                g = Nothing
 
                resizeImage = newFileName
 
            Catch ex As Exception
 
                streamWriter.WriteLine(originalFileName & " gave error: " & ex.Message)
                Console.WriteLine(originalFileName & " gave error: " & ex.Message)
 
            End Try
 
        Else
            streamWriter.WriteLine(originalFileName & " does not exist")
            Console.WriteLine(originalFileName & " does not exist")
        End If
 
        tmpImage = Nothing
        newImage = Nothing
        g = Nothing
 
    End Function

Open in new window

0
Comment
Question by:DEWebWorks
  • 2
3 Comments
 
LVL 14

Accepted Solution

by:
rachitkohli earned 500 total points
ID: 22658453
I would suggest making an image from the file using file stream object.

Dim fs as IO.FileStream
fs=new IO.FileStream("FILEPATH", ACCESSTYPE)
fs.close

tmpImage=Bitmap.FromStream(fs)

'Please check for the syntax, as am directly typing here without testing it...
0
 

Author Closing Comment

by:DEWebWorks
ID: 31503786
Very nice! Thanks.
0
 

Author Comment

by:DEWebWorks
ID: 22658504
Here's the final code:

    Function resizeImage(ByVal imageName As String, ByVal newWidth As Integer, ByVal imageType As String, ByVal homeDirectory As String) As String
 
        Dim originalFileName As String
        Dim newFileName As String
        Dim tmpImage As Drawing.Bitmap
        Dim newImage As Drawing.Bitmap
        Dim g As Graphics
        Dim newHeight As Integer
 
        '---
        Dim fs As IO.FileStream
        '---
 
        originalFileName = pickupFolder & imageName
        If File.Exists(originalFileName) = True Then
            Try
                'tmpImage = New Bitmap(Bitmap.FromFile(originalFileName))
                '---
                fs = New IO.FileStream(originalFileName, FileMode.Open)
 
                tmpImage = Bitmap.FromStream(fs)
                fs.Close()
                '---
 
                newHeight = (newWidth * tmpImage.Height) / tmpImage.Width
 
                newImage = New Bitmap(newWidth, newHeight)
                g = Graphics.FromImage(newImage)
 
 
                ' draw it with the new size
                g.DrawImage(tmpImage, 0, 0, newWidth, newHeight)
                g.Dispose()
 
                newFileName = imageType & Replace(imageName, " ", "")
                newImage.Save("c:\inetpub\wwwroot\" & homeDirectory & "\photos\" & newFileName, Drawing.Imaging.ImageFormat.Jpeg)
 
                newImage.Dispose()
                tmpImage.Dispose()
 
                tmpImage = Nothing
                newImage = Nothing
                g = Nothing
 
                resizeImage = newFileName
 
            Catch ex As Exception
 
                streamWriter.WriteLine(originalFileName & " gave error: " & ex.Message)
                Console.WriteLine(originalFileName & " gave error: " & ex.Message)
 
            End Try
 
        Else
            streamWriter.WriteLine(originalFileName & " does not exist")
            Console.WriteLine(originalFileName & " does not exist")
        End If
 
        tmpImage = Nothing
        newImage = Nothing
        g = Nothing
 
    End Function

Open in new window

0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This tutorial demonstrates one way to create an application that runs without any Forms but still has a GUI presence via an Icon in the System Tray. The magic lies in Inheriting from the ApplicationContext Class and passing that to Application.Ru…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Although Jacob Bernoulli (1654-1705) has been credited as the creator of "Binomial Distribution Table", Gottfried Leibniz (1646-1716) did his dissertation on the subject in 1666; Leibniz you may recall is the co-inventor of "Calculus" and beat Isaac…

839 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question