• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1048
  • Last Modified:

Firefox won't process frames['frame1'].location.href = toLocation;

having a challenge getting Firefox to work with the following javascript...it's a rado button that opens two frames:
<script type="text/javascript">
function frame1(toLocation) 
{
    frames['frame1'].location.href = toLocation;
}
    </script>
    
    
    <script type="text/javascript">
function frame2(toLocation) 
{
    frames['frame2'].location.href = toLocation;
}
    </script>
    
    
<input type="radio" checked value="1" onClick="frame1('myaddress.asp?b=<%=Request.QueryString("b")%>;frame2('myaddress2.asp?b=<%=Request.QueryString("b")%>');" name="inlinedisplay">

Open in new window

0
hessfirm1
Asked:
hessfirm1
  • 4
  • 3
1 Solution
 
Michel PlungjanIT ExpertCommented:
Please show the frame definition

If you only have ID="frame1" you need document.getElementById('frame1').src
but for compatibility with older browser use NAME="frame1"
and window.frames["frame1"].location
0
 
hessfirm1Author Commented:
here's the code with the frames....it works in IE, but in firefox, the radio buttons don't do anything. Thanks!
<script type="text/javascript">
function frame1(toLocation) 
{
    frames['frame1'].location.href = toLocation;
}
    </script>
    
    
    <script type="text/javascript">
function frame2(toLocation) 
{
    frames['frame2'].location.href = toLocation;
}
    </script>
    
    
<input type="radio" checked value="1" onClick="frame1('myaddress.asp?b=<%=Request.QueryString("b")%>;frame2('myaddress2.asp?b=<%=Request.QueryString("b")%>');" name="inlinedisplay">
 
 
 
<iframe id="frame1" src="myurl" scrolling="no" marginwidth="0" marginheight="0" frameborder="0" vspace="0" hspace="0" style="overflow:visible; width:100%; display:none" target="_self"></iframe>
<iframe id="frame2" src="myurl2" scrolling="no" marginwidth="0" marginheight="0" frameborder="0" vspace="0" hspace="0" style="overflow:visible; width:100%; display:none;"></iframe>

Open in new window

0
 
Michel PlungjanIT ExpertCommented:
So do what I suggested

change
id="frame1" to name="frame1"
0
Cloud Class® Course: SQL Server Core 2016

This course will introduce you to SQL Server Core 2016, as well as teach you about SSMS, data tools, installation, server configuration, using Management Studio, and writing and executing queries.

 
hessfirm1Author Commented:
hmmm....by making it name="frame1" versus id="frame1" the frames don't open at all in firefox w/ or w/out the radio buttons.
0
 
hessfirm1Author Commented:
hang in there...i'm reading that this might be a firefox radio button issue...i'll update this shortly.
0
 
Michel PlungjanIT ExpertCommented:
You also need to close the bracket

<input type="radio" checked value="1" onClick="frame1('myaddress.asp?b=<%=Request.QueryString("b")%>;

should be

<input type="radio" checked value="1" onClick="frame1('myaddress.asp?b=<%=Request.QueryString("b")%>');

0
 
Michel PlungjanIT ExpertCommented:
Solved

You named the frames the same as the function

Here is a better solution
<script type="text/javascript">
function setFrame(frameName,toLocation) {
    window.frames[frameName].location.href = toLocation;
}
    </script>
    
    
<input type="radio" checked value="1" 
onClick="setFrame('frame1','myaddress.asp?b=<%=Request.QueryString("b")%>');
setFrame('frame2','myaddress2.asp?b=<%=Request.QueryString("b")%>');" name="inlinedisplay">
 
 
 
<iframe name="frame1" src="about:blank" scrolling="no" marginwidth="0" marginheight="0" frameborder="0" vspace="0" hspace="0" 
style="overflow:visible; width:100%; display:none" target="_self"></iframe>
<iframe name="frame2" src="about:blank" scrolling="no" marginwidth="0" marginheight="0" frameborder="0" vspace="0" hspace="0" 
style="overflow:visible; width:100%; display:none;"></iframe>

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

The 14th Annual Expert Award Winners

The results are in! Meet the top members of our 2017 Expert Awards. Congratulations to all who qualified!

  • 4
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now