Solved

CC and BCC not working when passing empty string

Posted on 2008-10-09
9
492 Views
Last Modified: 2013-12-17
Hi
I have attached some code, problem is this section:
 if (strCC != string.Empty || strCC != "")
        {
            MailAddress cc = new MailAddress(strCC.ToString());
            msg.CC.Add(cc);
       }
        if (strBCC != string.Empty || strBCC != "")
        {
            MailAddress bcc = new MailAddress(strBCC.ToString());
            msg.Bcc.Add(bcc);
      }

When i pass an empty string to CC or BCC, no email is sent, but if i remove the 'if blocks' and give CC and BCC a valid email it works ok.

Not all webpages will send a CC or BCC hence the 'if' blocks.
Anyone any idea on how to get the code to when the CC or BCC is an empty string.
Regards
George

using System;

using System.Collections.Generic;

using System.Linq;

using System.Web;

using System.Net.Mail;
 

/// <summary>

/// Summary description for PublicEmails

/// </summary>

public static class PublicEmails

{

    public static void PublicSendEmail(string strEmailFrom,

                                       string strEmailFromName,

                                       string strEmailTo,

                                       string strEmailToName,

                                       string strCC,

                                       string strBCC,

                                       string strSubject, 

                                       string strBody)

    {

        MailAddress from = new MailAddress(strEmailFrom.ToString(), strEmailFromName.ToString());

        MailAddress to = new MailAddress(strEmailTo.ToString(),strEmailToName.ToString());

        MailMessage msg = new MailMessage(from, to);

        msg.Subject = strSubject.ToString();

        msg.Body = strBody.ToString();

        //if (strCC != string.Empty || strCC != "")

        //{

            MailAddress cc = new MailAddress(strCC.ToString());

            msg.CC.Add(cc);

        //}

        //if (strBCC != string.Empty || strBCC != "")

        //{

            MailAddress bcc = new MailAddress(strBCC.ToString());

            msg.Bcc.Add(bcc);

        //}

        SmtpClient mailClient = new SmtpClient("LocalHost");

        try

        {

            mailClient.Send(msg);

        }

        catch (Exception ex)

        {

            throw new ApplicationException(ex.Message);

        }

    }

}

Open in new window

0
Comment
Question by:BeginningWebDesign
  • 4
  • 2
  • 2
  • +1
9 Comments
 
LVL 26

Expert Comment

by:Anurag Thakur
Comment Utility
can you please put a light on what exception comes when you run your code and i will request to try my code block to send the email again

if (strCC != null && strCC != string.Empty)
{
            MailAddress cc = new MailAddress(strCC.ToString());
            msg.CC.Add(cc);
}

if (strBCC != null && strBCC != string.Empty)
{
            MailAddress bcc = new MailAddress(strBCC.ToString());
            msg.Bcc.Add(bcc);
}
0
 

Author Comment

by:BeginningWebDesign
Comment Utility
Hi ragi0017:

Its not throwing an error, everything goes ok and the data is inserted into the database, i'm just not receiving the email

George
0
 
LVL 26

Expert Comment

by:Anurag Thakur
Comment Utility
sendmail does not throw an error when you try the if blocks for cc and bcc for empty strings and you also dont get the emails
thats quite surprising - if there are not exceptions then you should be getting the mails definitely
0
 
LVL 3

Expert Comment

by:trunghieubkit
Comment Utility
Here's yours,

All email addresses must be matched with email expression before sending

string strPattern = @"[a-zA-Z0-9\-\.]+@[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,4}";


public static void PublicSendEmail(string strEmailFrom,

                                   string strEmailFromName,

                                   string strEmailTo,

                                   string strEmailToName,

                                   string strCC,

                                   string strBCC,

                                   string strSubject,

                                   string strBody)

{

    string strPattern = @"[a-zA-Z0-9\-\.]+@[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,4}";
 

    if (!Regex.IsMatch(strEmailFrom, strPattern) || !Regex.IsMatch(strEmailTo, strPattern))

    {

        return;

    }
 

    MailAddress from = new MailAddress(strEmailFrom, strEmailFromName);

    MailAddress to = new MailAddress(strEmailTo, strEmailToName);

    MailMessage msg = new MailMessage(from, to);
 

    msg.Subject = strSubject;

    msg.Body = strBody;
 

    if (Regex.IsMatch(strCC, strPattern))

    {

           MailAddress cc = new MailAddress(strCC.ToString());

           msg.CC.Add(cc);

    }
 

    if (Regex.IsMatch(strBCC, strPattern))

    {

        MailAddress bcc = new MailAddress(strBCC.ToString());

        msg.Bcc.Add(bcc);

    }
 

    SmtpClient mailClient = new SmtpClient("LocalHost");

    try

    {

        mailClient.Send(msg);

    }

    catch (Exception ex)

    {

        throw new ApplicationException(ex.Message);

    }

}

Open in new window

0
6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

 

Author Comment

by:BeginningWebDesign
Comment Utility
Hi
Found problem, its seems to be with Windows XP, i can send 2 test emails and they then end up in my Yahoo spam folder, then for some reason XP will not send anymore, i've looked in the C:\Inetpub\mailroot folders and no messages are there, restart XP and the test emails are then sent
George
0
 
LVL 22

Expert Comment

by:prairiedog
Comment Utility
Hi BeginningWebDesign, do you happen to have any anti-virus software installed, such as Symantec?
0
 

Author Comment

by:BeginningWebDesign
Comment Utility
Hi prairiedog:
I have McAfee, but i have opened the ports for sending mail
Regards
George
0
 
LVL 22

Accepted Solution

by:
prairiedog earned 500 total points
Comment Utility
Next time check the Queue folder under mailroot, you may find them sitting there.
I have Symantec installed and it keeps my outgoing emails in Queue folder until I reboot my machine. I end up with temporarily disabling Symantec real-time protection when I test my email function. Then turn the real-time protection back on after the test.
0
 

Author Closing Comment

by:BeginningWebDesign
Comment Utility
Hi prairiedog:
That worked, still seems a bit odd for that to happen even though i have opened up port 110 and 25
Thanks
George
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Introduction Hi all and welcome to my first article on Experts Exchange. A while ago, someone asked me if i could do some tutorials on object oriented programming. I decided to do them on C#. Now you may ask me, why's that? Well, one of the re…
Many of us here at EE write code. Many of us write exceptional code; just as many of us write exception-prone code. As we all should know, exceptions are a mechanism for handling errors which are typically out of our control. From database errors, t…
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
Access reports are powerful and flexible. Learn how to create a query and then a grouped report using the wizard. Modify the report design after the wizard is done to make it look better. There will be another video to explain how to put the final p…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

7 Experts available now in Live!

Get 1:1 Help Now