Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 329
  • Last Modified:

Table locking with nested sets?

I'm attempting to use nested sets to represent a data hierarchy (see: http://dev.mysql.com/tech-resources/articles/hierarchical-data.html, except I'm doing it in SQL 2000, not MySQL).

I've written a stored procedure that handles an insert, it looks something like this the simplified code snippet I've attached.  It works fine, but my concern is about concurrent users (i.e. someone else updating/inserting and affecting the hierarchy at the same time).  The MySQL example uses a lock on the what I can only assume is the whole table before doing anything, but this seems like it might be
dangerous and/or overkill, especially if this data is ultimately being viewed a lot on a public web site.  I thought about just creating a seperate table with one field and one row to act as a lock in this stored procedure (and potentially a couple other related SPs), but that doesn't seem like a best practice.

Any thoughts?

CREATE PROCEDURE [dbo].[INSERT_NESTED_SET_WEBPAGE]
	@varTitle varchar(256),
	@parent int
AS
 
-- get the parent's rgt value
DECLARE @parentRight int;
SELECT @parentRight = rgt FROM my_data WHERE ID = @parent
 
-- make room for the new child (at the end of the nested set)
UPDATE my_data SET lft = lft + 2 WHERE lft >= @parentRight
UPDATE my_data SET rgt = rgt + 2 WHERE rgt >= @parentRight
 
-- insert the new child (at the end of the nested set)
INSERT INTO my_date (title, lft, rgt) VALUES (
	@varTitle,
	@parentRight,
	@parentRight + 1)
 
GO

Open in new window

0
saitwebdev
Asked:
saitwebdev
1 Solution
 
puranik_pCommented:
Just put the whole thing in a transaction. That's it!
The transactions are the simplest way to take care of the concurrency.
CREATE PROCEDURE [dbo].[INSERT_NESTED_SET_WEBPAGE]
        @varTitle varchar(256),
        @parent int
AS
 
-- get the parent's rgt value
DECLARE @parentRight int;
BEGIN TRANSACTION
SELECT @parentRight = rgt FROM my_data WHERE ID = @parent
 
-- make room for the new child (at the end of the nested set)
UPDATE my_data SET lft = lft + 2 WHERE lft >= @parentRight
UPDATE my_data SET rgt = rgt + 2 WHERE rgt >= @parentRight
 
-- insert the new child (at the end of the nested set)
INSERT INTO my_date (title, lft, rgt) VALUES (
        @varTitle,
        @parentRight,
        @parentRight + 1)
 
COMMIT TRANSACTION
GO

Open in new window

0
 
saitwebdevAuthor Commented:
Thank you.  I came to that conclusion some time ago, but it's good to have confirmation.
0

Featured Post

VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now