Solved

There must be a more efficient way to varify if the correct radio button has been selected.

Posted on 2008-10-11
6
142 Views
Last Modified: 2010-04-23
There must be a more efficient way of verifying if the correct radio button has been selected. Any suggestions?
Private Sub btbOK_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btbOK.Click
 
        Dim BoardForm As New frmQuestion
 
        If RB1.Tag = m_CorrectAnswer Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("Sorry", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If
        If RB2.Tag = m_CorrectAnswer Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("That is Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("That is wrong!", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If
        If RB3.Tag = m_CorrectAnswer Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("That is Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("That is wrong!", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If
        If RB4.Tag = m_CorrectAnswer Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("That is Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("That is wrong!", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If
        Me.Close()
    End Sub

Open in new window

0
Comment
Question by:98fatboyrider
6 Comments
 
LVL 42

Expert Comment

by:dqmq
ID: 22694379
First, below I show some (trivially) more efficient code.  Perhaps more importantly, it's more concise and to the point.

Second, you may want to consider putting the radio buttons in an option group.  The benefits are that you can reduce the OK button to a single test:
   If OptionGroup = m_correctAnswer
         Msgbox "correct"
   Else
         Msgbox "wrong"
   end if

Also, when one is selected the others will automatically go unselected so you don't have to manage that in code.


   If RB1.Tag = m_CorrectAnswer
or RB2.Tag = m_CorrectAnswer 
or RB3.Tag = m_CorrectAnswer 
or RB4.Tag = m_CorrectAnswer 
or RB5.Tag = m_CorrectAnswer  
Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("Sorry", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If

Open in new window

0
 

Author Comment

by:98fatboyrider
ID: 22694423
When using the code above, I'm getting syntax errors on all the "or" and "then". This is vb.net if that helps.
0
 
LVL 85

Accepted Solution

by:
Mike Tomlinson earned 500 total points
ID: 22694507
Well...you can use the UnderScore "_" character as a line continuation flag, or put it all on the same line.

I would also use "OrElse" instead of "Or" so that it short-circuits at the first match and doesn't need to check the rest of the RadioButtons.

So like this:

    If RB1.Tag = m_CorrectAnswer _
    OrElse RB2.Tag = m_CorrectAnswer _
    OrElse RB3.Tag = m_CorrectAnswer _
    OrElse RB4.Tag = m_CorrectAnswer _
    OrElse RB5.Tag = m_CorrectAnswer _
    Then

Or like this:
    Private Sub btbOK_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btbOK.Click
        If RB1.Tag = m_CorrectAnswer OrElse RB2.Tag = m_CorrectAnswer OrElse RB3.Tag = m_CorrectAnswer OrElse RB4.Tag = m_CorrectAnswer OrElse RB5.Tag = m_CorrectAnswer Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("Sorry", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If
        Me.Close()
    End Sub

Open in new window

0
3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

 
LVL 55

Expert Comment

by:Jaime Olivares
ID: 22694553
You can use a custom control like this:
http://www.codeproject.com/KB/combobox/RadioListBoxDotNetVersion.aspx
It simultates a radio button collection and you can retrieve in one step with SelectedIndex
0
 
LVL 85

Expert Comment

by:Mike Tomlinson
ID: 22694575
Pretty cool control jaime...  =)

Another generic option is to iterate over the range of names you want to check and find the control on the form.

I wouldn't say this is more "efficient" than hard coding if the radiobuttons are static but I thought I would present it anyways since it has many uses:
(this version is for VB.Net 2005 or above)
    Private Sub btbOK_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btbOK.Click
        Dim correct As Boolean = False
        For i As Integer = 1 To 5
            Dim matches() As Control = Me.Controls.Find("RB" & i, True)
            If matches.Length > 0 AndAlso TypeOf matches(0) Is RadioButton Then
                If matches(0).Tag = m_CorrectAnswer Then
                    correct = True
                    Exit For
                End If
            End If
        Next
 
        If correct Then
            PlayerTotal = (m_sender * 200) + PlayerTotal
            MessageBox.Show("Correct!", "Correct", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        Else
            MessageBox.Show("Sorry", "Wrong", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
        End If
        Me.Close()
    End Sub

Open in new window

0
 

Author Closing Comment

by:98fatboyrider
ID: 31505319
Thanks for the help.
0

Featured Post

Courses: Start Training Online With Pros, Today

Brush up on the basics or master the advanced techniques required to earn essential industry certifications, with Courses. Enroll in a course and start learning today. Training topics range from Android App Dev to the Xen Virtualization Platform.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Wouldn’t it be nice if you could test whether an element is contained in an array by using a Contains method just like the one available on List objects? Wouldn’t it be good if you could write code like this? (CODE) In .NET 3.5, this is possible…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

785 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question