ASP.NET: Problem with multiple user controls on same page

Hi,
I built a user control to validate and compare two values and I use it on my page. When I only have one instance of the user control, the control works fine. But When I put many of them on the same page, if I type a value in the first instance, it is reflected invisibly on the last one. This make that I can't make do my comparison(done with Javascript) any more. Does some one know why?


<%@ Control Language="C#" AutoEventWireup="true" CodeFile="TextBoxcompareDate.ascx.cs" Inherits="TextBoxcompareDate" %>
<%@ Register TagPrefix="Date" Namespace="userControls" Assembly="TextBoxDate" %>
 
<head >
    <title>Untitled Page</title>
    <script language="javascript" type="text/javascript">
 
function validateDates(source, arguements)
{
    var thevalue = arguements.Value;
    
    arguements.IsValid=false;    
    
    if(!validateDate(thevalue))
    {
        alert(source.errormessage);
        return;
    }
    arguements.IsValid=true;  
            
}
function compareStartEnd()
{ 
var stringFromDate = document.getElementById('<%=txtStart.ClientID%>').value;
var stringToDate = document.getElementById('<%=txtEnd.ClientID%>').value;
 
var FromDate = Date.parse(stringFromDate);
                var ToDate = Date.parse(stringToDate);
                if (FromDate > ToDate)
                    alert('The end date must be greather than the start date');
}
 
    </script>
</head>
<table width="100%">
    <tr>
        <td align="right" width="75%">
            <asp:Label ID="lblCaption" runat="server" Text="Title: " Font-Names="Verdana" Font-Size="10px" ForeColor="#000000"></asp:Label>
        </td>
        <td align="left" width="10%">
            <asp:TextBox 
                ID="txtStart" 
                runat="server" 
                MaxLength="10" 
                Width="80px"             
                style="padding: 2px;border:solid 1px #92C86A;background-color: #ffffff;font-family:Verdana;font-size: 11px;color:#000000;"
                onfocus="this.select();"></asp:TextBox>
         </td>
         <td align="center" width="5%">
            <span style="font-family:Verdana;font-size: 10px;font-weight:bold;color:#000000;">-</span>	        
         </td>
         <td align="left" width="10%">
            <asp:TextBox 
                ID="txtEnd" 
                runat="server" 
                MaxLength="10" 
                Width="80px" 
                style="padding: 2px;border:solid 1px #92C86A;background-color: #ffffff;font-family:Verdana;font-size: 11px;color:#000000;" 
                onfocus="this.select();" 
                onchange="compareStartEnd();" ></asp:TextBox>
        </td>            
    </tr>            
</table>
<asp:CustomValidator 
    ID="cuvStart" 
    runat="server" 
    ControlToValidate="txtStart" 
    ClientValidationFunction="validateDates" 
    ErrorMessage="Incorrect starting date." 
    SetFocusOnError="true"
    Display="None">&nbsp</asp:CustomValidator>
<asp:CustomValidator 
    ID="cuvEnd" 
    runat="server" 
    ControlToValidate="txtEnd" 
    ClientValidationFunction="validateDates" 
    ErrorMessage="Incorrect ending date" 
    SetFocusOnError="true"
    Display="None">&nbsp</asp:CustomValidator>

Open in new window

LVL 4
karakavAsked:
Who is Participating?
 
the_crazedConnect With a Mentor Commented:
as your function is part of the user control, you're redeclaring the same function over and over, changing the startid and endid

I'd take the function out of the control, put it in a common js file, and alter it to something like the code below.

then your onchange needs to be:
onchange="compareStartEnd(event);"
function compareStartEnd(e)
{ 
    if(!e) e=event;
    if(e.srcElement) var el = e.srcElement
    else var el = e.target;
 
    var endId = el.id;
    var startId = endId.replace("txtEnd","txtStart")
 
    var stringFromDate = document.getElementById(startId).value;
    var stringToDate = document.getElementById(endId).value;
 
    var FromDate = Date.parse(stringFromDate);
                var ToDate = Date.parse(stringToDate);
                if (FromDate > ToDate)
                    alert('The end date must be greather than the start date');
}

Open in new window

0
 
crazymanCommented:
This is beacuse your functions are not unique.
you can name your function like

function validateDates_<%=this.ClientID%>(source, arguements)


then hook up your validators in OnLoad like

cuvEnd.ClientValidationFunction = string.format("validateDates_{0}",this.ClientID);
0
 
karakavAuthor Commented:
Thanks a lot. Do you mind telling me how I can set back to focus to the control upon the error message?
0
 
the_crazedCommented:
yep, you've got a pointer to the original control there in "el" so you just add this at the end:
el.focus();

Open in new window

0
All Courses

From novice to tech pro — start learning today.