Solved

Syntax for passing control value to SQL in Access VBA

Posted on 2008-10-14
12
543 Views
Last Modified: 2013-11-27
Hi Experts,

I have an update query that runs an update via ADODB command, but I don't know how to pass the value of the form control to the SQL string. Here is what I have:

Private Sub Form_Close()

Dim myStr, strGroupSQL As String
Dim myRad24, myRad16, myRad4 As Boolean
Dim cmdCommand As ADODB.Command


Set cmdCommand = New ADODB.Command
Set cmdCommand.ActiveConnection = CurrentProject.Connection

myRad24 = Forms!frmLabels!radio24
myRad16 = Forms!frmLabels!radio16
myRad4 = Forms!frmLabels!radio4

strGroupSQL = "UPDATE Tbl_Persistent SET Radio24 = & myRad24 & "

cmdCommand.CommandText = strGroupSQL
cmdCommand.Execute

End Sub

I know the issue is with the syntax for the control, but I don't know where to find the "rules" for how to treat the control to pass it in.

THanks!

Kevin
0
Comment
Question by:k_smee
  • 6
  • 3
  • 3
12 Comments
 

Author Comment

by:k_smee
ID: 22711833
OK..I got this to work by changing this:
strGroupSQL = "UPDATE Tbl_Persistent SET Radio24 =  " & myRad24 & ""

The variable myRad now has a double quote, ampersand on both sides, but it would still benice to know how the rules.
0
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22711919
Since you are building an inline SQL statement, you need to escape any special characters.

So if you want your update statement to be:

update tbl_persistent set radio24 = "Tommy Boy"

where Tommy Boy is the value of forms!frmlabels!radio24, then that value can contain no special characters that would terminate the SQL.  So if the value were Tommy "AKA Tom" Boy, your resultant SQL statement would be:

update tbl_persistent set radio24 = "Tommy "AKA Tom" Boy"

The problem is that the " before AKA stops the string you are setting radio24 equal to and you will get an invalid syntax near AKA error.  To solve this, you can replace any single quotes with double quotes. by doing the following:


myRad24 = replace(Forms!frmLabels!radio24,"""", """""")
myRad16 = replaceForms!frmLabels!radio16 ,"""", """""")
myRad4 = replace(Forms!frmLabels!radio4 ,"""", """""")


Now this may look a bit confusing because there are more than one " in the lines, but even in this case, they need to be escaped.

so inside of the " " that creates a string, a "" represents the value of ".  So """" represents "", which will escape down to " once you execute strGroupSQL.
0
 

Author Comment

by:k_smee
ID: 22712077
My problem is I need to be able to dyanmically pass whatever value is in Forms!frmLabels!radio24. So I couldn't set a literal value like "Tommy Boy".

I know there are different syntax for passing in the value of different data types - this one is a boolean.
I just did trial and error. I don't know how to do it again.
0
Space-Age Communications Transitions to DevOps

ViaSat, a global provider of satellite and wireless communications, securely connects businesses, governments, and organizations to the Internet. Learn how ViaSat’s Network Solutions Engineer, drove the transition from a traditional network support to a DevOps-centric model.

 
LVL 44

Expert Comment

by:Arthur_Wood
ID: 22712219
What kind of value is the Field Radio24 in the Database?  If it is Text field, then the val7ue to be passed must be enclosed in quote marks '...'.  If it a numeric field, then you do not use the enclosing quote marks.
0
 

Author Comment

by:k_smee
ID: 22712248
The field Radio24 is set "Yes/No". So that would be a boolean, correct?
0
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22712290
I did say:
"So if you want your update statement to be:"

as arthur pointed out in http:#22712219, the use of quotes is dependent upon the data type of the field.  For example, datetime fields I believe need to be wrapped in # for access.
0
 

Author Comment

by:k_smee
ID: 22712384
Gotcha, Brandon. I guess my main question at this point is there some guide to how to treat a variable like myRad24? So for a boolean this worked:

" & myRad24 & ""

For a date this might work:

# & myRad24 & #"

For the rest. I don't know...
0
 
LVL 44

Accepted Solution

by:
Arthur_Wood earned 30 total points
ID: 22712409
For a Number (integer, double, any number type), not extra quotes:
" & myRad24
 
for dates:
#" & MyDate & "#"
0
 

Author Comment

by:k_smee
ID: 22712473
What if it is set to String?
0
 
LVL 39

Assisted Solution

by:BrandonGalderisi
BrandonGalderisi earned 20 total points
ID: 22712722
0
 

Author Closing Comment

by:k_smee
ID: 31505904
Thanks guys!
0
 
LVL 44

Expert Comment

by:Arthur_Wood
ID: 22713519
Glad to be of assistance
AW
0

Featured Post

Master Your Team's Linux and Cloud Stack!

The average business loses $13.5M per year to ineffective training (per 1,000 employees). Keep ahead of the competition and combine in-person quality with online cost and flexibility by training with Linux Academy.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

If you have heard of RFC822 date formats, they can be quite a challenge in SQL Server. RFC822 is an Internet standard format for email message headers, including all dates within those headers. The RFC822 protocols are available in detail at:   ht…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
What’s inside an Access Desktop Database. Will look at the basic interface, Navigation Pane (Database Container), Tables, Queries, Forms, Report, Macro’s, and VBA code.
This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

789 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question