Solved

Syntax for passing control value to SQL in Access VBA

Posted on 2008-10-14
12
551 Views
Last Modified: 2013-11-27
Hi Experts,

I have an update query that runs an update via ADODB command, but I don't know how to pass the value of the form control to the SQL string. Here is what I have:

Private Sub Form_Close()

Dim myStr, strGroupSQL As String
Dim myRad24, myRad16, myRad4 As Boolean
Dim cmdCommand As ADODB.Command


Set cmdCommand = New ADODB.Command
Set cmdCommand.ActiveConnection = CurrentProject.Connection

myRad24 = Forms!frmLabels!radio24
myRad16 = Forms!frmLabels!radio16
myRad4 = Forms!frmLabels!radio4

strGroupSQL = "UPDATE Tbl_Persistent SET Radio24 = & myRad24 & "

cmdCommand.CommandText = strGroupSQL
cmdCommand.Execute

End Sub

I know the issue is with the syntax for the control, but I don't know where to find the "rules" for how to treat the control to pass it in.

THanks!

Kevin
0
Comment
Question by:k_smee
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 6
  • 3
  • 3
12 Comments
 

Author Comment

by:k_smee
ID: 22711833
OK..I got this to work by changing this:
strGroupSQL = "UPDATE Tbl_Persistent SET Radio24 =  " & myRad24 & ""

The variable myRad now has a double quote, ampersand on both sides, but it would still benice to know how the rules.
0
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22711919
Since you are building an inline SQL statement, you need to escape any special characters.

So if you want your update statement to be:

update tbl_persistent set radio24 = "Tommy Boy"

where Tommy Boy is the value of forms!frmlabels!radio24, then that value can contain no special characters that would terminate the SQL.  So if the value were Tommy "AKA Tom" Boy, your resultant SQL statement would be:

update tbl_persistent set radio24 = "Tommy "AKA Tom" Boy"

The problem is that the " before AKA stops the string you are setting radio24 equal to and you will get an invalid syntax near AKA error.  To solve this, you can replace any single quotes with double quotes. by doing the following:


myRad24 = replace(Forms!frmLabels!radio24,"""", """""")
myRad16 = replaceForms!frmLabels!radio16 ,"""", """""")
myRad4 = replace(Forms!frmLabels!radio4 ,"""", """""")


Now this may look a bit confusing because there are more than one " in the lines, but even in this case, they need to be escaped.

so inside of the " " that creates a string, a "" represents the value of ".  So """" represents "", which will escape down to " once you execute strGroupSQL.
0
 

Author Comment

by:k_smee
ID: 22712077
My problem is I need to be able to dyanmically pass whatever value is in Forms!frmLabels!radio24. So I couldn't set a literal value like "Tommy Boy".

I know there are different syntax for passing in the value of different data types - this one is a boolean.
I just did trial and error. I don't know how to do it again.
0
How To Install Bash on Windows 10

Windows’ budding partnership with Canonical has certainly led to some great improvements. One of them being the ability to use Bash on your Windows machine without third party applications! This might be one of the greatest things a cloud engineer in a Windows environment can do!

 
LVL 44

Expert Comment

by:Arthur_Wood
ID: 22712219
What kind of value is the Field Radio24 in the Database?  If it is Text field, then the val7ue to be passed must be enclosed in quote marks '...'.  If it a numeric field, then you do not use the enclosing quote marks.
0
 

Author Comment

by:k_smee
ID: 22712248
The field Radio24 is set "Yes/No". So that would be a boolean, correct?
0
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22712290
I did say:
"So if you want your update statement to be:"

as arthur pointed out in http:#22712219, the use of quotes is dependent upon the data type of the field.  For example, datetime fields I believe need to be wrapped in # for access.
0
 

Author Comment

by:k_smee
ID: 22712384
Gotcha, Brandon. I guess my main question at this point is there some guide to how to treat a variable like myRad24? So for a boolean this worked:

" & myRad24 & ""

For a date this might work:

# & myRad24 & #"

For the rest. I don't know...
0
 
LVL 44

Accepted Solution

by:
Arthur_Wood earned 30 total points
ID: 22712409
For a Number (integer, double, any number type), not extra quotes:
" & myRad24
 
for dates:
#" & MyDate & "#"
0
 

Author Comment

by:k_smee
ID: 22712473
What if it is set to String?
0
 
LVL 39

Assisted Solution

by:BrandonGalderisi
BrandonGalderisi earned 20 total points
ID: 22712722
0
 

Author Closing Comment

by:k_smee
ID: 31505904
Thanks guys!
0
 
LVL 44

Expert Comment

by:Arthur_Wood
ID: 22713519
Glad to be of assistance
AW
0

Featured Post

Use Case: Protecting a Hybrid Cloud Infrastructure

Microsoft Azure is rapidly becoming the norm in dynamic IT environments. This document describes the challenges that organizations face when protecting data in a hybrid cloud IT environment and presents a use case to demonstrate how Acronis Backup protects all data.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In earlier versions of Windows (XP and before), you could drag a database to the taskbar, where it would appear as a taskbar icon to open that database.  This article shows how to recreate this functionality in Windows 7 through 10.
Access custom database properties are useful for storing miscellaneous bits of information in a format that persists through database closing and reopening.  This article shows how to create and use them.
In Microsoft Access, when working with VBA, learn some techniques for writing readable and easily maintained code.
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …
Suggested Courses

622 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question