Solved

System.InvalidCastException: Specified cast is not valid, Microsoft Visual Studio, C#

Posted on 2008-10-14
7
844 Views
Last Modified: 2013-11-26
I am writing a program which runs a stored procedure to return the data, then output the content to a CSV file.   When running my stored procedure, I get all the values back.  However, when I run the program, it stops what iit's doing and gives me the following error:

************** Exception Text **************
System.InvalidCastException: Specified cast is not valid.


I took a look at the CSV file and it populated 23 out of the 57 lines before it gives me this error message.  After doing some testing, I took out the following line and it worked successfully:

Decimal decDiscount = (Decimal)rowA["Discount"];

Can someone please help me solve this issue? I'm not sure what i'm doing wrong with the "Discount" column of the Stored Procedure.  The "Total" column has no problems, but its only the "Discount" column.  Both columns are the same data type of "money".
this.spTableAdapter.Fill(this.twOLTPDDataSet.spSproc);

DataView data = new DataView(twOLTPDDataSet.spSproc);
 

//Begin each row cycle

foreach (DataRowView rowA in currMinorData)

{

    string strCustomer = (string)rowA["Customer"];

    string strName = (string)rowA["Name"];
 

    Decimal decTotal = (Decimal)rowA["Total"];

    string strTotal = decTotal.ToString();
 

    Decimal decDiscount = (Decimal)rowA["Discount"];

    string strDiscount = decDiscount.ToString();
 

    Write Comma Delimiter to the file

    CorporateSpending.WriteLine(strCustomer + "," + strName + "," + strTotal + "," + strDiscount);
 

}

Open in new window

0
Comment
Question by:IndianaTech
  • 4
  • 2
7 Comments
 
LVL 22

Accepted Solution

by:
p_davis earned 450 total points
ID: 22714641
try the conversion
Convert.ToDecimal(rowA["Discount"]);
instead of the cast
0
 
LVL 13

Assisted Solution

by:TechTiger007
TechTiger007 earned 50 total points
ID: 22714705
If you have null values for Discount then the type casting will fail.
Check if the value is DBNull.value or null and then type cast it to Decimal using Convert.ToDecimal only if it is valid.
0
 

Author Comment

by:IndianaTech
ID: 22714777
@p_davis: I updated my code to reflect your change.
and I am getting a different error back this time:

************** Exception Text **************
System.InvalidCastException: Object cannot be cast from DBNull to other types.
   at System.DBNull.System.IConvertible.ToDecimal(IFormatProvider provider)
   at System.Convert.ToDecimal(Object value)
************** Exception Text **************

I looked at the results of the CSV file and it has 22 lines in the file.  I looked at Query Analyzer and the 23rd row doesn't have any Null values in it.  I'm not too sure why it would be telling me it cannot cast from DBNull to other types.
string strDiscount = Convert.ToDecimal(rowA["Discount"]).ToString();

Open in new window

0
IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 
LVL 22

Expert Comment

by:p_davis
ID: 22714823
add what Tech Suggested with the

if(rowA["Discount"] != DbNull.Value)
   strDiscount = Convert.ToDecimal(rowA["Discount"]).ToString();

wait why are you converting to decimal and then to string?

what about

String strDiscount = String.Format("{0}:c", rowA["Discount"]);
0
 
LVL 22

Expert Comment

by:p_davis
ID: 22714850
sorry that would be...

String strDiscount = String.Format("{1:c}", rowA["Discount"]);
0
 

Author Comment

by:IndianaTech
ID: 22714950
@p_davis: Have a problem with the DbNull.Value.

When building it, i got an error that says:
"The name 'DbNull' doe snot exist in the current context."
0
 
LVL 22

Expert Comment

by:p_davis
ID: 22714977
sorry

DBNull
0

Featured Post

Highfive Gives IT Their Time Back

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

For those of you who don't follow the news, or just happen to live under rocks, Microsoft Research released a beta SDK (http://www.microsoft.com/en-us/download/details.aspx?id=27876) for the Xbox 360 Kinect. If you don't know what a Kinect is (http:…
This article is for Object-Oriented Programming (OOP) beginners. An Interface contains declarations of events, indexers, methods and/or properties. Any class which implements the Interface should provide the concrete implementation for each Inter…
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
This video gives you a great overview about bandwidth monitoring with SNMP and WMI with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're looking for how to monitor bandwidth using netflow or packet s…

760 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

23 Experts available now in Live!

Get 1:1 Help Now