Solved

System.InvalidCastException: Specified cast is not valid, Microsoft Visual Studio, C#

Posted on 2008-10-14
7
921 Views
Last Modified: 2013-11-26
I am writing a program which runs a stored procedure to return the data, then output the content to a CSV file.   When running my stored procedure, I get all the values back.  However, when I run the program, it stops what iit's doing and gives me the following error:

************** Exception Text **************
System.InvalidCastException: Specified cast is not valid.


I took a look at the CSV file and it populated 23 out of the 57 lines before it gives me this error message.  After doing some testing, I took out the following line and it worked successfully:

Decimal decDiscount = (Decimal)rowA["Discount"];

Can someone please help me solve this issue? I'm not sure what i'm doing wrong with the "Discount" column of the Stored Procedure.  The "Total" column has no problems, but its only the "Discount" column.  Both columns are the same data type of "money".
this.spTableAdapter.Fill(this.twOLTPDDataSet.spSproc);
DataView data = new DataView(twOLTPDDataSet.spSproc);
 
//Begin each row cycle
foreach (DataRowView rowA in currMinorData)
{
    string strCustomer = (string)rowA["Customer"];
    string strName = (string)rowA["Name"];
 
    Decimal decTotal = (Decimal)rowA["Total"];
    string strTotal = decTotal.ToString();
 
    Decimal decDiscount = (Decimal)rowA["Discount"];
    string strDiscount = decDiscount.ToString();
 
    Write Comma Delimiter to the file
    CorporateSpending.WriteLine(strCustomer + "," + strName + "," + strTotal + "," + strDiscount);
 
}

Open in new window

0
Comment
Question by:IndianaTech
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 2
7 Comments
 
LVL 22

Accepted Solution

by:
p_davis earned 450 total points
ID: 22714641
try the conversion
Convert.ToDecimal(rowA["Discount"]);
instead of the cast
0
 
LVL 13

Assisted Solution

by:TechTiger007
TechTiger007 earned 50 total points
ID: 22714705
If you have null values for Discount then the type casting will fail.
Check if the value is DBNull.value or null and then type cast it to Decimal using Convert.ToDecimal only if it is valid.
0
 

Author Comment

by:IndianaTech
ID: 22714777
@p_davis: I updated my code to reflect your change.
and I am getting a different error back this time:

************** Exception Text **************
System.InvalidCastException: Object cannot be cast from DBNull to other types.
   at System.DBNull.System.IConvertible.ToDecimal(IFormatProvider provider)
   at System.Convert.ToDecimal(Object value)
************** Exception Text **************

I looked at the results of the CSV file and it has 22 lines in the file.  I looked at Query Analyzer and the 23rd row doesn't have any Null values in it.  I'm not too sure why it would be telling me it cannot cast from DBNull to other types.
string strDiscount = Convert.ToDecimal(rowA["Discount"]).ToString();

Open in new window

0
Online Training Solution

Drastically shorten your training time with WalkMe's advanced online training solution that Guides your trainees to action. Forget about retraining and skyrocket knowledge retention rates.

 
LVL 22

Expert Comment

by:p_davis
ID: 22714823
add what Tech Suggested with the

if(rowA["Discount"] != DbNull.Value)
   strDiscount = Convert.ToDecimal(rowA["Discount"]).ToString();

wait why are you converting to decimal and then to string?

what about

String strDiscount = String.Format("{0}:c", rowA["Discount"]);
0
 
LVL 22

Expert Comment

by:p_davis
ID: 22714850
sorry that would be...

String strDiscount = String.Format("{1:c}", rowA["Discount"]);
0
 

Author Comment

by:IndianaTech
ID: 22714950
@p_davis: Have a problem with the DbNull.Value.

When building it, i got an error that says:
"The name 'DbNull' doe snot exist in the current context."
0
 
LVL 22

Expert Comment

by:p_davis
ID: 22714977
sorry

DBNull
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Just a quick little trick I learned recently.  Now that I'm using jQuery with abandon in my asp.net applications, I have grown tired of the following syntax:      (CODE) I suppose it just offends my sense of decency to put inline VBScript on a…
Exception Handling is in the core of any application that is able to dignify its name. In this article, I'll guide you through the process of writing a DRY (Don't Repeat Yourself) Exception Handling mechanism, using Aspect Oriented Programming.
In this brief tutorial Pawel from AdRem Software explains how you can quickly find out which services are running on your network, or what are the IP addresses of servers responsible for each service. Software used is freeware NetCrunch Tools (https…
Visualize your data even better in Access queries. Given a date and a value, this lesson shows how to compare that value with the previous value, calculate the difference, and display a circle if the value is the same, an up triangle if it increased…

617 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question