Solved

Date string comparison in VBS

Posted on 2008-10-15
5
489 Views
Last Modified: 2010-04-24
I am trying to read printer event log record and just sect certain dates. The relevant lines of the code are as below.

Why does it still return dates where

intTempDate = 20081014
intTempDate = 20081013

and smaller?
intDate = 20081014
 
Function GetLog()
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colLoggedEvents = objWMIService.ExecQuery ("Select * from Win32_NTLogEvent Where Logfile = 'System'")
for each LogEvent in colLoggedEvents
     	intTempDate = Left(LogEvent.TimeWritten,8)
	If intTempDate > intDate Then
	     'WSHShell.Popup, 100, "Script Processing Message", 64
	     If LogEvent.EventCode = "1111" then
             'WSHShell.Popup intTempDate - intDate & " is less than " & intNumDays & vbCrLf & intTempDate & " is greater than " & (intDate - 1) , 10, "Script Processing Message", 64
	             ' Do Stuff
	     End if
     End If
Next
set smessage = Nothing
End Function

Open in new window

0
Comment
Question by:cescentman
5 Comments
 
LVL 92

Assisted Solution

by:Patrick Matthews
Patrick Matthews earned 50 total points
ID: 22723599
Hello cescentman,

You may have a data type problem, as intDate is a Long while intTempDate is actually a String.

Use an explicit type conversion to force them both into the same type:

      If CLng(intTempDate) > CLng(intDate) Then

or the like...

Regards,

Patrick
0
 
LVL 18

Expert Comment

by:exx1976
ID: 22724247
I agree that it's most likely a data type problem, but I wouldn't use Longs for the comparison..  You are working with dates, so why not compare them as dates?

Use cDate to caste them both to dates, then do the comparison..  You'll need to get the format right, but it shouldn't be too painful.  Let me know if you need help with that.
0
 
LVL 65

Accepted Solution

by:
RobSampson earned 200 total points
ID: 22725774
Hi, you can actually restrict the date range during your Win32_NTLogEvent query, by using the TimeWritten property.

Regards,

Rob.
Set objSWbemDateTime = CreateObject("WbemScripting.SWbemDateTime")
objSWbemDateTime.SetVarDate #10/14/2008#, True
 
Function GetLog()
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colLoggedEvents = objWMIService.ExecQuery ("Select * from Win32_NTLogEvent Where Logfile = 'System'" & _
	"AND TimeWritten >= '" & objSWbemDateTime.Value & "'")
For Each LogEvent in colLoggedEvents
	     'WSHShell.Popup, 100, "Script Processing Message", 64
	     If LogEvent.EventCode = "1111" then
             'WSHShell.Popup intTempDate - intDate & " is less than " & intNumDays & vbCrLf & intTempDate & " is greater than " & (intDate - 1) , 10, "Script Processing Message", 64
	             ' Do Stuff
	     End if
Next
set smessage = Nothing
End Function

Open in new window

0
 
LVL 1

Author Comment

by:cescentman
ID: 22728233
Many thanks for all 3 answers.

Patrick that works a treat.

exx1976 I didn't check this as I'm not sure how this would be an advantage ofer the previuos suggestion as it would achieve the same thins but add extra code.

Rob Works a treat and cuts the processing time to a third of the previous code - brilliant
0
 
LVL 65

Expert Comment

by:RobSampson
ID: 22728249
No problem at all.  Thanks for the grade.  Anything you can do to immediately restrict a WMI query will reduce the processing time, as opposed to returning all records, then sifting through them...

Regards,

Rob.
0

Featured Post

Live: Real-Time Solutions, Start Here

Receive instant 1:1 support from technology experts, using our real-time conversation and whiteboard interface. Your first 5 minutes are always free.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

If you haven’t already, I encourage you to read the first article (http://www.experts-exchange.com/articles/18680/An-Introduction-to-R-Programming-and-R-Studio.html) in my series to gain a basic foundation of R and R Studio.  You will also find the …
Deploying a Microsoft Access application in a Citrix environment is not difficult but takes a few steps. However, Citrix system people are often of little help, as they typically know next to nothing about Access. The script provided here will take …
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.

813 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

17 Experts available now in Live!

Get 1:1 Help Now