Want to win a PS4? Go Premium and enter to win our High-Tech Treats giveaway. Enter to Win

x
?
Solved

If a cursor doesn't have data don't send a email

Posted on 2008-10-15
2
Medium Priority
?
245 Views
Last Modified: 2012-05-05
I have a cursor that I have written with some help on here.  I would like to know what I need to change.  I have some agents that It sends data to even if there is no circuits for that agent to look at.

Here is a breif description of what this cursor does:

Send a email to agents if they are associated with circuits attaching the circuits they are responsible for.  I am sure we need to add a isnull but I don't know where.
USE [Billing Automation Processes]
GO
/****** Object:  StoredProcedure [dbo].[Z4032P]    Script Date: 10/15/2008 14:23:47 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER procedure [dbo].[Z4032P]
as
begin
 
DECLARE @Email nvarchar(255)
DECLARE @Title nvarchar(100)
DECLARE @body  nvarchar(max) 
DECLARE @query nvarchar(max) 
DECLARE @attached nvarchar(max) 
DECLARE @agent nvarchar(60)
 
DECLARE c1 CURSOR READ_ONLY FOR SELECT agent, email from [Billing Automation Processes].dbo.fakeagent
 
OPEN c1
 
FETCH NEXT FROM c1 INTO @agent,@email
 
WHILE @@FETCH_STATUS = 0
 
BEGIN
 
    set @attached = @agent+'_Customer_List.txt'
    set @query = 'select convert(nchar(25),CustomerName) as CustomerName, convert(nchar(10),ANI) as ANI, convert(nvarchar(25),CreateDate) as CreateDate, convert(nchar(10),[INTER CIC]) as [INTER CIC], convert(nchar(10),[INTRA CIC]) as [INTRA CIC] from [Billing Automation Processes].dbo.[Z4032 - NO LD Notification] where agent = '''+@agent+''''
    set @body = 'Greetings '+@agent+',
 
The following circuits have been added to U4.  This email is to let you know that in the last 14 days since the circuit has been added we have not gotten traffic on the circuits.  We would like for you to look over these circuits as we are concerned that you are not getting commissions and or the customer could be getting third party billing from another carrier.  The following circuits have been setup with the following CIC codes listed below.  If you believe a CIRCUIT listed below is a non usage circuit such as a Security or Credit card line, please contact agent support and let them know the circuit and what type of line.
 
In addition provisioning has been notified about these circuits via an inquiry.
 
This report will continue to generate until the circuits receive traffic or you notify support (agentsupport@email.u4corp.com) of a change in circuit type to Switched  Low Usage.
 
 
'
 
    EXEC msdb.dbo.sp_send_dbmail
         @recipients=@Email,
		 @blind_copy_recipients= 'monitor@u4notifications.com',
         @body=@body,
         @subject='Customer List Attached',
         @profile_name='U4 Notifications.com',
         @query = @query,
         @execute_query_database = 'Billing Automation Processes',
         @attach_query_result_as_file = 0,                   
         @query_attachment_filename = @attached
     
    FETCH NEXT FROM c1 INTO @agent,@email
 
END
 
CLOSE c1
DEALLOCATE c1
 
END

Open in new window

0
Comment
Question by:binaryman101
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
2 Comments
 
LVL 39

Accepted Solution

by:
BrandonGalderisi earned 1000 total points
ID: 22724694
here you go:

I just copied the @query, and run it with an if exists() before doing the sp_send_dbmail
USE [Billing Automation Processes]
GO
/****** Object:  StoredProcedure [dbo].[Z4032P]    Script Date: 10/15/2008 14:23:47 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER procedure [dbo].[Z4032P]
as
begin
 
DECLARE @Email nvarchar(255)
DECLARE @Title nvarchar(100)
DECLARE @body  nvarchar(max) 
DECLARE @query nvarchar(max) 
DECLARE @attached nvarchar(max) 
DECLARE @agent nvarchar(60)
 
DECLARE c1 CURSOR READ_ONLY FOR SELECT agent, email from [Billing Automation Processes].dbo.fakeagent
 
OPEN c1
 
FETCH NEXT FROM c1 INTO @agent,@email
 
WHILE @@FETCH_STATUS = 0
 
BEGIN
 
    set @attached = @agent+'_Customer_List.txt'
    set @query = 'select convert(nchar(25),CustomerName) as CustomerName, convert(nchar(10),ANI) as ANI, convert(nvarchar(25),CreateDate) as CreateDate, convert(nchar(10),[INTER CIC]) as [INTER CIC], convert(nchar(10),[INTRA CIC]) as [INTRA CIC] from [Billing Automation Processes].dbo.[Z4032 - NO LD Notification] where agent = '''+@agent+''''
    set @body = 'Greetings '+@agent+',
 
The following circuits have been added to U4.  This email is to let you know that in the last 14 days since the circuit has been added we have not gotten traffic on the circuits.  We would like for you to look over these circuits as we are concerned that you are not getting commissions and or the customer could be getting third party billing from another carrier.  The following circuits have been setup with the following CIC codes listed below.  If you believe a CIRCUIT listed below is a non usage circuit such as a Security or Credit card line, please contact agent support and let them know the circuit and what type of line.
 
In addition provisioning has been notified about these circuits via an inquiry.
 
This report will continue to generate until the circuits receive traffic or you notify support (agentsupport@email.u4corp.com) of a change in circuit type to Switched  Low Usage.
 
 
'
 
--all i did was copy the query from above.   
if exists (select convert(nchar(25),CustomerName) as CustomerName, convert(nchar(10),ANI) as ANI, convert(nvarchar(25),CreateDate) as CreateDate, convert(nchar(10),[INTER CIC]) as [INTER CIC], convert(nchar(10),[INTRA CIC]) as [INTRA CIC] from [Billing Automation Processes].dbo.[Z4032 - NO LD Notification] where agent = @agent)
    EXEC msdb.dbo.sp_send_dbmail
         @recipients=@Email,
                 @blind_copy_recipients= 'monitor@u4notifications.com',
         @body=@body,
         @subject='Customer List Attached',
         @profile_name='U4 Notifications.com',
         @query = @query,
         @execute_query_database = 'Billing Automation Processes',
         @attach_query_result_as_file = 0,                   
         @query_attachment_filename = @attached
     
    FETCH NEXT FROM c1 INTO @agent,@email
 
END
 
CLOSE c1
DEALLOCATE c1
 
END

Open in new window

0
 

Author Closing Comment

by:binaryman101
ID: 31506461
It worked!
0

Featured Post

[Webinar] Lessons on Recovering from Petya

Skyport is working hard to help customers recover from recent attacks, like the Petya worm. This work has brought to light some important lessons. New malware attacks like this can take down your entire environment. Learn from others mistakes on how to prevent Petya like worms.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

INTRODUCTION: While tying your database objects into builds and your enterprise source control system takes a third-party product (like Visual Studio Database Edition or Red-Gate's SQL Source Control), you can achieve some protection using a sing…
In this article I will describe the Copy Database Wizard method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
In this video you will find out how to export Office 365 mailboxes using the built in eDiscovery tool. Bear in mind that although this method might be useful in some cases, using PST files as Office 365 backup is troublesome in a long run (more on t…
In this video, Percona Solution Engineer Dimitri Vanoverbeke discusses why you want to use at least three nodes in a database cluster. To discuss how Percona Consulting can help with your design and architecture needs for your database and infras…

610 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question