Solved

How to reuse a recordset in vba

Posted on 2008-10-16
5
1,547 Views
Last Modified: 2013-11-27
Hi,

I'm using a sql statement to extract data on to a recordset in VBA.
However, I'm looping this process. I need to run the same process six times.
It looks like the sql statement executes and extracts the data correctly the first time, but when I loop through the second time, it's not allowing me to do so. It looks like data is not being put in to the recordset the second time around.
Could someone help me to figure out how I can do this?
I've attached the code below.

Please HELP ASAP!
For Each numratio In Range("renewalratiocount")

   

      'if x = 6 then arm product

      x = x + 1

      If x = 6 Then

      producttype = "arm"

      term = 5

      Else

      producttype = "fixed"

      term = x

      End If

         

   If numratio.Value <> 0 Then

     

      ' Create the RenewRsMin table on the server

      Set MyCommand = New ADODB.Command

      Set MyCommand.ActiveConnection = MyDatabase

      MyCommand.CommandText = "spRenewRsMin" ' <- name of procedure

      MyCommand.CommandType = adCmdStoredProc

      

      ' pass the values to the stored procedure

      With MyCommand

         .Parameters.Append .CreateParameter("vol", adInteger, adParamInput, , vol)

         .Parameters.Append .CreateParameter("ppp", adInteger, adParamInput, , ppp)

         .Parameters.Append .CreateParameter("liquidation", adInteger, adParamInput, , liquidation)

         .Parameters.Append .CreateParameter("ratio", adInteger, adParamInput, , numratio.Value)

         .Parameters.Append .CreateParameter("producttype", adVarChar, adParamInput, 10, producttype)

         .Parameters.Append .CreateParameter("term", adInteger, adParamInput, , term)

      End With

      

   MyCommand.Execute , , adAsyncExecute

   

   

   ' Close and re-open the connection to refresh.

    MyDatabase.Close

    MyDatabase.Open

  
 

  ' print the min file on to the RemRs.min file

   sqlmin = "select code,term,princ,strike,amort,maturity,firexer,cpr,smm,pipcode,pipiss,mbscpn,servicing,volat,minsprd,perration,trancost,solvepre,issdt,mbsmat,cpr2,smm2,fundingdatemin from renewrsmin"

   Set rstempdata = MyDatabase.Execute(sqlmin)
 
 

   blnColumnHeaders = False

   

   sterm = Right(Str(term), 1)

   If producttype = "arm" Then

   minfile = Worksheets("sheet1").Range("renewminfilename").Value + "a" + sterm

   Else: minfile = Worksheets("sheet1").Range("renewminfilename").Value + "f" + sterm

   End If

   
 

   Open Worksheets("sheet1").Range("crvdirectory").Value + "\" + minfile + ".min" For Output As #1

   

   ' Set the Delimiter for the output file

   strDelimeter = "  "

   strtext = " "
 

   

   Do While Not rstempdata.EOF

      For Each fld In rstempdata.Fields

         strtext = strtext & fld.Value & strDelimeter

      Next

      

      'get rid of the extra delimeter

      strtext = Left(strtext, Len(strtext) - Len(strDelimeter))
 

      strtext = strtext & vbNewLine & " "
 

      rstempdata.MoveNext

   Loop
 

   'removes the extra line at the bottom of the file

   strtext = Left(strtext, Len(strtext) - Len(vbNewLine))

   Print #1, strtext

   Close #1

   

   rstempdata.Close

   Set rstempdata = Nothing

   

   'attach the mortgagenumber

   sqlmin = "select id from renewrsmin"

   Set tempdata = MyDatabase.Execute(sqlmin)

   

   

   If producttype = "arm" Then

   minfile = "renewOutputa5"

   Else: minfile = "renewoutputf" + Right(sterm, 1)

   End If

   

   y = 1

   tempdata.MoveFirst

   Do While Not tempdata.EOF

   

      For Each fld In tempdata.Fields

         y = y + 1

         Worksheets(minfile).Select

         If y = 2 Then ActiveSheet.Range("A2:AX65536").Clear

         ActiveSheet.Range("A" & y).Select

         ActiveCell.Value = fld.Value

      Next

    tempdata.MoveNext

   Loop

   

    tempdata.Close

    Set tempdata = Nothing

    

   End If

    

   

    

    Worksheets("sheet1").Select

    

    

    '.Delete AffectRecords

    

    MyDatabase.Close

    MyDatabase.Open

   

 Next

 

MyDatabase.Close

Open in new window

0
Comment
Question by:vba_confused
  • 3
  • 2
5 Comments
 
LVL 84
ID: 22739181
Your code is a bit of a mess .... where exactly are you filling the recordset?
0
 

Author Comment

by:vba_confused
ID: 22750030
Starting in line 39 to 41. where I execute the sql statement and set the recordset called rstempdata.
Your assistance is greatly appreciated.
0
 
LVL 84

Accepted Solution

by:
Scott McDaniel (Microsoft Access MVP - EE MVE ) earned 500 total points
ID: 22751529
Try this:

rsTempData.moveLast
rsTempData.MoveFirst

You sometimes must move through the entire DAO recordset in order to "fill" it properly.
0
 

Author Comment

by:vba_confused
ID: 22762431
It was just a problem within the stored procedure.  a numeric variable was being assigned as a varchar.

Otherwise, looks like the code works
0
 
LVL 84
ID: 22770978
So why the C grade? If my answer wasn't the answer just don't accept it and instead delete the question. A "C" grade is a slap in the face.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Microsoft Office Picture Manager was included in Office 2003, 2007, and 2010, but not in Office 2013. Users had hopes that it would be in Office 2016/Office 365, but it is not. Fortunately, the same zero-cost technique that works to install it with …
Recently Microsoft released a brand new function called CONCAT. It's supposed to replace its predecessor CONCATENATE. But how does it work? And what's new? In this article, we take a closer look at all of this - we even included an exercise file for…
In Microsoft Access, learn different ways of passing a string value within a string argument. Also learn what a “Type Mis-match” error is about.
Learn how to make your own table of contents in Microsoft Word using paragraph styles and the automatic table of contents tool. We'll be using the paragraph styles in Word’s Home toolbar to help you create a table of contents. Type out your initial …

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now