Solved

How to write a delete stored procedure

Posted on 2008-10-17
9
359 Views
Last Modified: 2012-05-05
Hi all I have a question. I need to know how to write a delete stored procedure please.
my fields are  @Name nvarchar (50), @Phone nvarchar(50), @Birthday datetime. and they exist in the table called tbl_Bday. any help would be great.
0
Comment
Question by:HawaiiDragon
  • 4
  • 3
  • 2
9 Comments
 
LVL 60

Accepted Solution

by:
chapmandew earned 500 total points
ID: 22740490
Do you  mean a stored procedure to delete records?

create procedure mydeleteproc
(@name nvarchar(50), @phone nvarchar(50), @birthday datetime)
as
delete from tbl_bday
where name = @name and phone = @phone and birthday = @birthday

go
0
 
LVL 16

Expert Comment

by:Steve Krile
ID: 22741057
chapmandew is correct as usual.

I would add however, that if you are expecting only one row to be deleted, you should consider using a datakey value rather than matching parameters.  You could argue that a Name, plus a Phone number, plus a birthday are unique, but of course we all know to expect the unexpected in DB design.

So, a "safer" delete statement would be something like
DELETE FROM tbl_bday
WHERE tbl_BdayID = @BDayID
0
 

Author Comment

by:HawaiiDragon
ID: 22742059
Yes it needs to be a stored procedure. Im going to try chapmandews solution reall quick and see what I come up with.

any other ideas would be great too.
0
 
LVL 16

Expert Comment

by:Steve Krile
ID: 22742120
Well, this is the DELETE portion of a stored procedure



create procedure mydeleteproc
(@BDayID)
as
DELETE FROM tbl_bday
WHERE tbl_BdayID = @BDayID

go
0
Zoho SalesIQ

Hassle-free live chat software re-imagined for business growth. 2 users, always free.

 

Author Comment

by:HawaiiDragon
ID: 22742183
okay the procedure was great now im having problems executing it. I have a table and I need the row selected deleted when the user clicks the delete button. It is a datagridview. I think I see my problem but i dont know how to fix it I will put the code below.
    private void btnDelete_Click(object sender, EventArgs e)

        {

            //Inside a try

            try

            {
 

                SqlParameter[] test = new SqlParameter[3];
 

                 // I used the inserts from textboxes and now its in             //data grid view row Any Ideas???

  

              test[0] = new SqlParameter("@Name", tbName.Text);

                test[1] = new SqlParameter("@Phone", tbPhone.Text);

                test[2] = new SqlParameter("@Birthday", dateTimePicker1.Value);
 

                SqlConnection scs = new SqlConnection();
 

                string jaysisawesome = ConfigurationManager.ConnectionStrings["Phone_number_birthday.Properties.Settings.BirthdaysConnectionString"].ToString();

                scs.ConnectionString = jaysisawesome;
 

                SqlCommand cmd = new SqlCommand();

                //cmd.Connection = scs.ConnectionString;

                cmd.CommandType = CommandType.StoredProcedure;

                cmd.CommandText = "NewDeleteCommand";

                cmd.Parameters.AddRange(test);

                cmd.Connection = scs;

                cmd.Connection.Open();

                int one = cmd.ExecuteNonQuery();

                cmd.Connection.Close();
 

                if (one > -1)

                {

                    MessageBox.Show("Database Updated");

                    this.Close();

                    PhoneListForm.ActiveForm.Refresh();

                }

                else

                {

                }

            }

            //Close connection in finally

            //Catch problems

            //sql command object

            //command type

            //DataAccess

            //Using AppConfig ConnectionString (pull from)

            //Params

            //ExecuteNonQuery

            catch (Exception ex)

            {

                ex.ToString();

            }

            this.Close();

            PhoneListForm.ActiveForm.Refresh();

        }

Open in new window

0
 
LVL 16

Expert Comment

by:Steve Krile
ID: 22742489
Is there a Key in this database?  If so, you should set up the DataKeyValue for your grid.  Then, you can use the SelectedIndexValue property of the grid to pass the ID of the row you want to delete.

Then, instead of putting all this code on the button click event, you would wire it up to the SelectedIndexValueChanged event of the datagrid.
0
 
LVL 60

Expert Comment

by:chapmandew
ID: 22742842
To be fair, you should probably submit a new question for your new question.
0
 
LVL 16

Expert Comment

by:Steve Krile
ID: 22743012
True.  In fact, this type of data management is not something I suggest.  The way I prefer is using a class with Get, Set, Update, Delete, and Insert methods.  Then I like using the combination of ObjectDataSources and DataGrids for this type of work.

But, indeed, that is quite a different topic than how to write a Delete proc!  :)
0
 

Author Comment

by:HawaiiDragon
ID: 22743610
true so I have closed this question and will open antoher in just a moment. Please check it out ... im lost... again :)
0

Featured Post

Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
Analysis of table use 7 27
SQL index creation taking an abnormally long time 2 19
SQL Server 2012 Row Selection 2 29
SQL JOIN 6 31
Everyone has problem when going to load data into Data warehouse (EDW). They all need to confirm that data quality is good but they don't no how to proceed. Microsoft has provided new task within SSIS 2008 called "Data Profiler Task". It solve th…
In this article I will describe the Backup & Restore method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Viewers will learn how to use the INSERT statement to insert data into their tables. It will also introduce the NULL statement, to show them what happens when no value is giving for any given column.

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now