• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 766
  • Last Modified:

Unhandled exception at 0x012510ab in Sim HW5.exe: 0xC0000005: Access violation writing location 0x00000000.

Code runs fine for awhile and then breaks in first "for" loop at random points between Counter2 = 150 and 450 and throws the error:

Unhandled exception at 0x009810ab in Sim HW5.exe: 0xC0000005: Access violation writing location 0x00000000.

Any ideas why?
// Sim HW5.cpp : Defines the entry point for the console application.
//
 
#include "stdafx.h"
#include <iostream>
#include <vector>
#include <cmath>
 
using namespace std;
 
int _tmain(int argc, _TCHAR* argv[])
{
	int Counter = 0;
	int Counter2;
	int Counter3;
 
	int n = 100000;
	
	int fj[20] = {0};
	
	double Divisor;
	double Z0 = 1;
	double Zi;
	double ZiMinusOne;
	double Ui;
	double TwoPowerThirtyOne;
	TwoPowerThirtyOne = pow((double)2,31);
	double v[100000];
 
	while (Counter < n+1){
		if (Counter == 0)
			ZiMinusOne = Z0;
		else
			ZiMinusOne = Zi;
 
		Divisor = (floor( 16807*ZiMinusOne/(TwoPowerThirtyOne-1)));
		Zi = 16807*ZiMinusOne - (Divisor) * (TwoPowerThirtyOne-1);
 
		Ui = Zi/(TwoPowerThirtyOne-1);
 
		v[Counter] = Zi;
 
		Counter++;
		}
 
 
breaks-->	for (Counter2 = 0; Counter2 < n-1; Counter2++){
		for (Counter3 = 0; Counter3 < 20; Counter3++){
			if (v[Counter2] >= Counter3*TwoPowerThirtyOne/20 && v[Counter2] <= (Counter3+1)*TwoPowerThirtyOne/20)
				fj[Counter2]++;
		}
	}
 
	for (Counter2 = 0; Counter2 < n-1; Counter2++)
		cout << "fj" << Counter2 << ": " << fj[Counter2] << endl;
 
	system ("PAUSE");
}

Open in new window

0
ltdanp22
Asked:
ltdanp22
1 Solution
 
jkrCommented:
Well, the above is running fine here (compiles with VC8). You might want to initialize each and every variable thoroughly though, e.g.
int _tmain(int argc, _TCHAR* argv[])
{
        int Counter = 0;
        int Counter2 = 0; // <--
        int Counter3 = 0; // <--
 
        int n = 100000;
        
        int fj[20] = {0};
        memset(fj,0,20 * sizeof(int)); // <--
        
        double Divisor = 1.0; // <--
        double Z0 = 1;
        double Zi = 0.0; // <--
        double ZiMinusOne = 0.0; // <--
        double Ui = 0.0; // <--
        double TwoPowerThirtyOne = 0.0; // <--
        TwoPowerThirtyOne = pow((double)2,31);
        double v[100000];
        memset(v,0,100000 * sizeof(double)); // <--
 
        while (Counter < n+1){
                if (Counter == 0)
                        ZiMinusOne = Z0;
                else
                        ZiMinusOne = Zi;
 
                Divisor = (floor( 16807*ZiMinusOne/(TwoPowerThirtyOne-1)));
                Zi = 16807*ZiMinusOne - (Divisor) * (TwoPowerThirtyOne-1);
 
                Ui = Zi/(TwoPowerThirtyOne-1);
 
                v[Counter] = Zi;
 
                Counter++;
                }
 
 
                for (Counter2 = 0; Counter2 < n-1; Counter2++){
                for (Counter3 = 0; Counter3 < 20; Counter3++){
                        if (v[Counter2] >= Counter3*TwoPowerThirtyOne/20 && v[Counter2] <= (Counter3+1)*TwoPowerThirtyOne/20)
                                fj[Counter2]++;
                }
        }
 
        for (Counter2 = 0; Counter2 < n-1; Counter2++)
                cout << "fj" << Counter2 << ": " << fj[Counter2] << endl;
 
        system ("PAUSE");
}

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: SQL Server Core 2016

This course will introduce you to SQL Server Core 2016, as well as teach you about SSMS, data tools, installation, server configuration, using Management Studio, and writing and executing queries.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now