creating a new obj in called function and passing back to caller

I have a function in a class which you pass any number to it and it finds the factors of that number. It puts them as pairs in 1 or more orderedpair objects which are added to an arraylist. There is only 1 arraylist which holds this list of orderedpair objects in the class. I call a function in the class which returns the arraylist but when I do it 2x with 2 instances of the arraylist in the calling program, the 2nd one gets overwritten with the first. (see code listing)
I know there is a better way to do this - do I need to return by reference?
' calling subroutine
 Private Sub test_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles test.Click
        Dim myArray As ArrayList
        Dim a, b, c As Int32
        Dim afactarray, cfactarray As ArrayList
        a = avar
        b = bvar
        c = cvar
 
        afactarray = New ArrayList()
        cfactarray = New ArrayList()
 
' numfac is an instance declared in the constructor
 
        numfac.FindFactors(a)
        afactarray = numfac.GetFactorList()
        numfac.FindFactors(c)
        cfactarray = numfac.GetFactorList()
            ...
    End Sub
' called subroutine in class
   Public Function GetFactorList() As ArrayList
        Dim myArray As ArrayList = New ArrayList()
        myArray = finalfactorlist
        Return myArray
    End Function

Open in new window

zliminatorAsked:
Who is Participating?
 
TechTiger007Connect With a Mentor Commented:
You can try
Return myArray.Clone()
0
 
zliminatorAuthor Commented:
That was an easy 250 points
0
 
TechTiger007Commented:
:-)
0
All Courses

From novice to tech pro — start learning today.