Solved

Beginner BackgroundWorker Help Needed (C#)

Posted on 2008-10-22
8
2,840 Views
Last Modified: 2013-12-17
I need help understand the background worker, and what I am doing wrong in this example. I have a form with 2 radio buttons, and I want a background worker to perform a continious ping on a LAN IP address and if it loses connection I want the radio button to go to "disconnected" and if its successful I want the radio button to move to "successful". I want to do this in the background so you are free to use the rest of the form while remaining responsive. Here is my first attempt, but it fails to update either radiobutton and the form is not responsive at all:

namespace Background_Worker
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        static BackgroundWorker worker = new BackgroundWorker();
        static string replyStatus;

        private void radioButton1_CheckedChanged(object sender, EventArgs e)
        {
           
            if (radioButton1.Checked == true)
            {
                radioButton2.Checked = false;
            }
        }

        private void pingIP(object sender, DoWorkEventArgs e)
        {
            Ping ping = new Ping();
            PingReply reply = ping.Send("192.168.1.200", 1000);
            if (reply.Status == IPStatus.Success)
            {
                replyStatus = "pass";
            }
            else
            {
                replyStatus = "fail";
            }
        }

        private void radioButton2_CheckedChanged(object sender, EventArgs e)
        {
            if (radioButton2.Checked == true)
            {
                radioButton1.Checked = false;
            }
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            worker.DoWork += new DoWorkEventHandler(pingIP);
            worker.RunWorkerCompleted += new RunWorkerCompletedEventHandler(complete);
        }

        private void complete(object sender, RunWorkerCompletedEventArgs e)
        {
            if (replyStatus == "pass")
            {
                radioButton1.Checked = true;
            }
            else
            {
                radioButton2.Checked = false;
            }
        }

        private void button1_Click(object sender, EventArgs e)
        {
            while (true)
            {
                try
                {
                    worker.RunWorkerAsync();
                }
                catch
                {
                }
            }

        }
    }
}
0
Comment
Question by:Pretzel_Jesus
  • 3
  • 3
  • 2
8 Comments
 
LVL 6

Expert Comment

by:RishadanPort
Comment Utility
Look like in your button1_Click(object sender, EventArgs e) function, you have an infinite loop that continues to run operations asynchronously.

when you have this statement:

this.backgroundWorker1.RunWorkerAsync();  <--

When the program has finished executing that statement, does not mean that the backgroundworker has finished, it just means made the call to start the operation in the background worker.


An example MSDN documentation shows that you should do it like this listed below.
private void dowloadButton_Click(object sender, EventArgs e)

{

    // Start the download operation in the background.

    this.backgroundWorker1.RunWorkerAsync();
 

    // Disable the button for the duration of the download.

    this.dowloadButton.Enabled = false;
 

    // Wait for the BackgroundWorker to finish the download.

    while (this.backgroundWorker1.IsBusy)

    {

        // Keep UI messages moving, so the form remains 

        // responsive during the asynchronous operation.

        Application.DoEvents();

    }
 

    // The download is done, so enable the button.

    this.dowloadButton.Enabled = true;

}

Open in new window

0
 
LVL 6

Expert Comment

by:RishadanPort
Comment Utility
This while loop waits for the background worker to finish. Since you need to continuously send "pings" you will also need an outer while loop, like the one you have.

0
 
LVL 85

Accepted Solution

by:
Mike Tomlinson earned 500 total points
Comment Utility
Try this way out:
    public partial class Form1 : Form

    {

        public Form1()

        {

            InitializeComponent();

        }
 

        private BackgroundWorker worker = new BackgroundWorker();
 

        private void Form1_Load(object sender, EventArgs e)

        {

            worker.DoWork += new DoWorkEventHandler(pingIP);

            worker.ProgressChanged += new ProgressChangedEventHandler(worker_ProgressChanged);

        }
 

        private void pingIP(object sender, DoWorkEventArgs e)

        {

            PingReply reply;

            Ping ping = new Ping();

            while (true)

            {

                reply = ping.Send("192.168.1.200", 1000);

                if (reply.Status == IPStatus.Success)

                {

                    worker.ReportProgress(0); // pass

                }

                else

                {

                    worker.ReportProgress(1); // fail

                }

                System.Threading.Thread.Sleep(250); // "throttle" thread w/ delay

            };

        }
 

        void worker_ProgressChanged(object sender, ProgressChangedEventArgs e)

        {

            radioButton1.Checked = (e.ProgressPercentage == 0);

            radioButton2.Checked = (e.ProgressPercentage == 1);

        }
 

        private void button1_Click(object sender, EventArgs e)

        {

            if (!worker.IsBusy)

            {

                worker.RunWorkerAsync();

            }

        }
 

    }

Open in new window

0
 
LVL 85

Expert Comment

by:Mike Tomlinson
Comment Utility
* oops...there should not be a semi-colon ";" at the closing bracket of my while() block!

0
Highfive + Dolby Voice = No More Audio Complaints!

Poor audio quality is one of the top reasons people don’t use video conferencing. Get the crispest, clearest audio powered by Dolby Voice in every meeting. Highfive and Dolby Voice deliver the best video conferencing and audio experience for every meeting and every room.

 

Author Comment

by:Pretzel_Jesus
Comment Utility
Idle_Mind: I tried your code and it throws the following exception:

This BackgroundWorker states that it doesn't report progress. Modify WorkerReportsProgress to state that it does report progress.
0
 
LVL 6

Expert Comment

by:RishadanPort
Comment Utility
change

worker.WorkerReportsProgress = true;
0
 
LVL 85

Expert Comment

by:Mike Tomlinson
Comment Utility
Right...sorry.

Add this line:

    worker.WorkerReportsProgress = true;
        private void Form1_Load(object sender, EventArgs e)

        {

            worker.WorkerReportsProgress = true;

            worker.DoWork += new DoWorkEventHandler(pingIP);

            worker.ProgressChanged += new ProgressChangedEventHandler(worker_ProgressChanged);

        }

Open in new window

0
 

Author Closing Comment

by:Pretzel_Jesus
Comment Utility
Thanks a lot this is exactly what I needed! Its hard to understand this stuff from reading books... solutions like this make it so much easier to understand :). Thanks again.
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Suggested Solutions

How to remove superseded packages in windows w60 or w61 installation media (.wim) or online system to prevent unnecessary space. w60 means Windows Vista or Windows Server 2008. w61 means Windows 7 or Windows Server 2008 R2. There are various …
Having just graduated from college and entered the workforce, I don’t find myself always using the tools and programs I grew accustomed to over the past four years. However, there is one program I continually find myself reverting back to…R.   So …
The goal of this video is to provide viewers with basic examples to understand and use switch statements in the C programming language.
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now