Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
?
Solved

Methods won't compile

Posted on 2008-10-22
7
Medium Priority
?
186 Views
Last Modified: 2013-11-23
This code below is supposed to create an address book. It uses two classes but two methods won't work. What am I possibly doing wrong? I've been working on this for hours and still no such luck!

Is it the scanner that I'm doing wrong, if so, what has to happen? Totally confused!


   Thanks for your help!
/** HERE IS THE FIRST CLASS **/
 
public class Person
{
    private String firstName;
    private int yearBorn;
    private String phone;
    
    public Person()
    {
        firstName = "";
        yearBorn = 0;
        phone = "";
    }
 
    public Person(String firstNameX, int yearBornX, String phoneX)
    {
        firstName = firstNameX;
        yearBorn = yearBornX;
        phone = phoneX;
    }
    
    public void setFirstName(String firstNameX)
    {
        firstName = firstNameX;
    }
   
    public String getFirstName()
    {
        return (firstName);
    }
 
    public void setYearBorn(int yearBornX)
    {
        yearBorn = yearBornX;
    }
 
    public int getYearBorn()
    {
        return (yearBorn);
    }
 
    public void setPhone(String phoneX)
    {
        phone = phoneX;
    }
 
    public String getPhone()
    {
        return (phone);
    }
 
    public void print()
    {
       System.out.println("name=" + firstName + "\t" + "yearBorn=" + yearBorn + "\t" + "phone=" + phone);
    }
}
 
/**HERE IS THE SECOND CLASS**/
 
import java.io.*;
import java.util.*;
import java.util.regex.*;
public class AddressBook
{
    Person[] people = new Person[10];
 
 
 
 
    public void addPerson(Person newPerson)
    {
        for(int indexPeople = 0; indexPeople<people.length; indexPeople++)
        {
            if(people[indexPeople] == null)
            {
                people[indexPeople] = newPerson;
            }
        }
    }
 
    public void removePerson(String firstName)
    {
        for(int indexPeople = 0; indexPeople<people.length; indexPeople++)
        {
            String[] newPeople = new String[people.length];
            if(newPeople[indexPeople] == firstName)
            {
                people[indexPeople] = null;
            }
        }
    }
 
    public void print()
    {
        for(int indexPeople = 0; indexPeople<people.length; indexPeople++)
        {
            System.out.println(people[indexPeople]);
        }
    }
    
   
    
 
    public static void main(String[] args)
    {
        AddressBook book = new AddressBook();
        
        Scanner scanner = new Scanner(System.in);
        System.out.println("Do you want to do add or delete or print or quit");
        String userInput = scanner.next();
        String op1 = scanner.next();
 
        if(op1 == "quit")
        {
            return;
        }
        else if(op1 == "add")
        {
            System.out.println("please type name, yearBorn, phone");
            String input1 = scanner.next();
            String input2 = scanner.next();
            String input3 = scanner.next();
            book.addPerson(Person.input1);
        }
        else if(op1 == "delete")
        {
            System.out.println("please type name of person to be deleted");
            String deleteUserInput = scanner.next();
            removePerson(deleteUserInput);
        }
        else if(op1 == "print")
        {
            book.print();       
        }
        else if(op1 == "quit")
        {
          System.exit(0);
        }
 
    }
}

Open in new window

0
Comment
Question by:ccsk89
  • 5
  • 2
7 Comments
 
LVL 61

Expert Comment

by:Kevin Cross
ID: 22782634
>>book.addPerson(Person.input1);
>> public void addPerson(Person newPerson)

Since your addPerson takes a Person object, you need to convert your input Strings into a person object.  You will need to do some data validation / conversion as your Person object doesn't take all Strings.

>>public Person(String firstNameX, int yearBornX, String phoneX)

You want something like this:
book.addPerson(new Person("Bob", 2008, "555 555 5555"));

----------

>>removePerson(deleteUserInput);
You just forgot to use the instance, so should be:
book.removePerson(deleteUserInput);
0
 
LVL 61

Expert Comment

by:Kevin Cross
ID: 22782649
Fix those two things and you should be able to compile and test functionality of logic surrounding scanner, etc.
0
 

Author Comment

by:ccsk89
ID: 22782673
First off thank you for your help! I fixed the removePerson method so thanks so much for that.

For the addPerson method you are saying that I need to convert the input1 that the user entered from the scanner into a person object?

   so like:
       Person input1 = new Person(input1)
 
Am I close to what you are saying or am I totally off?

Thanks again!
0
VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

 
LVL 61

Accepted Solution

by:
Kevin Cross earned 2000 total points
ID: 22782692
I put code to what I was saying above.

Your constructor for Person takes 3 parameters.  If I understand correctly, input1 is the first name; input2, year of birth; input3, the phone number.  Since year of birth is an integer and not a string, you will have to convert that to a valid int in code but here is the jist.

book.addPerson(new Person(input1, intInput2, input3));

Where intInput2 is the converted int value of input2.
0
 

Author Comment

by:ccsk89
ID: 22782730
OH MY!! you are a lifesaver!! Thank you so so so so much!!!!!  I was thinking that I could only add the first input1 because that was the methods parameters, but I see what you are saying now.  

Again THANKS!!!:)
0
 
LVL 61

Expert Comment

by:Kevin Cross
ID: 22782807
Glad to help.
0
 
LVL 61

Expert Comment

by:Kevin Cross
ID: 22782817
<side-note>
I just saw you asked this question earlier, but it was missed.  Since no one commented, you should be able to delete it and save the points to use if you find more issues after running this. :)
</side-note>
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

For beginner Java programmers or at least those new to the Eclipse IDE, the following tutorial will show some (four) ways in which you can import your Java projects to your Eclipse workbench. Introduction While learning Java can be done with…
Go is an acronym of golang, is a programming language developed Google in 2007. Go is a new language that is mostly in the C family, with significant input from Pascal/Modula/Oberon family. Hence Go arisen as low-level language with fast compilation…
Viewers learn about the third conditional statement “else if” and use it in an example program. Then additional information about conditional statements is provided, covering the topic thoroughly. Viewers learn about the third conditional statement …
Viewers will learn about basic arrays, how to declare them, and how to use them. Introduction and definition: Declare an array and cover the syntax of declaring them: Initialize every index in the created array: Example/Features of a basic arr…
Suggested Courses
Course of the Month13 days, 15 hours left to enroll

580 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question