?
Solved

does this code for XInput look correct?

Posted on 2008-10-27
5
Medium Priority
?
651 Views
Last Modified: 2012-05-05
I'm trying to get an XBOX 360 controller to work with a small game engine which has certain requirements for what the function can return and the parameters it can take. Therefore, the below code has to return *char.

No matter what I seem to do, I get a report in from the game engine which says that the controller is disconnected. Worse, I always get "160" back from this:

DWORD Result = XInputGetState(controllerNum, &controllerState);

Does anything look obviously wrong in the code below?

The correct controller drivers are installed, and the controllers work fine with other programs.

extern "C" R_CONTROLLER_API char *GetButtonPress(int n,char *v[])
{
   static char buf[500];
   *buf=0;
   ostringstream SS;
   XINPUT_STATE controllerState;
   DWORD dwResult;
   ZeroMemory(&controllerState, sizeof(XINPUT_STATE));
   int controllerNum = *(int *)v;
      
   
   if( (controllerState.Gamepad.sThumbLX < XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE && 
     controllerState.Gamepad.sThumbLX > -XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE) && 
    (controllerState.Gamepad.sThumbLY < XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE && 
     controllerState.Gamepad.sThumbLY > -XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE) )
    {	
        controllerState.Gamepad.sThumbLX = 0;
        controllerState.Gamepad.sThumbLY = 0;
    }
 
    if( (controllerState.Gamepad.sThumbRX < XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE && 
     controllerState.Gamepad.sThumbRX > -XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE) && 
    (controllerState.Gamepad.sThumbRY < XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE && 
    controllerState.Gamepad.sThumbRY > -XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE) ) 
    {
        controllerState.Gamepad.sThumbRX = 0;
        controllerState.Gamepad.sThumbRY = 0;
    }
   dwResult = XInputGetState(controllerNum, &controllerState);
 
/* For debugging, this snippet never finds any of the key presses
   if((XINPUT_GAMEPAD_A & dwResult)==XINPUT_GAMEPAD_A)
	Log2File("A");
   if((XINPUT_GAMEPAD_B & dwResult)==XINPUT_GAMEPAD_B)
	Log2File("B");
   if((XINPUT_GAMEPAD_X & dwResult)==XINPUT_GAMEPAD_X)
	Log2File("X");
   if((XINPUT_GAMEPAD_Y & dwResult)==XINPUT_GAMEPAD_Y)
	Log2File("Y");
*/
 
 
   SS << dwResult;
   strcat(buf,SS.str().c_str());
   Log2File(buf);
   return buf;
  
}
 
 
 
 
extern "C" __declspec(dllexport) char *IsConnected(int n,char *v[])
{
    XINPUT_STATE controllerState;
    int controllerNum = *(int *)v;
	ZeroMemory(&controllerState, sizeof(XINPUT_STATE)); 
 
    // Get the state
    DWORD Result = XInputGetState(controllerNum, &controllerState);
 
    if(Result == ERROR_SUCCESS)
    {
        return "true"; 
    }
    else
    {
        return "false";
    }
}

Open in new window

0
Comment
Question by:WriterOfCode
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
5 Comments
 
LVL 11

Accepted Solution

by:
jgordos earned 750 total points
ID: 22812567
No, it doesn't.

Couple of questions...

This looks intentional, but I'm not sure if it's really what you meant to do, so I'll ask...

The routines you supplied both take two parameters: n and v
n is an integer
v is an array of char pointers...

You're doing this all over the place...

int controllerNum = *(int *)v;

But you never use 'n' that's supplied to the routine.  Is that really what you want?

Also, the routine always (ALWAYS) returns either ERROR_SUCCESS, ERROR_DEVICE_NOT_CONNECTED, or some error value.  The actual STATE of the buttons is not in the return code... it's in the data structure you passed in, so your code for button presses isn't correct.

In other words, you need to test for button A something like this....

if( ( controllerState.wButtons & XINPUT_GAMEPAD_A  ) == true )
{
// do something very profound here.
}

-john


0
 

Author Comment

by:WriterOfCode
ID: 22828326
Well there seems to be more to it, because
 if( ( controllerState.wButtons & XINPUT_GAMEPAD_A  ) == true

or any of its equivalents, doesn't register with the wired controllers. That said, microsoft just released an update for the xbox 360 controllers on windows, so hopefully that'll help.
0
 
LVL 11

Expert Comment

by:jgordos
ID: 22831849
Yeah, I think there is more to it.

I don't think you're calculating the controller number correctly..

-j
0
 

Author Comment

by:WriterOfCode
ID: 22837890
Well, I'll accept your first answer as correct because I wouldn't believe it myself hadn't I tested it.

Apparently, XInputGetState(controllerNum, &controllerState); needs to precede a Sleep() type function because it takes a while to initialize. *sigh*

I also added a while loop to monitor the if statements until something is pressed.
0
 

Author Closing Comment

by:WriterOfCode
ID: 31510209
It was a good answer, it was also helpful in terms of understanding how some bits of the code worked. However, the true solution I stumbled across my self, because it was so inane.
0

Featured Post

NFR key for Veeam Agent for Linux

Veeam is happy to provide a free NFR license for one year.  It allows for the non‑production use and valid for five workstations and two servers. Veeam Agent for Linux is a simple backup tool for your Linux installations, both on‑premises and in the public cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Stuck in voice control mode on your Amazon Firestick?  Here is how to turn it off!!!
This article outlines why you need to choose a backup solution that protects your entire environment – including your VMware ESXi and Microsoft Hyper-V virtualization hosts – not just your virtual machines.
If you’ve ever visited a web page and noticed a cool font that you really liked the look of, but couldn’t figure out which font it was so that you could use it for your own work, then this video is for you! In this Micro Tutorial, you'll learn yo…
Sometimes it takes a new vantage point, apart from our everyday security practices, to truly see our Active Directory (AD) vulnerabilities. We get used to implementing the same techniques and checking the same areas for a breach. This pattern can re…
Suggested Courses

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question