Solved

Find text / column in ALL stored procedures and replace, comments?

Posted on 2008-10-27
5
1,519 Views
Last Modified: 2012-06-21
Hi experts!

I had an issue where I needed to rename variable / text in all stored procedures where found. I looked everywhere (i think) for a solution and could not find one so I came up with attached code snippet.

Perhaps this could help others but for me I have allready noticed that if stored procedure is above 8000 chars (usually it is if structured propertly) it doesn't work. Is there other ways to accomplish what I am trying to do?

Thanks in advance.

PS. Did not use a temporary table (temp_procedure) as I wished to see what came out before EXEC(@sql) while debugging.



CREATE PROCEDURE dbo.sp_findandrename_all_storedproc
 @findtext nvarchar(500), 
 @replacetext nvarchar(500) 
AS
BEGIN
 
IF EXISTS(SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'temp_procedures') DROP TABLE temp_procedures  
CREATE TABLE temp_procedures(id int IDENTITY(1,1) ,sptext varchar(max))
 
  declare @procstr varchar(max)
  declare @astr varchar(max)
  declare @scid bigint
  declare @plid int
  declare @prid int
  
	--/ loop thru procedure 
       DECLARE @id CURSOR
       SET @id = CURSOR FOR 
        SELECT id FROM syscomments
          where text like '%'+@findtext+'%' --/ find procedures with defined text.
        OPEN @id
        FETCH NEXT FROM @id INTO @scid
         WHILE @@FETCH_STATUS = 0
          BEGIN
			SELECT @astr = so.name
			  FROM sysobjects so
			INNER JOIN syscomments sc ON so.id=sc.id
				   AND sc.id = @scid
 
              print('Extracted: '+@astr)
              
              --/ create temp table that stores procedure lines
              CREATE TABLE #proclines(id int IDENTITY(1,1) , procline varchar(max))
              INSERT INTO #proclines exec sp_helptext @astr
    	  
               SET @procstr = ''	
 
			   --/ loop thru lines and create a SQL string	
               DECLARE @id2 CURSOR
               SET @id2 = CURSOR FOR 
                SELECT id FROM #proclines
                OPEN @id2
                FETCH NEXT FROM @id2 INTO @plid
                 WHILE @@FETCH_STATUS = 0
                  BEGIN
 
                   select @procstr = @procstr + procline
                     from #proclines
                    where id = @plid
 
                   FETCH NEXT FROM @id2 INTO @plid
                  END
                CLOSE @id2
                DEALLOCATE @id2
                  	 
              --/ make changes in SQL string (procedure string)
			  SELECT @procstr = [dbo].[findandreplace] (@procstr,'CREATE PROC','ALTER PROC')
              SELECT @procstr = [dbo].[findandreplace] (@procstr,@findtext,@replacetext)
              
              --/ insert procedure string (SQL) into table so we can do EXEC record by record.
		      PRINT(@procstr)
			  INSERT INTO temp_procedures(sptext) values(@procstr)
 
              DROP TABLE #proclines
	
          FETCH NEXT FROM @id INTO @scid
          END
        CLOSE @id
        DEALLOCATE @id 
        
   DECLARE @sql varchar(max)
 
   --/ loop thru procedure table and execute SQL's
   DECLARE @id3 CURSOR
   SET @id3 = CURSOR FOR 
    SELECT id FROM temp_procedures
    OPEN @id3
    FETCH NEXT FROM @id3 INTO @prid
     WHILE @@FETCH_STATUS = 0
      BEGIN
 
       select @sql = sptext
         from temp_procedures
        where id = @prid
 
	   EXEC(@sql)
       PRINT(@sql)
       	
       FETCH NEXT FROM @id3 INTO @prid
      END
    CLOSE @id3
    DEALLOCATE @id3
    
   DROP TABLE temp_procedures         
 
END

Open in new window

0
Comment
Question by:westmediasystems
  • 2
  • 2
5 Comments
 
LVL 32

Expert Comment

by:Daniel Wilson
ID: 22812516
  1. Script out all your stored procedures to a text file.
  2. do a search/replace using your favorite text editor.
  3. run the script to rebuild your procedures.
You can find all of them looking in syscomments as the script above does.  But you need to do a Create Procedure (or Alter Procedure) to change them -- hence the suggestion above.
0
 

Author Comment

by:westmediasystems
ID: 22814555
Actually the above snippet did both find procedures and alter them including execute, however... as mentioned the limit of 8000 chars was the issue. Some of the "alter procedure" sql statements became incomplete.

Anyhow, scripting into file is something I haven't done but I presume its easy to find, and of course, this sounds like a excellent way to accomplish what I am trying to do.

Thanks!
0
 
LVL 32

Accepted Solution

by:
Daniel Wilson earned 500 total points
ID: 22814601
>>Some of the "alter procedure" sql statements became incomplete.

Right ... those over 8000 characters are stored in multiple rows in syscomments (or whatever the 2005 table behind the syscomments view is).

I guess your script was more complete than I realized ... but scripting all the SP's to a file is pretty easy.

In SSMS, drill down under Programmability and click Stored Procedures.  In the right pane (Object Explorer Details) gang-select them, right-click and choose Script Stored Procedure As | Create To | and one of the 3 options.  I usually go to the clipboard & paste it into my text editor.
0
 
LVL 7

Expert Comment

by:Cedric_D
ID: 22815313
Firstly, for SQL2005 threshold is 4000 (not 8000) as it has nvarchar(4000) type.
Secondly, syscomments has PK with two columns: id + colid (procedure can have multiple chunks with the single id).

Create test procedure with more than 4000 chars, and see select * from syscomments.

So you should update your code, changing where you use single id, to use both id and colid.

There can be simplier version:

update syscomments set text = REPLACE(text, 'string1', 'string2')

(AdHoc updates should be allowed.  Make backup first!!!!).
But this version is not COMPLETELY correct because it will not replace strings at the boundaries of 4000-chunks.
If I have a little more time I can write a correct script  :)



0
 

Author Comment

by:westmediasystems
ID: 22815594
Hm, either this went straight over my head or I am simplpy a little bit slow here...
What I did was to retreive each line by using "exec sp_helptext" on procedures that had the text that was supposed to be located. Then I bundle every line together with find replace routine into a single column of varchar(8000). This was my @sql param so I could do an exec(@sql) that altered the procedure.

Are you talking about modifying the syscomment directly? If so, hope you get the time to write an correct script... :) Very intresting stuff imo.
0

Featured Post

Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
SQL Server Designer 19 45
SQL Error - Query 6 26
T-SQL:  Collapsing 9 25
sql server query 6 10
JSON is being used more and more, besides XML, and you surely wanted to parse the data out into SQL instead of doing it in some Javascript. The below function in SQL Server can do the job for you, returning a quick table with the parsed data.
Slowly Changing Dimension Transformation component in data task flow is very useful for us to manage and control how data changes in SSIS.
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties
Viewers will learn how to use the SELECT statement in SQL to return specific rows and columns, with various degrees of sorting and limits in place.

831 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question