Solved

im trying to create a user defined function, but cant execute it as an error message appears

Posted on 2008-10-28
6
276 Views
Last Modified: 2008-11-28
when trying to run an sql 2005 user defined function, it wont execute as the following error message occurs:

Msg 443, Level 16, State 15, Procedure InsertMailingPreferences, Line 60
Invalid use of side-effecting or time-dependent operator in 'INSERT' within a function.

How do i resolve this?

THanks

Julia
USE [MembershipDB]
GO
/****** Object:  UserDefinedFunction [dbo].[getUpgradeProductIdInPackage]    Script Date: 10/27/2008 14:09:44 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
create FUNCTION [dbo].[InsertMailingPreferences] (
			
			@PackageID int,
			@AddressID int,
			@UserName nvarchar(100)
								
			)
returns nvarchar(50)--int	
as
BEGIN
 
 
DECLARE @Counter int
SET @Counter = 0
 
DECLARE @TotalRows int
DECLARE @ServiceID int
DECLARE @MailingMethodID int
DECLARE @MaxServiceID int
DECLARE @NowDate datetime
--------------------------------------------------------------
DECLARE @DefaultMailingsTable	table
(
		ServiceID int,
		ServiceName nvarchar(50),
		DefaultMailingMethodID int,
		MethodDesc nvarchar(50)
		)
 
 
--SET @DefaultMailingsTable = dbo.getDefaultMailingPreferencesForPackage(@PackageID)
--SET @DefaultMailingsTable = (SELECT * FROM dbo.getDefaultMailingPreferencesForPackage(@PackageID))
 
Insert Into @DefaultMailingsTable
SELECT * FROM dbo.getDefaultMailingPreferencesForPackage(@PackageID)
 
SET @TotalRows = (SELECT Count(*) FROM @DefaultMailingsTable)
SET @MaxServiceID = (SELECT Max (ServiceID) FROM dbo.getDefaultMailingPreferencesForPackage(@PackageID))
 
 
WHILE (@Counter < @MaxServiceID+1)
BEGIN
 
--Select ServiceID, DefaultMailingMethodID FROM @DefaultMailingsTable WHERE   exists
--		(Select ServiceID, DefaultMailingMethodID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)
 
	If  (Select ServiceID FROM @DefaultMailingsTable WHERE   serviceID in  (@Counter)) is NOT null
		--(Select ServiceID, DefaultMailingMethodID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)) = @Counter -- is not null
 
	BEGIN
	Set @ServiceID = (Select ServiceID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)
	Set @MailingMethodID = (Select  DefaultMailingMethodID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)
	Set @NowDate = getDate()
--convert(datetime,getDate(),103)
 
 
 
 
	
	INSERT INTO dbo.MailingUserPreferences(UserName, DateSelected, MailingMethodID, AddressID, ServiceID)
	VALUES(@UserName, convert(datetime,24/05/2008,103),  1, @AddressID, @ServiceID);
	SET @Counter = @Counter + 1	
	END
 
	Else 
 
	Begin
	SET @Counter = @Counter + 1	
	end
 
 
 
 
END
 
 
 
 
Return 'Success'
--Return @PackageID
 
 
 
 
END

Open in new window

0
Comment
Question by:Juliafrazer
  • 2
6 Comments
 
LVL 60

Accepted Solution

by:
chapmandew earned 250 total points
ID: 22824681
You can't run DML statements on user tables inside functions like that.
0
 
LVL 39

Assisted Solution

by:BrandonGalderisi
BrandonGalderisi earned 250 total points
ID: 22824747
Chap is right... but what you really want is a stored procedure.
USE [MembershipDB]
GO
/****** Object:  procedure[dbo].[getUpgradeProductIdInPackage]    Script Date: 10/27/2008 14:09:44 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
create procedure [dbo].[InsertMailingPreferences] 
                        
                        @PackageID int,
                        @AddressID int,
                        @UserName nvarchar(100)
                        @output nvarchar(50) output                                        
as
BEGIN
 
 
DECLARE @Counter int
SET @Counter = 0
 
DECLARE @TotalRows int
DECLARE @ServiceID int
DECLARE @MailingMethodID int
DECLARE @MaxServiceID int
DECLARE @NowDate datetime
--------------------------------------------------------------
DECLARE @DefaultMailingsTable   table
(
                ServiceID int,
                ServiceName nvarchar(50),
                DefaultMailingMethodID int,
                MethodDesc nvarchar(50)
                )
 
 
--SET @DefaultMailingsTable = dbo.getDefaultMailingPreferencesForPackage(@PackageID)
--SET @DefaultMailingsTable = (SELECT * FROM dbo.getDefaultMailingPreferencesForPackage(@PackageID))
 
Insert Into @DefaultMailingsTable
SELECT * FROM dbo.getDefaultMailingPreferencesForPackage(@PackageID)
 
SET @TotalRows = (SELECT Count(*) FROM @DefaultMailingsTable)
SET @MaxServiceID = (SELECT Max (ServiceID) FROM dbo.getDefaultMailingPreferencesForPackage(@PackageID))
 
 
WHILE (@Counter < @MaxServiceID+1)
BEGIN
 
--Select ServiceID, DefaultMailingMethodID FROM @DefaultMailingsTable WHERE   exists
--              (Select ServiceID, DefaultMailingMethodID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)
 
        If  (Select ServiceID FROM @DefaultMailingsTable WHERE   serviceID in  (@Counter)) is NOT null
                --(Select ServiceID, DefaultMailingMethodID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)) = @Counter -- is not null
 
        BEGIN
        Set @ServiceID = (Select ServiceID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)
        Set @MailingMethodID = (Select  DefaultMailingMethodID FROM @DefaultMailingsTable WHERE ServiceID = @Counter)
        Set @NowDate = getDate()
--convert(datetime,getDate(),103)
 
 
 
 
        
        INSERT INTO dbo.MailingUserPreferences(UserName, DateSelected, MailingMethodID, AddressID, ServiceID)
        VALUES(@UserName, convert(datetime,24/05/2008,103),  1, @AddressID, @ServiceID);
        SET @Counter = @Counter + 1     
        END
 
        Else 
 
        Begin
        SET @Counter = @Counter + 1     
        end
 
 
 
 
END
 
 
 
 
set @Output= 'Success'   -- to set the output parameter
print @Output            -- to print it to screen
--Return @PackageID
 
 
 
 
END

Open in new window

0
 

Author Comment

by:Juliafrazer
ID: 22830179
Thanks,

but this function is the second call, after a stored procedure, which then calls another function as you can see.

The problem is, when i convert the above function to a strored procecure, i cant call it from another stored procedure...or can i?

Thanks

Julia
0
 
LVL 60

Expert Comment

by:chapmandew
ID: 22830303
absolutely....you can call another proc from one proc


create proc allprocs
as
exec proc1
exec proc2
exec proc3
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
SQL Merige returns error code when updating 15 54
SQL Select - Finding chars in a column 2 67
CROSS APPLY 4 57
Query to return total 6 23
by Mark Wills Attending one of Rob Farley's seminars the other day, I heard the phrase "The Accidental DBA" and fell in love with it. It got me thinking about the plight of the newcomer to SQL Server...  So if you are the accidental DBA, or, simp…
In this article I will describe the Copy Database Wizard method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
This video shows how to quickly and easily add an email signature for all users on Exchange 2016. The resulting signature is applied on a server level by Exchange Online. The email signature template has been downloaded from: www.mail-signatures…
I've attached the XLSM Excel spreadsheet I used in the video and also text files containing the macros used below. https://filedb.experts-exchange.com/incoming/2017/03_w12/1151775/Permutations.txt https://filedb.experts-exchange.com/incoming/201…

821 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question