Solved

Printing an Expression Tree with Parentheses in Java

Posted on 2008-10-28
6
3,217 Views
Last Modified: 2013-11-23
I've implemented a postfix-to-infix converter using stacks of expression trees. However, I'm running into a few minor issues that I can't seem to fix.

First, if the postfix expression passed contains two-digit numbers (i.e., 10, 20) as opposed to single-digit numbers or characters (i.e., 1, 5, A, E), the converter doesn't work properly. The reason behind this is because of a check I am making using the isDigit() or isCharacter() methods of the Character class. However, I don't know the correct syntax to check whether there are multiple digits.

My other problem lies in the fact that the parentheses seem to occur in the right spaces; however, the converter unnecessarily adds them around every digit/letter. For example, the input "AB+CD-*" returns (((A )+ (B ))* ((C )- (D ))).

My code is included below--it uses an ExpressionTree class that I created in addition to the PostfixToInfix converter file. I've attached the ExpressionTree class in the same code snippet.
import java.util.*;

 

public class PostfixToInfix {

 

	public static void postfixToInfix (String input)

	{

		Stack<ExpressionTree> treeStack = new Stack<ExpressionTree>();

		

		for (int i = 0; i <input.length(); i++)

		{

			char ch = input.charAt(i);

			if (Character.isDigit(ch))

			{

				treeStack.push(new ExpressionTree(ch, null, null));

			}

			else if (Character.isLetter(ch))

			{

				treeStack.push(new ExpressionTree(ch, null, null));

			}

			else if (ch=='+' || ch=='/' || ch=='*' || ch=='-')

			{

				ExpressionTree right = treeStack.pop();

				ExpressionTree left = treeStack.pop();

				treeStack.push(new ExpressionTree(ch, right, left));

			}

		}

		while (!treeStack.isEmpty())

			ExpressionTree.print(treeStack.pop());

	}

	public static void main(String[] args) {

		postfixToInfix("AB+CD-*");

		System.out.println();

		postfixToInfix("12345++++2010-34*/*");

		//Output should be ((1 + (2 + (3 + (4 + 5))))*((20 - 10) / (3 * 4)))

	}

}

 

//====================EXPRESSION TREE CLASS HERE 

//(May have to Change a call to the print method 

//due to the fact that this is an external file

public class ExpressionTree {

	

	char data;

	ExpressionTree left, right;

	

	public ExpressionTree(char data, ExpressionTree right, ExpressionTree left)

	{

		this.data = data;

		this.right = right;

		this.left = left;

	}

	

 

    public static void print (ExpressionTree tree) {

        if (tree == null) return;

        System.out.print("(");

        print (tree.left);

        

        System.out.print (tree.data + " ");

        print (tree.right);

        System.out.print(")");

    }

}

Open in new window

0
Comment
Question by:paid_tech
  • 4
  • 2
6 Comments
 
LVL 9

Accepted Solution

by:
mbodewes earned 500 total points
Comment Utility
How do you know that 2010 is either a single number or two or three or four numbers? And where should the digits split, always in the middle? You will need something to tell the difference between the numbers. One or multiple white-spaces would do the trick. Then tokenize the input before putting it into the tree.

The great thing about post-fix (which I still hate, it seems to be optimized for machines, not for human beings) is that you don't need parenthesis of course. After building the tree, you will need to walk it and see which operators take precedence and add the parentheses where the lower part of the inverted tree are of lower precedence than the ones on top of it.
0
 
LVL 9

Expert Comment

by:mbodewes
Comment Utility
Does this help you any or are you still stuck? Please post if you need more assistance.
0
 

Author Comment

by:paid_tech
Comment Utility
I'm still stuck. I've been working on it all week. I understand the algorithm, just don't know what the proper syntax would be to successfully skip over spaces.

I changed my ExpressionTree class to store String data instead of Character and I'm trying to add them to a temp String in the postfixtoinfix file.

As for parentheses, since the print method is recursive, I don't know how to print around only leaf nodes.

Your suggestions have helped some, but I'm still stuck.
0
How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

 
LVL 9

Expert Comment

by:mbodewes
Comment Utility
"I changed my ExpressionTree class to store String data instead of Character and I'm trying to add them to a temp String in the postfixtoinfix file."

That's a good start. Try and use a state machine to see where you are at a particular point in time. When you are going out of a name or number, put the String on the stack (for additional niceness, use a StringBuilder and toString(). You might want to create certain token types as well (e.g. operator, number, variable) and store those instead of just the String.

The rank of an expression is that of the operator in the expression. If a child expression has a lower rank (test this before going deeper) then you need to add parentheses.

Please post new code when you get the chance, I don't currently have the time to show some example code myself (unfortunately). I'm trying to create a java implementation of the Skein hash algorithm, and the testing takes loads of time.
0
 

Author Closing Comment

by:paid_tech
Comment Utility
Thanks for your help. I had to do a lot of debugging with System.out to make sure everything was working out properly, but I ended up implementing it.

Thanks for your input!
0
 
LVL 9

Expert Comment

by:mbodewes
Comment Utility
Lots of println statements for the Skein hash method as well, and it's working now. Look into (Apache commons or default Java) logging instead of println statements -> you can simply decide to not log later on, and if you need to change or test your application, you simply put it on again. It's pretty easy to learn.

That was a rather tough assignment by the way, tricky to get right. Glad you did get it right in the end.
0

Featured Post

Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
noX challenge 17 75
array6 challenfge 6 62
count11 challenge 6 46
topping3 challenge 14 48
For beginner Java programmers or at least those new to the Eclipse IDE, the following tutorial will show some (four) ways in which you can import your Java projects to your Eclipse workbench. Introduction While learning Java can be done with…
Article by: Nadia
Suppose you use Uber application as a rider and you request a ride to go from one place to another. Your driver just arrived at the parking lot of your place. The only thing you know about the ride is the license plate number. How do you find your U…
Viewers learn how to read error messages and identify possible mistakes that could cause hours of frustration. Coding is as much about debugging your code as it is about writing it. Define Error Message: Line Numbers: Type of Error: Break Down…
This tutorial covers a step-by-step guide to install VisualVM launcher in eclipse.

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now