Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 315
  • Last Modified:

I want to chop the last character of array elements in JavaScript...

Hi there;

I want to chop the last character of array elements in JavaScript...

Apparently, i am doing something wrong...What am i doing stg wrong and how to fix it without changing the algorithm drastically?

Best regards...
<html>
<head>
<script>
function chop()
{
for (var i in this)
{
if (typeof this[i] == "string"){
this[i] = this[i].substring(0, this[i].length-1)
document.write(this[i]);   
}
}
}
Array.prototype.chop = chop
 
var line = new Array("red", "green", "blue")
 
</script>
</head>
<body>
</body>
</html>

Open in new window

0
jazzIIIlove
Asked:
jazzIIIlove
  • 3
  • 2
3 Solutions
 
Lolly-InkCommented:
You just need to call the chop function to see that it works already.
<html>
<script>
   function chop()
   {
      for (var i in this)
      {
         if (typeof this[i] == "string")
         {
            this[i] = this[i].substring(0, this[i].length-1);
            document.write(this[i]);   
         }
      }
   }
   Array.prototype.chop = chop
    
   var line = new Array("red", "green", "blue")
   line.chop();
</script>
</html>

Open in new window

0
 
hieloCommented:
I suggest you do NOT use document.write within the function. Once the browser has finished loading you will not be able to call your chop() method. If leave the document.write in place and call chop() after the document has loaded you will "erase" everything that was previously on the window. Try:
<html>
<head>
<script>
function chop()
{
	for (var i in this)
	{
		if (typeof this[i] == "string"){
			this[i] = this[i].substring(0, this[i].length-1) 
		}
	}
}
Array.prototype.chop = chop
 
var line = new Array("red", "green", "blue") 

</script>
</head>
<body>
<script>
line.chop();
document.write( line.join("; ") )
document.write("<hr>");
document.write( line.join("; ") )
</script>
</body>
</html>

Open in new window

0
 
jazzIIIloveAuthor Commented:
Lolly-Ink:
nice point...I forgot the call:)

hielo:
<<I suggest you do NOT use document.write within the function.

Is this a generalization, i mean using document.writeln() within the function is risky...or just for this case?

<<Once the browser has finished loading you will not be able to call your chop() method. If leave the <<document.write in place and call chop() after the document has loaded you will "erase" everything <<that was previously on the window

I am really confused about the point once the browser finished loading...I mean for example in your code, above  the browser has finished loading after </html> tag...right? or at which point?

0
Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

 
hieloCommented:
>> i mean using document.writeln() within the function is risky
What I mean is that you can only use document.write on page while it is loading. After it has loaded, then you will "destroy" the previous page and then document.write will write to the new one. Consider this:
test1.html
<html>
<body>
<h1>Test</h1>
<script>
//this will get printed as the page is loaded
document.write('<p>Hello</p>');
</script>
</body>
</html>
 
test2.html
<html>
<body>
<h1>Test</h1>
<script>
//this will get printed as the page is loaded
function greet()
{
document.write('<p>Hello</p>');
}
/* "schedule" the greet function for execution after the page has finished loading. Where is the "Test" Heading?*/
window.onload=greet;
</script>
</body>
</html>

Open in new window

0
 
jazzIIIloveAuthor Commented:
hielo!

I love your explanation...

Best regards...
0
 
jazzIIIloveAuthor Commented:
not my code but the last message is hilarious...hielo!
0

Featured Post

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now