• C

why memory is not freed?

Hello group,

I was reading a book which has a nice example to start with link lists (in snippet) but I'm wondering why allocated memory is not given back to system?!
Is this an exception or is missed?

since I'm still learning I need to make sure things I'm learning here are right.

Regards,
ak

#define RECORDS 6
 
int main()
{
  struct jb {
    char actor[25];
    struct jb *next;
};
 
  char *bonds[RECORDS] =  {
     "Sean Connery",
     "David Niven",
     "George Lazenby",
     "Roger Moore",
     "Timoth Dalton",
     "Pierce Brosnan"
 
  };
 
  struct jb *first_item;
  struct jb *current_item;
  struct jb *new_item;
  int index = 0;
 
  first_item = (struct jb *)malloc(sizeof(struct jb));
  current_item = first_item;
 
  //this loop is only for feeding the structure
  while(1)
  {
    strcpy(current_item->actor, bonds[index]);
    index++;
    if (index< RECORDS)
    {
      new_item=(struct jb *)malloc(sizeof(struct jb));
      current_item->next = new_item;
      current_item       = new_item;
    }
    else {
      current_item->next = NULL;
      break;
    }
  }
 
  current_item = first_item;   /*start over*/
  index = 1;
 
  while(current_item)
  {
    printf("Structure %d: ", index++);
    printf("%s\n", current_item->actor);
    current_item = current_item->next;
  }
 
  return 0;
 
}

Open in new window

akohanAsked:
Who is Participating?
 
ozoConnect With a Mentor Commented:
If the he value of a pointer that refers to space deallocated by a call to the free or
realloc function is used, the behavior is undefined.
0
 
Peter HartCommented:
you hAVE TO UN-MALLOC THE MEMORY WHEN YOU HAVE FINISHED WITH IT
OTHERWISE IT WILL BE RELEASED WHEN THE PROGRAM ENDS
(SORRY CAPS ON)
0
 
akohanAuthor Commented:

So, using fee() function only is enough?
e.g.


  free(first_item);
  first_item=NULL:
and etc...


0
Creating Active Directory Users from a Text File

If your organization has a need to mass-create AD user accounts, watch this video to see how its done without the need for scripting or other unnecessary complexities.

 
Infinity08Commented:
>> (SORRY CAPS ON)

lol. You know you can turn it off, don't you ? ;)


akohan, dynamically allocated memory has to be explicitly free'd using free :

        http://www.cplusplus.com/reference/clibrary/cstdlib/free.html
0
 
ozoCommented:
if not explicitly freed, the allocated memory is given back to system when the program exits
0
 
Infinity08Commented:
>> So, using fee() function only is enough?

For every malloc, you need to have a corresponding free. So, in your case, every node in the linked list needs to be free'd.
0
 
Peter HartCommented:
p.s. only free the memory once you have finished using it. :-)
if you write to the memory  after you have sent it back the program will throw exeption

cool,  I like this CAPs ON CAPS off  toggle Key , although my keyboard has
stupidly marked as 'caps lock'  :-))
0
 
MysidiaCommented:
Actually, no.

Usually no exception will be thrown if you attempt to write to free()'d memory.
What happens in practice is far more insidious.

Writing to free()'d memory will very likely corrupt the heap, and (if you're lucky) cause your program to crash the next time you attempt to allocate or free memory.

If you are unlucky, another malloc()'  call will have assigned that memory, and you will be silently corrupting data  elsewhere in your program.


If you want to release the memory,  you should free it after you take it out of your list, and perform no further operations on removed nodes, once they are freed.

 




struct jb* temp;
 
  while(current_item)
  {
    printf("Structure %d: ", index++);
    printf("%s\n", current_item->actor);
    temp = current_item;
    current_item = current_item->next;
 
    free(temp); /* temp is no longer in the list, now free it... */
  }

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.