T-SQL - INSERTing range of rows from one table into antoher

OrderID or ItemNo?

I see no ItemID

Also, you are passing in @SerialNum, but then looking up the OrderID from the same table.  Why not do this because it is essentially what you are telling it to do.:

INSERT  ProdCycle
(
                OrderID,
                SerialNum,
                ItemNo
)
SELECT ProdID, SerialNum, ItemNo
FROM Serials
WHERE SerialNum=@SerialNum

Select allOpen in new window

Sorry, ItemID=ItemNo.

The Serials table contains OrderID column but it's not actually an ID column. It allows duplicate values. And SerialNum, instead is a unique value in this table. So, I need to pass SerialNum to query, that will check OrderID for this SerialNum and select all rows with the same OrderID to another table.

The Serials table is similar to the following sample:

OrderID            SerialNum                      ItemID
945                   1a21s23                       231521
945                   1a21s43                       231411
945                   1a21ac3                       231311
102                   1a21we3                      231512
102                   1a21sd3                       231511

I need to pass a serial number, like 1a21s23 and insert all rows with OrderID 945 into another table.

CREATE PROC up_name
        @SerialNo               NVARCHAR(10)
AS
INSERT  ProdCycle
(
                OrderID,
                SerialNum,
                ItemNo
)
SELECT OrderID, SerialNum, ItemNo
FROM Serials
WHERE OrderID = 
(
                SELECT OrderID,
                FROM Serials
                WHERE SerialNum=@SerialNum
)

Select allOpen in new window

Think you just have an extra comma in code.

CREATE PROC up_name
	@SerialNo		NVARCHAR(10)
AS
INSERT  ProdCycle
(
		OrderID,
		SerialNum,
		ItemNo
)
SELECT ProdID, SerialNum, ItemNo
FROM Serials
WHERE OrderID = 
(
		SELECT OrderID /*, <-- remove this */
		FROM Serials
		WHERE SerialNum=@SerialNum
)

Select allOpen in new window