Solved

T-SQL - INSERTing range of rows from one table into antoher

Posted on 2008-11-02
5
566 Views
Last Modified: 2012-05-05
Hi!

I'm creating a stored procedure, that will accept a value from a user, check against one table and then copy corresponding rows from that table into another.

I've made the procedure, but ItemID remains all the same in all rows...
What do I do wrong here?



CREATE PROC up_name

	@SerialNo		NVARCHAR(10)

AS

INSERT  ProdCycle

(

		OrderID,

		SerialNum,

		ItemNo

)

SELECT ProdID, SerialNum, ItemNo

FROM Serials

WHERE OrderID = 

(

		SELECT OrderID,

		FROM Serials

		WHERE SerialNum=@SerialNum

)

Open in new window

0
Comment
Question by:Zaurb
5 Comments
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22862371
OrderID or ItemNo?

I see no ItemID

Also, you are passing in @SerialNum, but then looking up the OrderID from the same table.  Why not do this because it is essentially what you are telling it to do.:




INSERT  ProdCycle

(

                OrderID,

                SerialNum,

                ItemNo

)

SELECT ProdID, SerialNum, ItemNo

FROM Serials

WHERE SerialNum=@SerialNum

Open in new window

0
 
LVL 1

Author Comment

by:Zaurb
ID: 22862412
Sorry, ItemID=ItemNo.

The Serials table contains OrderID column but it's not actually an ID column. It allows duplicate values. And SerialNum, instead is a unique value in this table. So, I need to pass SerialNum to query, that will check OrderID for this SerialNum and select all rows with the same OrderID to another table.

The Serials table is similar to the following sample:

OrderID            SerialNum                      ItemID
945                   1a21s23                       231521
945                   1a21s43                       231411
945                   1a21ac3                       231311
102                   1a21we3                      231512
102                   1a21sd3                       231511

I need to pass a serial number, like 1a21s23 and insert all rows with OrderID 945 into another table.

CREATE PROC up_name

        @SerialNo               NVARCHAR(10)

AS

INSERT  ProdCycle

(

                OrderID,

                SerialNum,

                ItemNo

)

SELECT OrderID, SerialNum, ItemNo

FROM Serials

WHERE OrderID = 

(

                SELECT OrderID,

                FROM Serials

                WHERE SerialNum=@SerialNum

)

Open in new window

0
 
LVL 9

Accepted Solution

by:
jamesgu earned 125 total points
ID: 22862511
the code seems OK to me,

try to execute the select statement , see what do you get?

SELECT OrderID, SerialNum, ItemNo
FROM Serials
WHERE OrderID =
(
                SELECT OrderID,
                FROM Serials
                WHERE SerialNum=@SerialNum
)
0
 
LVL 59

Expert Comment

by:Kevin Cross
ID: 22862626
Think you just have an extra comma in code.
CREATE PROC up_name

	@SerialNo		NVARCHAR(10)

AS

INSERT  ProdCycle

(

		OrderID,

		SerialNum,

		ItemNo

)

SELECT ProdID, SerialNum, ItemNo

FROM Serials

WHERE OrderID = 

(

		SELECT OrderID /*, <-- remove this */

		FROM Serials

		WHERE SerialNum=@SerialNum

)

Open in new window

0
 
LVL 59

Assisted Solution

by:Kevin Cross
Kevin Cross earned 125 total points
ID: 22862641
With your corrected code:
CREATE PROC up_name

        @SerialNo               NVARCHAR(10)

AS

INSERT  ProdCycle

(

                OrderID,

                SerialNum,

                ItemNo

)

SELECT OrderID, SerialNum, ItemNo

FROM Serials

WHERE OrderID = 

(

                SELECT OrderID

                FROM Serials

                WHERE SerialNum=@SerialNum

)

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

'Between' is such a common word we rarely think about it but in SQL it has a very specific definition we should be aware of. While most database vendors will have their own unique phrases to describe it (see references at end) the concept in common …
In this article I will describe the Copy Database Wizard method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
Windows 10 is mostly good. However the one thing that annoys me is how many clicks you have to do to dial a VPN connection. You have to go to settings from the start menu, (2 clicks), Network and Internet (1 click), Click VPN (another click) then fi…
This is used to tweak the memory usage for your computer, it is used for servers more so than workstations but just be careful editing registry settings as it may cause irreversible results. I hold no responsibility for anything you do to the regist…

862 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

25 Experts available now in Live!

Get 1:1 Help Now