Solved

Display multiple images from directory with while loop

Posted on 2008-11-02
12
1,635 Views
Last Modified: 2012-06-21
Can't get this simple loop to display all images in directory - only first one.
<?php
include_once( $_SERVER['DOCUMENT_ROOT'].'/includes/php/databaseConfig.php' ); 
$query = "SELECT id, img_path FROM test1";
$result = mysql_query($query) or die(mysql_error());
if (mysql_num_rows($result) > 0) {
while($row = mysql_fetch_array($result)) 
{
	echo '<p><img src="upimg/'.$row['img_path'].'></p>';
 
    }
}
?>

Open in new window

0
Comment
Question by:shareea
  • 7
  • 5
12 Comments
 
LVL 27

Expert Comment

by:yodercm
ID: 22864185
The images in the directory is not what you're displaying, you're displaying based on what's in your table test1.

How many rows in that table?
0
 

Author Comment

by:shareea
ID: 22864241
Have been trying several files out - eyeballs getting tired. Yes, seems there's only 1 row in that table but have several images in the directory. Here's my input form:
<?php
include_once( $_SERVER['DOCUMENT_ROOT'].'/includes/php/databaseConfig.php' );      
 
$max_no_img=3; // Maximum number of images value to be set here
 
echo "<form method=post action=addimgck.php enctype='multipart/form-data'>";
echo "<table border='0' width='400' cellspacing='0' cellpadding='0' align=center>";
for($i=1; $i<=$max_no_img; $i++){
echo "<tr><td>Images $i</td><td>
<input type=file name='images[]'></td></tr>";
}
 
echo "<tr><td colspan=2 align=center><input type=submit value='Add Image'></td></tr>";
echo "</form> </table>";
 
while(list($key,$value) = @each($_FILES[images][name]))
{
if(!empty($value)){   // this will check if any blank field is entered
$filename = $value;    // filename stores the value
$add = "upimg/$filename";   // upload directory path is set
//echo $_FILES[images][type][$key];     // uncomment this line if you want to display the file type
// echo "<br>";                             // Display a line break
copy($_FILES[images][tmp_name][$key], $add);     //  upload the file to the server
chmod("$add",0777);                 // set permission to the file.
$query = "INSERT INTO test1 (img_path) VALUES ('$filename')";
mysql_query($query);
	}
}
?>

Open in new window

0
 
LVL 27

Expert Comment

by:yodercm
ID: 22864253
The loop you originally posted is displaying based on what rows are in the table, so if there is only one row, then you will only see one image, no matter what is in the directory.

As for the rest -- how you get the file path/names into the table -- I'm not knowledgable about that part.  Hopefully someone else who knows file handling in php will pop in and help.
0
ScreenConnect 6.0 Free Trial

Want empowering updates? You're in the right place! Discover new features in ScreenConnect 6.0, based on partner feedback, to keep you business operating smoothly and optimally (the way it should be). Explore all of the extras and enhancements for yourself!

 

Author Comment

by:shareea
ID: 22864264
Yeah - seem to be missing the part where filedata is converted to jpeg. Thanks for your help all the same.
0
 
LVL 27

Expert Comment

by:yodercm
ID: 22864283
The best technique is to put some echo statements into your code at strategic places and see exactly where the problem is occurring.  This will help you sort it out.
0
 

Author Comment

by:shareea
ID: 22864425
This snippet worked to display all images located in a directory named upimg:
<?php
 
$dirname = "upimg/";
$images = scandir($dirname);
$ignore = Array(".", "..");
foreach($images as $curimg){
if(!in_array($curimg, $ignore)) {
echo "<img src='upimg/$curimg' /><br>\n";
};
}     
?>

Open in new window

0
 
LVL 27

Accepted Solution

by:
yodercm earned 500 total points
ID: 22864444
OK, so replace the echo with the database INSERT, and then see what you get into the table.  Be sure to follow the query with

echo mysql_error();

so you know if an INSERT failed.
0
 
LVL 27

Expert Comment

by:yodercm
ID: 22864448
Then just keep doing this, step by step, until you find where the process isn't doing what you expect.  I'll check in again tomorrow morning :)
0
 

Author Comment

by:shareea
ID: 22869198
Files are being uploaded to the directory and displaying but only first image is being entered into database table. Need to loop the query. Any suggestions?
<?php
include_once( $_SERVER['DOCUMENT_ROOT'].'/includes/php/databaseConfig.php' );      
 
$max_no_img=3; // Maximum number of images value to be set here
?>
<form method=post action="<?php echo $_SERVER['PHP_SELF']; ?>" enctype='multipart/form-data'>
<table border='0' width='400' cellspacing='0' cellpadding='0' align=center>
<?php for($i=1; $i<=$max_no_img; $i++){
echo "<tr><td>Images $i</td><td>
<input type=file name='images[]' ></td></tr>";
}
 
echo "<tr><td colspan=2 align=center><input type=submit value='Add Image'></td></tr>";
echo "</form> </table>";
 
while(list($key,$value) = @each($_FILES[images][name]))
{
if(!empty($value)){   // this will check if any blank field is entered
$filename = $value;    // filename stores the value
$add = "upimg/$filename";   // upload directory path is set
//echo $_FILES[images][type][$key];     // uncomment this line if you want to display the file type
// echo "<br>";                             // Display a line break
copy($_FILES[images][tmp_name][$key], $add);     //  upload the file to the server
chmod("$add",0777);                 // set permission to the file.
 
$query = "INSERT INTO test1 (img_path) VALUES ('$filename')";
mysql_query($query);
}
}
//view files in directory
$dirname = "upimg/";
$images = scandir($dirname);
$ignore = Array(".", "..");
foreach($images as $curimg){
if(!in_array($curimg, $ignore)) {
echo "<img src='upimg/$curimg' width='200px'/><br>\n";
};
}     
?>

Open in new window

0
 

Author Comment

by:shareea
ID: 22869242
And after adding echo mysql_error(); get following error:

Duplicate entry '0' for key 1
0
 

Author Comment

by:shareea
ID: 22869359
OK - worked it out.

$query = "INSERT INTO test1 (id, img_path)  VALUES ('$key','$filename')";
0
 

Author Closing Comment

by:shareea
ID: 31512569
Thanks! Mysql error() helped just like you said.
0

Featured Post

Are your AD admin tools letting you down?

Managing Active Directory can get complicated.  Often, the native tools for managing AD are just not up to the task.  The largest Active Directory installations in the world have relied on one tool to manage their day-to-day administration tasks: Hyena. Start your trial today.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Developers of all skill levels should learn to use current best practices when developing websites. However many developers, new and old, fall into the trap of using deprecated features because this is what so many tutorials and books tell them to u…
Password hashing is better than message digests or encryption, and you should be using it instead of message digests or encryption.  Find out why and how in this article, which supplements the original article on PHP Client Registration, Login, Logo…
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

825 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question