Solved

create xml

Posted on 2008-11-03
7
147 Views
Last Modified: 2012-05-05
I am trying to create a stored procedure that returns the output in XML.  I have attached the sample of what I have below, which works, but it is going to be a big hit on performance once there are a more records in the database.
How can I re-write this to make it faster?
SELECT QuestionnaireSections.SectionId,ISNULL(sectiontitle,'') AS sectiontitle,ISNULL(SectionDescription,'') AS SectionDescription,ISNULL(NumberingSequence,'') AS NumberingSequence,ISNULL(DisplaySettings,'') AS DisplaySettings,ISNULL(RepeatHeaders,'') AS RepeatHeaders,ISNULL(Startdate,'') AS Startdate,ISNULL(enddate,'') AS enddate,

	(SELECT SubSections.SectionId,ISNULL(sectiontitle,'') AS sectiontitle,ISNULL(SectionDescription,'') AS SectionDescription,ISNULL(NumberingSequence,'') AS NumberingSequence,ISNULL(DisplaySettings,'') AS DisplaySettings,ISNULL(RepeatHeaders,'') AS RepeatHeaders,ISNULL(Startdate,'') AS Startdate,ISNULL(enddate,'') AS enddate,

		(SELECT Questions.QuestionId AS QuestionId,ResponseOptions AS OptionId,ISNULL(QuestionTypeID,'') AS QuestionTypeID,ISNULL(SortId,'') AS SortId,ISNULL(QuestionDesc,'') AS QuestionDesc,ISNULL(PlanTypeId,'') AS PlanTypeId,ISNULL(ResponseTypeId,'') AS ResponseTypeId,ISNULL(ResponseOptions,'') AS ResponseOptions,ISNULL(IsMultiResponse,'') AS IsMultiResponse,ISNULL(QuestionNum,'') AS QuestionNum,ISNULL(PendFlag,'') AS PendFlag,

			(SELECT OptionId AS OptionId,OptionText As OptionText

			FROM IMQ.tbl_Q_OptionChoices OptionChoices

			WHERE OptionChoices.QuestionId = Questions.QuestionId FOR XML AUTO, TYPE

			),

			(SELECT QWorkFlowId,QuestionIdCurrent,QuestionIdNext,ISNULL(FlowId,'') AS FlowId,

				(SELECT ConditionId ,QuestionId,ConditionFunction,Conditionvalue,ISNULL(Units,'') AS Units,DateOptionId

				FROM imq.tbl_Q_WorkFlowDetails WorkFlowDetails 

				WHERE WorkFlowDetails.QWorkFlowId = WorkFlow.QWorkFlowId FOR XML AUTO, TYPE

				)

			FROM imq.tbl_Q_WorkFlow WorkFlow 

			WHERE WorkFlow.QuestionIdCurrent = Questions.QuestionId FOR XML AUTO, TYPE

			),

			(SELECT SubQuestions.QuestionId AS QuestionId,ResponseOptions AS OptionId,ISNULL(QuestionTypeID,'') AS QuestionTypeID,ISNULL(SortId,'') AS SortId,ISNULL(QuestionDesc,'') AS QuestionDesc,ISNULL(PlanTypeId,'') AS PlanTypeId,ISNULL(ResponseTypeId,'') AS ResponseTypeId,ISNULL(ResponseOptions,'') AS ResponseOptions,ISNULL(IsMultiResponse,'') AS IsMultiResponse,ISNULL(QuestionNum,'') AS QuestionNum,ISNULL(PendFlag,'') AS PendFlag,

				(SELECT OptionId AS OptionId,OptionText As OptionText

				FROM IMQ.tbl_Q_OptionChoices OptionChoices

				WHERE OptionChoices.QuestionId = SubQuestions.QuestionId FOR XML AUTO, TYPE

				),

				(SELECT QWorkFlowId,QuestionIdCurrent,QuestionIdNext,ISNULL(FlowId,'') AS FlowId,

					(SELECT ConditionId ,QuestionId,ConditionFunction,Conditionvalue,ISNULL(Units,'') AS Units,DateOptionId

					FROM imq.tbl_Q_WorkFlowDetails WorkFlowDetails 

					WHERE WorkFlowDetails.QWorkFlowId = WorkFlow.QWorkFlowId FOR XML AUTO, TYPE

					)

				FROM imq.tbl_Q_WorkFlow WorkFlow 

				WHERE WorkFlow.QuestionIdCurrent = SubQuestions.QuestionId FOR XML AUTO, TYPE

				),

				(SELECT SubChildQuestions.QuestionId AS QuestionId,ResponseOptions AS OptionId, ISNULL(QuestionTypeID,'') AS QuestionTypeID,ISNULL(SortId,'') AS SortId,ISNULL(QuestionDesc,'') AS QuestionDesc,ISNULL(PlanTypeId,'') AS PlanTypeId,ISNULL(ResponseTypeId,'') AS ResponseTypeId,ISNULL(ResponseOptions,'') AS ResponseOptions,ISNULL(IsMultiResponse,'') AS IsMultiResponse,ISNULL(QuestionNum,'') AS QuestionNum,ISNULL(PendFlag,'') AS PendFlag,

					(SELECT OptionId AS OptionId,OptionText As OptionText

					FROM IMQ.tbl_Q_OptionChoices OptionChoices

					WHERE OptionChoices.QuestionId = SubChildQuestions.QuestionId FOR XML AUTO, TYPE

					),

					(SELECT QWorkFlowId,QuestionIdCurrent,QuestionIdNext,ISNULL(FlowId,'') AS FlowId,

						(SELECT ConditionId ,QuestionId,ConditionFunction,Conditionvalue,ISNULL(Units,'') AS Units,DateOptionId

						FROM imq.tbl_Q_WorkFlowDetails WorkFlowDetails 

						WHERE WorkFlowDetails.QWorkFlowId = WorkFlow.QWorkFlowId FOR XML AUTO, TYPE

						)

					FROM imq.tbl_Q_WorkFlow WorkFlow 

					WHERE WorkFlow.QuestionIdCurrent = SubChildQuestions.QuestionId FOR XML AUTO, TYPE

					)

				FROM IMQ.tbl_Q_Question SubChildQuestions

				INNER JOIN IMQ.tbl_Map_ParentToSubQuestions sq_scq ON SubChildQuestions.questionId = sq_scq.SubquestionId AND SubQuestions.QuestionId = sq_scq.ParentquestionId

				WHERE SubQuestions.questionId = sq_scq.ParentquestionId FOR XML AUTO,TYPE

				)

			FROM IMQ.tbl_Q_Question SubQuestions 

			INNER JOIN IMQ.tbl_Map_ParentToSubQuestions q_sq ON SubQuestions.questionId = q_sq.SubquestionId

			WHERE Questions.questionId = q_sq.ParentquestionId FOR XML AUTO,TYPE

			) 

		FROM IMQ.tbl_Q_Question Questions 

		INNER JOIN IMQ.tbl_Map_QuestionToSection q_s ON Questions.questionId = q_s.questionId

		WHERE q_s.sectionId = SubSections.SectionId OR q_s.sectionId = QuestionnaireSections.SectionId FOR XML AUTO,TYPE

		)

	FROM IMQ.tbl_QuestionnaireSections SubSections

	LEFT JOIN IMQ.tbl_Map_SectionToSubSection s_s ON s_s.SubsectionId = SubSections.SectionId

	WHERE s_s.ParentSectionId = QuestionnaireSections.SectionId 

		FOR XML AUTO, TYPE

	)

FROM IMQ.tbl_QuestionnaireSections QuestionnaireSections 

WHERE QuestionnaireSections.VersionId = @versionid

FOR XML AUTO, TYPE

Open in new window

0
Comment
Question by:PsychoDazey
  • 4
  • 3
7 Comments
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22868161
Generating XML with SQL is NEVER going to be extremely efficient.  But I do notice that the only criteria you have is to join your subqueries out to the parent item.  Do you really need to generate your entire structure every time?
0
 
LVL 6

Author Comment

by:PsychoDazey
ID: 22868191
Yes, the xml structure is going to be saved in the database so it can later be extracted and modified.
0
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22869433
But you're not saving the XML in the database, you're building the XML from the data in the database.
0
U.S. Department of Agriculture and Acronis Access

With the new era of mobile computing, smartphones and tablets, wireless communications and cloud services, the USDA sought to take advantage of a mobilized workforce and the blurring lines between personal and corporate computing resources.

 
LVL 6

Author Comment

by:PsychoDazey
ID: 22869498
Right, and then using that data to run a report.  My problem isn't generating the XML, its the query that I'm using isn't well-written and it is starting to time out.
0
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 22869523
You don't have do to it with all of those nested queries.  You can do it with a series of joins.  This will allow the query to be run with or without it going to XML.
0
 
LVL 6

Author Comment

by:PsychoDazey
ID: 22869574
Sounds good, can you please give me an example?
0
 
LVL 39

Accepted Solution

by:
BrandonGalderisi earned 500 total points
ID: 22869770
Here you go.
create table #ParentStuff

     (StuffId       int identity primary key clustered

     ,StuffName     nvarchar(32) not null

     ,StuffData     nvarchar(255) null

     )

insert into #parentStuff (stuffName,StuffData)

          select 'Test',null

union all select 'Test2','Description'
 

create table #ChildStuff

     (StuffId       int identity primary key clustered

     ,ParentStuffid int

     ,StuffName     nvarchar(32) not null

     ,StuffData     nvarchar(255) null

     )

insert into #ChildStuff (parentstuffid,stuffName,StuffData)

          select 1,'Child Test','Child Test Data'

union all select 1,'Test2','Child Test 2 Description'

union all select 2,'Child Test','Child Test Data'

union all select 2,'Test2','Child Test 2 Description'

go

select parent.stuffid,parent.stuffname,parent.stuffdata, child.stuffid,child.stuffname,child.stuffdata

from #ParentStuff parent

  join #childstuff child

    on parent.stuffid = child.parentstuffid

go

select parent.stuffid,parent.stuffname,parent.stuffdata, child.stuffid,child.stuffname,child.stuffdata

from #ParentStuff parent

  join #childstuff child

    on parent.stuffid = child.parentstuffid

for xml auto,type,root('Stuff')

go

drop table #ParentStuff

drop table #ChildStuff

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction: When running hybrid database environments, you often need to query some data from a remote db of any type, while being connected to your MS SQL Server database. Problems start when you try to combine that with some "user input" pass…
In SQL Server, when rows are selected from a table, does it retrieve data in the order in which it is inserted?  Many believe this is the case. Let us try to examine for ourselves with an example. To get started, use the following script, wh…
Migrating to Microsoft Office 365 is becoming increasingly popular for organizations both large and small. If you have made the leap to Microsoft’s cloud platform, you know that you will need to create a corporate email signature for your Office 365…
Sending a Secure fax is easy with eFax Corporate (http://www.enterprise.efax.com). First, just open a new email message. In the To field, type your recipient's fax number @efaxsend.com. You can even send a secure international fax — just include t…

910 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

24 Experts available now in Live!

Get 1:1 Help Now