[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 2634
  • Last Modified:

How do I remove duplicates in NSMutableArray

I am not sure how to remove duplicate numbers in a NSMutableArray and whether to remove them before sorting or not.  And is there an easy way to remove duplicate numbers before they are even added to the array?  This is not homework.
#import <Foundation/Foundation.h>
 
int main (int argc, const char * argv[]) {
    NSAutoreleasePool * pool = [[NSAutoreleasePool alloc]init];
    
    NSNumberFormatter *numberFormatter = [[NSNumberFormatter alloc]init];
    [numberFormatter setFormatterBehavior:NSNumberFormatterBehavior10_4];
    [numberFormatter setFormat:@"00"];
    NSString *myNumberString;
    NSMutableArray *array;
    int i;
    NSNumber *newNumber;
    NSNumber *numbersToPrint;
 
    printf ("\n");
    array = [[NSMutableArray alloc]init];
    // Initialize the random number generator.
    srandom(time(NULL));
    for (i = 0; i < 6; i++) {
        newNumber = [[NSNumber alloc]initWithInt:random() % 55 + 1];
        myNumberString = [numberFormatter stringFromNumber:newNumber];
        [array addObject:myNumberString];
        [array sortUsingSelector:@selector(compare:)];
        [newNumber release];
    }
 
    // Using NSLog
    for (i = 0; i < 6; i++) {
        numbersToPrint = [array objectAtIndex:i];
        NSLog(@"The number at index %d is %@.", i, numbersToPrint);
    }
 
    [array release];
    [pool drain];
 
    return 0;
}

Open in new window

0
barnwillyb
Asked:
barnwillyb
  • 2
  • 2
1 Solution
 
AJViennaCommented:
You could use a NSMutableSet. A set can contain each value only once. Add random numbers until the set has the required size. And then copy it to an NSMutableArray (using NSEnumerator).

However, this is only a useful approach if the number of random numbers is quite large. In your case the number of generated random numbers is very small. It is probably much easier and faster to iterate for each random number over the NSMutableArray to find the right position and to insert the new random number at the right position (using insertObject:atIndex:). This way it is also sorted (insert-sort) during creating.
0
 
romanmCommented:
Use insertion sort, find the location to insert using a binary search,

insertion loop would look like this:

start = 0
end = array count
if array empty
  add item, go to next item.
1. search position = start + ((end - start) / 2), round down
2. if insert item equals item at search position, exit search and go to next item to insert
3. else if insert item is greater than the item at search position,
    if search position equals end
       insert at end
    else
       start = search position + 1
4. else
    if search position equals start
       insert before start
    else
       end = search position
5. if start equals end
    insert item after start.
6. else
    go to 1

so you get the insertion of a NSMutableSet, unique values and sorted, and save the need to copy.
0
 
AJViennaCommented:
@romanm, the binary search is only useful if there are more elements. With only 6 random numbers it will cause more overhead than benefit.
0
 
romanmCommented:
how will it cause more overhead then using a set?
a set uses a binary search too, a set has a red-black tree balancing each time you insert, (I am talking windows but I think same applies).

proposed algorithm is a shortcut over using a set, count of elements is irrelevent.
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now