FTP download file code Review

I am using an example from a Networking Programming book called: "Network Programming in .NET" by Fiach Reid.

The code works perfectly uploading file to a FTP site but it does not work when downloading. I dont get any error messages, the program simply hangs and stops responding after the download button is clicked.

Help is appreciated on this issue.

I am attaching a code snipet for reference.

Thank you
Private Sub cmdDownload_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdDownload.Click
 
        Dim filedata As Byte()
 
        SaveFileDialog1.ShowDialog()
        filedata = sendPassiveFTPcmd("RETR " + lstFiles.SelectedItem.ToString() + vbCrLf)
 
        Dim fs As FileStream = New FileStream(SaveFileDialog1.FileName, FileMode.CreateNew)
 
        fs.Write(filedata, 0, filedata.Length)
 
        fs.Close()
 
   End Sub
 
 
 
Public Function sendPassiveFTPcmd(ByVal cmd As String) As Byte()
 
        Dim szData() As Byte
        Dim al As New System.Collections.ArrayList
        Dim bytes As Int32
        Dim RecvBytes(Byte.MaxValue) As Byte
 
        szData = System.Text.Encoding.ASCII.GetBytes(cmd.ToCharArray())
 
        Dim totalLenght As Int32 = 0
 
        Dim PassiveConnection As NetworkStream
        PassiveConnection = createPassiveConnection()
        txtStatus.Text += vbCrLf + "Sent: " + cmd
 
        Dim commandStream As StreamReader = New StreamReader(NetStrm)
 
        NetStrm.Write(szData, 0, szData.Length)
 
        Do While (True)
 
            bytes = PassiveConnection.Read(RecvBytes, 0, RecvBytes.Length)
 
            If bytes <= 0 Then Exit Do
            totalLenght += bytes
            al.AddRange(RecvBytes)
        Loop
 
        al = al.GetRange(0, totalLenght)
 
        txtStatus.Text += vbCrLf + "Rcvd:" + commandStream.ReadLine() '125
        txtStatus.Text += vbCrLf + "Rcvd:" + commandStream.ReadLine()
 
        Return CType(al.ToArray((New Byte).GetType()), Byte())
 
 
    End Function

Open in new window

virgilarAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

drichardsCommented:
Where does the code hang?
0
virgilarAuthor Commented:

The filedata variable never gets populated. Although, the function SendPassiveFTPcmd seems to work fine (since it does not error out), it never returns a value to populate the filedata variable.

filedata = sendPassiveFTPcmd("RETR " + lstFiles.SelectedItem.ToString() + vbCrLf)

I believe that the problem is on the return statement. Thats supposed to return the bytes back to the variable on the download_click routine.

Return CType(al.ToArray((New Byte).GetType()), Byte())

0
virgilarAuthor Commented:
I found out what the problem is:

If you take a look at the picture attached the file name includes the date, time and size on the string. I hard coded a file name in the code and ran the download and everything worked fine.

So my problem is that i have to display the file names only on my list box instead. I have to trim the file name some how. The code below show how i add the file name to the list box.

The previous code i had included on my message works fine. The problem lies on how the string containing the file name is read by the download routine.


Public Sub GetRemoteFolders()
 
        Dim FilesandFolders() As String
        Dim FileorFolder As String
        Dim FolderList As String = ""
        Dim lastSpace As Integer = 0
 
        FolderList = Encoding.ASCII.GetString(sendPassiveFTPcmd("List" + vbCrLf))
 
        lstFiles.Items.Clear()
 
        lstFolder.Items.Clear()
 
        FilesandFolders = FolderList.Split(vbCr.ToCharArray())
 
        Dim i As Integer
 
        For i = 0 To FilesandFolders.GetUpperBound(0) - 1
 
            If FilesandFolders(i).StartsWith("-") Or FilesandFolders(i).StartsWith("d") Then
                lastSpace = 59 ' Unix Format
            Else
                lastSpace = 39 ' Dos Format
            End If
 
            FileorFolder = FilesandFolders(i).Substring(lastSpace)
 
            If FileorFolder.IndexOf(".") <> -1 Then
                lstFiles.Items.Add(FileorFolder.Trim())
            Else
                lstFolder.Items.Add(FileorFolder.Trim())
            End If
        Next
    End Sub

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Cloud Class® Course: CompTIA Healthcare IT Tech

This course will help prep you to earn the CompTIA Healthcare IT Technician certification showing that you have the knowledge and skills needed to succeed in installing, managing, and troubleshooting IT systems in medical and clinical settings.

drichardsCommented:
As I look at it again, the problem is more likely in the ReadLine of the commandStream.  I don't know the FTP spec i nthat detail.  Is it stuck waiting for the command response?

That woudl seem to be the most likely thing if it's hung, as you initially describe.  You can put a breakpoint on the return statement and see the state of things at that point.  If it never gets there, you can break and see which line it's on.
0
drichardsCommented:
Sorry, I'm watching football here and didn't see that you had already posted the solution.
0
virgilarAuthor Commented:
No problem. I am doing the same here. LOL.  Thanks for your help on this.

I will do some research and try to find out how to display the file name only. That should be it.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Programming Languages-Other

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.