asked on

speed up group membership

For reference: https://www.experts-exchange.com/questions/24131449/Speed-up-query.html
That script looks up all computers in a domain, starts to ping them one by one, once they reply back, it connects and dumps the users in the local admin group, and if you use the very last script with the -r it will look up the users that make up the groups that are listed in the local admins. Omitting the -r will look up just the user names and group names of the local admins, and not recursively break down the members of the group names.

I'd like to speed the process up, as I have large domains with thousands of computers in each.

Option Explicit
 
Const ADS_SCOPE_SUBTREE = 2
 
Sub GetMembers(strADSPath)
  ' Recursive subroutine to return group members
 
  On Error Resume Next : Err.Clear
  Dim objGroup : Set objGroup = GetObject(strADSPath)
  If Err.Number = 0 Then 
    Dim objMember
    For Each objMember in objGroup.Members
      If Not objInfLoopPrevention.Exists(objMember.ADSPath) Then
        objInfLoopPrevention.Add objMember.ADSPath, ""
        If objMember.Class = "Group" And booEnableRecursion = True Then
          GetMembers(objMember.ADSPath)
        Else
          WScript.Echo Replace(objMember.ADSPath, "WinNT://" , "")
        End If
      End If
    Next
  End If
  On Error Goto 0
 
  Set objGroup = Nothing
End Sub
 
Dim booEnableRecursion : booEnableRecursion = False
Dim objArgs : Set objArgs = WScript.Arguments
Dim strArg
For Each strArg in objArgs
  If LCase(strArg) = "-r" Then
    booEnableRecursion = True
  End If
Next
Set objArgs = Nothing
 
Dim objConnection : Set objConnection = CreateObject("ADODB.Connection")
objConnection.Provider = "ADsDSOObject"
objConnection.Open "Active Directory Provider"
 
Dim objCommand : Set objCommand =   CreateObject("ADODB.Command")
Set objCommand.ActiveConnection = objConnection
 
objCommand.CommandText = _
  "Select Name From 'LDAP://DC=some,DC=company,DC=com' WHERE objectClass='computer'"
 
objCommand.Properties("Page Size") = 1000
objCommand.Properties("Searchscope") = ADS_SCOPE_SUBTREE
 
Dim objRecordSet : Set objRecordSet = objCommand.Execute
 
WScript.Echo "Number of Computers: " & objRecordSet.RecordCount
 
Do Until objRecordSet.EOF
  Dim strComputer : strComputer = objRecordSet.Fields("Name").Value
 WScript.Echo strComputer
  Dim objShell : Set objShell = CreateObject("WScript.Shell")
  Dim strCommand : strCommand = "%comspec% /c ping -n 3 -w 1000 " & strComputer & ""
  Dim objExecObject : Set objExecObject = objShell.Exec(strCommand)
 
  Do While Not objExecObject.StdOut.AtEndOfStream
    Dim strText : strText = objExecObject.StdOut.ReadAll()
    If Instr(strText, "Reply") > 0 Then
      ' =====================================================================
      ' Insert your code here
      ' =====================================================================
 
      On Error Resume Next : Err.Clear
      Dim objWMIService : Set objWMIService = GetObject _
        ("winmgmts:\\" & strComputer & "\root\cimv2")
      Dim colItems : Set colItems = objWMIService.ExecQuery _
        ("Select * From Win32_OperatingSystem")
      If Err.Number <> 0 Then
        WScript.Echo strComputer & ": Error connecting to WMI"
      Else
        Dim objItem
        For Each objItem in ColItems
          Wscript.Echo strComputer & ": " & objItem.Caption
        Next
      End If
      On Error Goto 0
 
      Dim objInfLoopPrevention : Set objInfLoopPrevention = CreateObject("Scripting.Dictionary")
 
      WScript.Echo "Local Administrators:"
      GetMembers("WinNT://" & strComputer & "/Administrators,group")
 
      Set objInfLoopPrevention = Nothing
 
      ' =====================================================================
      ' End
      ' =====================================================================
    Else
      Wscript.Echo strComputer & " could not be reached."
    End If
  Loop
  objRecordSet.MoveNext
Loop

Open in new window

RobSampson

Hey rich,

I think the only way to speed up such a sequential script like this (which look likes I wrote it...:-)), is to change it to accept a bunch of computer names at one time, so that it runs sequentially against say, 10 machines. Then, you'd create a "parent" script that would enumerate AD, (lines 38 to 51), and call the "child" script with each 10 PCs or so.....

This way, you run multiple processes of the same script at the same time, each querying 10 different PCs.

Do you need assistance with creating a script to do that?

Regards,

Rob.