asked on
Insert on table After moving from one select box

Hi, I have this form where a person can add players to a Given Team. Now I am confussed how to do the INSERT part. I am using dreamweaver and the default wizard doesnt seem to work . Currently I have and error :

Microsoft OLE DB Provider for ODBC Drivers error '80040e14'

[Microsoft][SQL Native Client][SQL Server]The parameterized query '(@P1 text)INSERT INTO dbo.LeagueTeams (TeamName) VALUES (@P1)' expects the parameter '@P1', which was not supplied.

/Leagues/quickTeamAdd.asp, line 25
Many Thanks
<%@LANGUAGE="VBSCRIPT" CODEPAGE="65001"%>
<!--#include file="../../Connections/sqlConn1.asp" -->
<%
Dim MM_editAction
MM_editAction = CStr(Request.ServerVariables("SCRIPT_NAME"))
If (Request.QueryString <> "") Then
  MM_editAction = MM_editAction & "?" & Server.HTMLEncode(Request.QueryString)
End If
 
' boolean to abort record edit
Dim MM_abortEdit
MM_abortEdit = false
%>
<%
If (CStr(Request("MM_insert")) = "form1") Then
  If (Not MM_abortEdit) Then
    ' execute the insert
    Dim MM_editCmd
 
    Set MM_editCmd = Server.CreateObject ("ADODB.Command")
    MM_editCmd.ActiveConnection = MM_sqlConn1_STRING
    MM_editCmd.CommandText = "INSERT INTO dbo.LeagueTeams (TeamName) VALUES (?)" 
    MM_editCmd.Prepared = true
    MM_editCmd.Parameters.Append MM_editCmd.CreateParameter("param1", 201, 1, 50, Request.Form("_ctl0_ContentPlaceHolder_TeamName")) ' adLongVarChar
    MM_editCmd.Execute
    MM_editCmd.ActiveConnection.Close
  End If
End If
%>
<%
Dim Recordset1__MMColParam
Recordset1__MMColParam = "1"
If (Request.QueryString("League") <> "") Then 
  Recordset1__MMColParam = Request.QueryString("League")
End If
%>
<%
Dim Recordset1
Dim Recordset1_cmd
Dim Recordset1_numRows
 
Set Recordset1_cmd = Server.CreateObject ("ADODB.Command")
Recordset1_cmd.ActiveConnection = MM_sqlConn1_STRING
Recordset1_cmd.CommandText = "SELECT GolferID, LeagueID, FirstName, LastName FROM dbo.LeagueGolfers WHERE LeagueID = ?" 
Recordset1_cmd.Prepared = true
Recordset1_cmd.Parameters.Append Recordset1_cmd.CreateParameter("param1", 5, 1, -1, Recordset1__MMColParam) ' adDouble
 
Set Recordset1 = Recordset1_cmd.Execute
Recordset1_numRows = 0
%>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Documento sin t&iacute;tulo</title>
<link href="../Template/style.css" rel="stylesheet" type="text/css" />
<style type="text/css">
<!--
.Estilo2 {font-size: 16px}
-->
</style>
<script type="text/javascript">
function list(){
	var optionList = document.getElementById('_ctl0_ContentPlaceHolder_TeamGolfers').options;
	var data = '';
	var len = optionList.length;  
	for(i=0; i<len; i++){
		data += optionList.item(i).value+',';
	}	
	document.getElementById('HiddenList').value = data			
}
 
 
 
 
 
function MoveOption(objSourceElement, objTargetElement){ 
 
	if(objSourceElement.value==''){
		alert('Please select an option to move');
		return false;	
	}
 
	var aryTempSourceOptions = new Array();        
	var x = 0;               
	//looping through source element to find selected options        
	for (var i = 0; i < objSourceElement.length; i++){            
		if (objSourceElement.options[i].selected){          	
			//need to move this option to target element                
			var intTargetLen = objTargetElement.length++;                
			objTargetElement.options[intTargetLen].text = objSourceElement.options[i].text;                
			objTargetElement.options[intTargetLen].value = objSourceElement.options[i].value;            
		}else{                
			//storing options that stay to recreate select element                
			var objTempValues = new Object();                
			objTempValues.text = objSourceElement.options[i].text;                
			objTempValues.value = objSourceElement.options[i].value;                
			aryTempSourceOptions[x] = objTempValues;               
			x++;           
		}       
	}              
	//resetting length of source        
	objSourceElement.length = aryTempSourceOptions.length;       
	//looping through temp array to recreate source select element      
	for (var i = 0; i < aryTempSourceOptions.length; i++){            
		objSourceElement.options[i].text = aryTempSourceOptions[i].text;           
		objSourceElement.options[i].value = aryTempSourceOptions[i].value;           
		objSourceElement.options[i].selected = false;        
	}    
}
function MM_callJS(jsStr) { //v2.0
  return eval(jsStr)
}
</script>
</head>
 
<body>
<div id="content2">
  <p> </p>
  <p> </p>
  <p><br />
  </p>
<div id="Div1"><strong><strong></strong><strong></strong><strong></strong><strong></strong></strong>
        <div>
          <p><span class="Estilo2" id="_ctl0_ContentPlaceHolder_TeamTitle">Quick Team   Add</span></p>
          <p>&nbsp;</p>
          <form id="form1" name="form1" method="POST" action="<%=MM_editAction%>">
            <div id="content">
              <div id="Div2">
                <div>
                  <table id="_ctl0_ContentPlaceHolder_TeamTable" cellspacing="0" cellpadding="4" width="100%" border="0">
                    <tbody>
                      <tr>
                        <td colspan="3"></td>
                      </tr>
                      <tr>
                        <td colspan="3">Team Name<span id="_ctl0_ContentPlaceHolder_TeamNameValidator" title="Team Name is required." controltovalidate="_ctl0_ContentPlaceHolder_TeamName" errormessage="Team Name is required." initialvalue="" isvalid="true" display="Dynamic"> (Required)</span>
                            <input id="_ctl0_ContentPlaceHolder_TeamName" tabindex="5" maxlength="20" name="_ctl0:ContentPlaceHolder:TeamName" />
                          (Maximum of 20   characters)</td>
                      </tr>
                      <tr>
                        <td colspan="3"></td>
                      </tr>
                      <tr>
                        <td colspan="3">Add/Remove golfers for this team.</td>
                      </tr>
                      <tr>
                        <td width="25%" align="middle" style="width: 12%"><span id="_ctl0_ContentPlaceHolder_OnTheTeamLabel"><strong>On   the Team</strong></span> </td>
                        <td width="16%" align="middle" valign="center" style="width: 7%"></td>
                        <td align="middle" width="59%"><div align="left"><span id="_ctl0_ContentPlaceHolder_AvailableGolfersLabel"><strong>Available Golfers</strong></span> </div></td>
                      </tr>
                      <tr>
                        <td valign="top" style="width: 12%"><select id="_ctl0_ContentPlaceHolder_TeamGolfers" multiple="multiple" size="10" name="_ctl0:ContentPlaceHolder:TeamGolfers" style="width: 133px">
                          </select>
                        </td>
                        <td valign="center" align="middle" style="width: 7%"><input id="_ctl0_ContentPlaceHolder_AddToTeam" type="submit" value="&lt;-- Add to Team" name="_ctl0:ContentPlaceHolder:AddToTeam" onclick="MoveOption(document.getElementById('_ctl0_ContentPlaceHolder_AvailableGolfers'), document.getElementById('_ctl0_ContentPlaceHolder_TeamGolfers'))"/>
                            <br />
                            <br />
                            <input id="_ctl0_ContentPlaceHolder_RemoveFromTeam" type="submit" value="Remove from Team --&gt;" name="_ctl0:ContentPlaceHolder:RemoveFromTeam" onclick="MoveOption(document.getElementById('_ctl0_ContentPlaceHolder_TeamGolfers'), document.getElementById('_ctl0_ContentPlaceHolder_AvailableGolfers'))"/>
                        </td>
                        <td valign="top"><div align="left">
                            <select id="_ctl0_ContentPlaceHolder_AvailableGolfers" multiple="multiple" size="10" name="_ctl0:ContentPlaceHolder:AvailableGolfers">
                              <%
While (NOT Recordset1.EOF)
%>
                              <option value="<%=(Recordset1.Fields.Item("FirstName").Value)%><%=(Recordset1.Fields.Item("LastName").Value)%>"><%=(Recordset1.Fields.Item("FirstName").Value)%>,<%=(Recordset1.Fields.Item("LastName").Value)%></option>
                              <%
  Recordset1.MoveNext()
Wend
If (Recordset1.CursorType > 0) Then
  Recordset1.MoveFirst
Else
  Recordset1.Requery
End If
%>
                            </select>
                        </div></td>
                      </tr>
                      <tr>
                        <td colspan="3"><hr />
                        </td>
                      </tr>
                      <tr>
                        <td align="right" colspan="3"><div align="left">
                            <input name="Save" type="submit" id="_ctl0_ContentPlaceHolder_SaveAndClose" tabindex="50" onclick="list();" value="Save and Close" language="javascript" />
                            <input language="javascript" id="_ctl0_ContentPlaceHolder_Cancel" tabindex="55" type="submit" value="Close" name="Close" />
                            <input type="hidden" name="hiddenList" id="hiddenList" />
                        </div></td>
                      </tr>
                    </tbody>
                  </table>
                </div>
                <strong><strong></strong><strong></strong><strong></strong><strong></strong></strong></div>
            </div>
                    
            <input type="hidden" name="MM_insert" value="form1" />
          </form>
          <p>&nbsp;</p>
          <p> </p>
          <p> </p>
        </div>
<div></div>
      </div>
</div>
</body>
</html>
<%
Recordset1.Close()
Set Recordset1 = Nothing
%>
Open in new window
Eric - Netminder
Simply put, the parameter isn't being passed to the insert query.

It looks like you've named the parameter to be passed as param1, but the query is expecting a parameter named P1. Try fixing that.

As I recall, you can test the query before trying to actually incorporate it into the page (I haven't used Dreamweaver for several years) -- that's where your problem is.

ep