asked on

Problems with processbar

When I run this code the progressbar just show me the end result. I want it to show me everytime it has handle a request.

I hope this is a simple and eay question.

procedure TFrmMain.Button3Click(Sender: TObject);
var List, ItemList, SubList: TStrings; I, n: Integer;
  aMan: string;
begin
  IdSMTP1.Host := 'mail.firm.org';
  ItemList := TStringList.Create;
  try
    List := TStringList.Create;
    try
      for I := 0 to Memo2.Lines.Count-1 do
      begin
        ItemList.CommaText := Memo2.Lines[I];
        aMan := ItemList[4];
        n := List.IndexOf(aMan);
        if n = -1 then
        begin
          SubList := TStringList.Create;
          n := List.AddObject(aMan, SubList);
        end;
        TStringList(List.Objects[n]).Add(ItemList[0] + ' ' + ItemList[1]);
      end;
      IdMessage1.From.Address := 'Automail@firm.com';
      IdMessage1.Subject := Edit1.Text;
      ProgressBar1.Max := list.Count;
      ProgressBar1.Step := round(100 / progressbar1.Max);
      for I := 0 to List.Count-1 do
      begin
        IdMessage1.Body.Clear;
        IdMessage1.Recipients.Add.Address := '';
        IdMessage1.Subject := 'Manager ' + List[I];
        IdMessage1.Body.AddStrings(memo1.Lines);
        IdMessage1.Body.Add('');
        IdMessage1.Body.Add('Manager ' + List[I]);
        IdMessage1.Body.Add('----------------------');
        IdMessage1.Body.AddStrings(TStringList(List.Objects[I]));
        IdMessage1.Body.Add('');
        IdMessage1.Body.Add('');
        IdSMTP1.Connect;
        IdSMTP1.Send(IdMessage1);
        IdSMTP1.Disconnect();
        ProgressBar1.Stepit;
        Application.Processmessages;
      end;
    finally
      FreeAndNil(List);
    end;
  finally
    FreeAndNil(ItemList);
  end;
  Edit1.Clear;
  memo1.Clear;
end;

Open in new window

dprochownik

How many Items are on the List?

Geert G

add ProgressBar1.Update at the end of a change to see it drawn on screen

ProgressBar1.Stepit;
ProgressBar1.Update;

dprochownik

if List.Count is greater than 200 then
ProgressBar1.Max := list.Count;
ProgressBar1.Step := round(100 / progressbar1.Max);
will set ProgressBar1.Step = 0

Geert G

doesn't this work faster: ?

    IdSMTP1.Connect;
    try 
      for I := 0 to List.Count-1 do
      begin
        IdMessage1.Body.Clear;
        IdMessage1.Recipients.Add.Address := '';
        IdMessage1.Subject := 'Manager ' + List[I];
        IdMessage1.Body.AddStrings(memo1.Lines);
        IdMessage1.Body.Add('');
        IdMessage1.Body.Add('Manager ' + List[I]);
        IdMessage1.Body.Add('----------------------');
        IdMessage1.Body.AddStrings(TStringList(List.Objects[I]));
        IdMessage1.Body.Add('');
        IdMessage1.Body.Add('');
        IdSMTP1.Send(IdMessage1);
        ProgressBar1.Stepit;
        Application.Processmessages;
      end;
    finally 
      IdSMTP1.Disconnect;    
    end;

Open in new window

Geert G

procent change may work better ...

ProgressBar1.Max := 100;
ProgressBar1.Position := Round(I/(ListCount-1)*100);

QC20N

ASKER

Where should I put:

ProgressBar1.Position := Round(I/(ListCount-1)*100);

dprochownik

It is equivalent of yours
ProgressBar1.Stepit;

dprochownik

You could also set:
ProgressBar1.Max := list.Count

and replace
ProgressBar1.Stepit;
by
ProgressBar1.Position := i;

ProgressBar will internally calculate how many percent of ProgressBar1.Max is ProgressBar1.Position.

ASKER CERTIFIED SOLUTION

dprochownik

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial