asked on 3/19/2009

Using SqlHelper.ExecuteDataset in VB.Net

Hi Experts,

I am new to .Net and have been reading, reading, reading...
From a previous question, I found out about the Microsoft.ApplicationBlocks.Data and am trying to use this to access my data.
I have created the code below to fill grids (fpSpread).
Everything I have read says that you always close the connection, but with the sqlhelper I was wondering if this will close the connection for me and if this code is correct?
Thanks,
Sheri

Public Shared ReadOnly Property ConnectionString() As String
        Get
            Return ConfigurationManager.AppSettings("ConnectionString")
 
        End Get
    End Property
 
Public Function GetDataSetGrd(ByVal strSQL As String) As DataSet
        Dim ds As New DataSet
       
        Try
            ds = SqlHelper.ExecuteDataset(AppConfig.ConnectionString, _
                                CommandType.Text, strSQL)
            Return ds
            Exit Try
 
        Catch ex As Exception
            MessageBox.Show(ex.Message)
            Return Nothing
 
        Finally
            If Not ds Is Nothing Then
                ds.Dispose()
 
            End If
        End Try
 
    End Function

Last Comment

3/20/2009

3/19/2009

The code you have posted is creating the connection object, based on the connection string that you have provided. Since you dont hold the reference to the created connection object, you cannot tell whether it is opened or closed. I have never used this library, but I assume it does close the connection - otherwise it would be a huge bug/memory leak.

Generally speaking, when you use dataadapter to create dataset object (using Fill method), if the connection was closed, it will close it after it has filled dataset. If it was opened, it would leave it opened. If this class uses internally dataadapter, then, as you already guessed, it will close it.

Goran

Sheritlw

3/19/2009

ASKER

I believe it does close it, but I really want to know more about this library.

Priest04

3/19/2009

If you have source code, then you can easily look in it.

Sheritlw

3/20/2009

ASKER

Hi Priest,

Like I said before, I have read everything I could find on this subject. I was hoping that an expert could help me figure out how to use this correctly.

Priest04

3/20/2009

An expert would rarely used something that he doesn't have source code for, unless there is not other option. If uou do not have documentation, nor source code, then I suggest you should better stick with some other framework.

ASKER CERTIFIED SOLUTION

Priest04

3/20/2009

THIS SOLUTION IS ONLY AVAILABLE TO MEMBERS.

View this solution by signing up for a free trial.

Members can start a 7-Day free trial and enjoy unlimited access to the platform.

See Pricing Options

Start Free Trial

Priest04

3/20/2009

One thing more: you do not need to instantiate dataset object, this will be done by the ExecuteDataSet method. So, this is enough

Dim ds As DataSet

Open in new window