Solved

css Safari/Firefox problem with td innerHTML move

Posted on 2009-03-29
4
1,206 Views
Last Modified: 2013-12-07
Help! I'm stumped with a css issue working in IE, not in Firefox or Safari - I've got a Javascript function on a discussion forum page which takes form fields from the top of the page, and moves them with the 'innerHTML' property to a table cell next to a post someone is replying to. IE moves the fields no problem to the target table cell, but both Safari and Firefox add the fields to a table cell spanning only the width of the first cell in the table, ignoring the colspan="2" attribute in the target sell. Strange fruit.

My attached code shows the Javascript function and the target rows below in the forum table.

Anyone have any experience with this conundrum? Any help will be greatly appreciated.

Thanks,
Steve


<html><head>
<script language="javascript" type="text/javascript">
function addReply(trID, divID, pID) {
    var oDestDiv = document.getElementById(divID);
    var oDestTr = document.getElementById(trID);
    var oSrcFrm = document.getElementById("frmPost");
    var oSrcDiv;
    if (document.getElementById("hdDivFrm").value == "") {
        oSrcDiv = oSrcFrm;
    } else {
        oSrcDiv = document.getElementById(document.getElementById("hdDivFrm").value);
    }
    document.getElementById("hdDivFrm").value = divID;
    oDestDiv.innerHTML = oSrcDiv.innerHTML;
    oDestTr.style.display = "inline";
    oDestDiv.style.display = "inline";
    if (oSrcDiv != oDestDiv) {
        oSrcDiv.innerHTML = "";
    }
}
</script>
</head>
<body>
<div id="frmPost" style="display:none">
	<table width="100%" border="1" cellspacing="0" cellpadding="3">
	<tr valign="top">
	<td nowrap="nowrap"><p><span class="occ_label">
	Post</span></p></td>
	<td><textarea name="txtPost" rows="10" cols="20" id="txtPost" tabindex="5" class="formStretch"></textarea></td></tr>
 
	<tr><td><p>&nbsp;</p></td>
	<td><a href="javascript:InsUpd_ForumPost();" class="occ_LkButton"
		><span id="btnSubmitpost_lblButton">submit</span></a>
	<a href="javascript:cancelPost();" class="occ_LkButton"><span id="btnCancelpost_lblButton">cancel</span></a>
	</td></tr>
	</table>
</div>
<table>
<tr id="tr1"><td id="div1" colspan="2"><p>&nbsp;</p></td></tr>
 
<tr valign="top"><td style="padding-right:20px;">
<p>Jack Collins</td>
<td><a class="occ_evtLink2" href="javascript:addReply('tr1', 'div1', 63);">[reply]</a>
<p>Text text text text text text text text text text text text text text text text text text text text text 
text text text text text text text text text text text text text text text text text text text text </td></tr>
 
<tr id="tr2"><td id="div2" colspan="2"><p>&nbsp;</p></td></tr>
 
<tr valign="top"><td style="padding-right:20px;">
<p>Jack Collins</td>
<td><a class="occ_evtLink2" href="javascript:addReply('tr2', 'div2', 63);">[reply]</a>
<p>Text text text text text text text text text text text text text text text text text text text text text 
text text text text text text text text text text text text text text text text text text text text </td></tr>
</table>
</body>
</html

Open in new window

0
Comment
Question by:steveOhum
  • 2
4 Comments
 
LVL 5

Accepted Solution

by:
zeroxp earned 500 total points
ID: 24016173
i suppose there's an element with id="hdDivFrm" somewhere on the page.

if you set any element to display:inline, then it will not accept/or inherit width or height. So don't set display:inline to the tr and td:
<html><head>
<script language="javascript" type="text/javascript">
function addReply(trID, divID, pID) {
    var oDestDiv = document.getElementById(divID);
    var oDestTr = document.getElementById(trID);
    var oSrcFrm = document.getElementById("frmPost");
    var oSrcDiv;
    if (document.getElementById("hdDivFrm").value == "") {
        oSrcDiv = oSrcFrm;
    } else {
        oSrcDiv = document.getElementById(document.getElementById("hdDivFrm").value);
    }
    document.getElementById("hdDivFrm").value = divID;
    oDestDiv.innerHTML = oSrcDiv.innerHTML;
    //oDestTr.style.display = "inline";
    //oDestDiv.style.display = "inline";
    if (oSrcDiv != oDestDiv) {
        oSrcDiv.innerHTML = "";
    }
}
</script>
</head>
<body>
<input type="text" id="hdDivFrm" value="frmPost" />
<div id="frmPost" style="display:none">
        <table width="100%" border="1" cellspacing="0" cellpadding="3">
        <tr valign="top">
        <td nowrap="nowrap"><p><span class="occ_label">
        Post</span></p></td>
        <td><textarea name="txtPost" rows="10" cols="20" id="txtPost" tabindex="5" class="formStretch"></textarea></td></tr>
 
        <tr><td><p> </p></td>
        <td><a href="javascript:InsUpd_ForumPost();" class="occ_LkButton"
                ><span id="btnSubmitpost_lblButton">submit</span></a>
        <a href="javascript:cancelPost();" class="occ_LkButton"><span id="btnCancelpost_lblButton">cancel</span></a>
        </td></tr>
        </table>
</div>
<table>
<tr id="tr1"><td id="div1" colspan="2"><p> </p></td></tr>
 
<tr valign="top"><td style="padding-right:20px;">
<p>Jack Collins</td>
<td><a class="occ_evtLink2" href="javascript:addReply('tr1', 'div1', 63);">[reply]</a>
<p>Text text text text text text text text text text text text text text text text text text text text text 
text text text text text text text text text text text text text text text text text text text text </td></tr>
 
<tr id="tr2"><td id="div2" colspan="2"><p> </p></td></tr>
 
<tr valign="top"><td style="padding-right:20px;">
<p>Jack Collins</td>
<td><a class="occ_evtLink2" href="javascript:addReply('tr2', 'div2', 63);">[reply]</a>
<p>Text text text text text text text text text text text text text text text text text text text text text 
text text text text text text text text text text text text text text text text text text text text </td></tr>
</table>
</body>
</html>

Open in new window

0
 
LVL 11

Expert Comment

by:level9wizard
ID: 24017989
I recommend removing <table>'s for content style all together. They are very hard to manage and do things like you're trying to do here. Never use tables for layout. The only case to use tables might be for data, but even still they are awkward.

Also, you're missing a doctype. Doctypes help standardize rendering (by having the browser's native rendering mechanisms come last). See:
http://www.w3.org/QA/2002/04/valid-dtd-list.html
0
 

Author Closing Comment

by:steveOhum
ID: 31564177
Thanks for the solution - I never really knew the difference between 'inline' and 'block', so I guess that clears it up!
0
 

Author Comment

by:steveOhum
ID: 24020865
Thanks, Level9Wizard, for the tips. I'll definitely consider taking your avice.
0

Featured Post

Gigs: Get Your Project Delivered by an Expert

Select from freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely and get projects done right.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Do you come here a lot? Are you lazy like me and don't want to go through the "trouble" of having to click your Dock's Safari icon and then having to click your Experts Exchange Favorites bookmark to get here? Well then this article is for you.
CSS is a visual language used to classify objects and define rules about how they should be displayed. CSS skills aren’t restricted to developers anymore, there is a big benefit to having a basic understanding of the language, regardless of your occ…
In this Micro Tutorial viewers will learn how to create navigation buttons that change on rollover, using CSS (Continuation of the CSS Image Sprite tutorial) Create a parent ID for all the list items       - Specify position: absolute and display: block…
The viewer will receive an overview of the basics of CSS showing inline styles. In the head tags set up your style tags: (CODE) Reference the nav tag and set your properties.: (CODE) Set the reference for the UL element and styles for it to ensu…

816 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now