Solved

Calling replaceChild, works in FF, [Object error] for IE, no error msg but not working in Chromium

Posted on 2009-03-30
7
1,786 Views
Last Modified: 2013-12-08
Dear experts,

The page is rendered in transitional mode.

In the parent page,
<body>
  ...
  <iframe id="child" src="child.html"></iframe>
  <div id="divToReplace">def</div>
  ...
</body>

In the child page,
<head>
  <script language="JavaScript">
    function fillContent() {
      var elemName = new Array("divToReplace");
      var templateElem, realContentElem;
      for (var i = 0; i < elemName.length;i++){
         templateElem = document.getElementById(elemName[i]);
         realContentElem = parent.document.getElementById(elemName[i]);
         if (realContentElem != null) try{templateElem.parentNode.replaceChild(realContentElem,templateElem);}catch(err){alert(err);}
        }
    }
  </script>
</head>
<body onload="fillContent();">
  <div id="divToReplace">abc</div>
</body>

This function gives [Object error] for IE, no error message but not working in Chromium. It only works in FF. Why?

Thanks for your help!
0
Comment
Question by:candychan611
  • 3
  • 2
  • 2
7 Comments
 
LVL 18

Expert Comment

by:wilq32
ID: 24016733
As I remember there was problem in direct moving elements between frames (like replaceChild, appendChild etc.)
Maybe here you will find more informations.

http://bindzus.wordpress.com/2007/12/24/adding-dynamic-contents-to-iframes/
http://www.highdots.com/forums/javascript/how-appendchild-iframes-216238.html

I also had some problems when replacing element from himself - like you have templateElem.parentNode.replaceChild. You can also try to replace it from known node.
0
 

Author Comment

by:candychan611
ID: 24017065
Thanks! They are really nice to read. Therefore can I conclude that the common way perform this task is like the following?
1. instead of replacing, create an element and copy the content from the parent.
2. try to append it from its parent node
3. remove the element in the parent page

And for "replace it from known node". Can I,
var parent = templateElem.parentNode;
parent.replaceChild(...);

Or I must,
ver parent = document.getElementById("parentId");
parent.replaceChild(...);
to totally avoid that problem?
Just curious, as I must know which is the parent node as a designer.
0
 
LVL 18

Expert Comment

by:wilq32
ID: 24017112
Well try this second method. If it wont work - then yes you probably will need to create diffrent element for that. Its not well known problem but as you see this is more complicated than simple adding elements inside one frame/document
0
Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

 
LVL 4

Expert Comment

by:jwmcpeak
ID: 24019654
This code will work in IE6, IE7, IE8, Firefox, Chrome, Opera, and I assume Safari.

There appears to be a bug in IE6 & 7 in that cloned nodes cannot be appended to another document. In the case of those two browsers, you have to recreate the element in the second document.
function fillContent() {

    var elemName = new Array("divToReplace");

    var templateElem, realContentElem;

    for (var i = 0; i < elemName.length;i++){

        templateElem = document.getElementById(elemName[i]);

        realContentElem = parent.document.getElementById(elemName[i]);

        

        if (realContentElem != null) {

            var clone;

            if (typeof Object.defineProperty !== "undefined" || typeof __defineGetter__ !== "undefined") {

                clone = realContentElem.cloneNode(true);

            } else {

                clone = copyElement(realContentElem);

                

            }

            

            realContentElem.parentNode.removeChild(realContentElem);

            templateElem.parentNode.replaceChild(clone, templateElem);

        }

    }

}
 

function copyElement(el) {

    var newEl = document.createElement(el.tagName);

    

    

    // recreate attributes

    for (var i = 0, att; (att = el.attributes[i]) != null; i++) {

        

        if (att.nodeValue) {

            var newAtt = document.createAttribute(att.nodeName);

            newAtt.nodeValue = att.nodeValue;

            el.attributes.setNamedItem(newAtt);

        }

    }

    

    // copy innerHTML   

    newEl.innerHTML = el.innerHTML;

    

    // return new element

    return newEl;

}

Open in new window

0
 

Author Comment

by:candychan611
ID: 24025225
Dear jwmcpeak,

Your code works perfectly in Firefox, Chrome (assume Safari) and should be in IE8 too (no chance to check yet). Thanks!

There is only a small problem in older IEs that need to run the copyElement function. The cloned element appended has lost all css style! This seems strange to me as we have already copied all the attributes.
0
 
LVL 4

Accepted Solution

by:
jwmcpeak earned 250 total points
ID: 24025637
That would be, I'm assuming, because of a typo in copyElement(). I don't have IE 6 or 7 on this machine, so I can't properly test it until Tuesday morning. It should work with the revised copyElement() function below:
function copyElement(el) {

    var newEl = document.createElement(el.tagName);

    

    // recreate attributes

    for (var i = 0, att; (att = el.attributes[i]) != null; i++) {

        if (att.nodeValue) {

            var newAtt = document.createAttribute(att.nodeName);

            newAtt.nodeValue = att.nodeValue;

            // Ooops! 

            // el.attributes.setNamedItem(newAtt);

            newEl.attributes.setNamedItem(newAtt);

        }

    }

    

    // copy innerHTML   

    newEl.innerHTML = el.innerHTML;

    

    // return new element

    return newEl;

}

Open in new window

0
 

Author Closing Comment

by:candychan611
ID: 31564208
WORKS PERFECTLY!
Silly me... unable to find out this by myself,sigh!
0

Featured Post

Highfive Gives IT Their Time Back

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
SharePoint Online Adding A People Picker to Search 14 23
web browser 3 23
Video won't play 5 17
Need a good Angular tutorial 5 32
Have you tried to learn about Unicode, UTF-8, and multibyte text encoding and all the articles are just too "academic" or too technical? This article aims to make the whole topic easy for just about anyone to understand.
SSL stands for “Secure Sockets Layer” and an SSL certificate is a critical component to keeping your website safe, secured, and compliant. Any ecommerce website must have an SSL certificate to ensure the safe handling of sensitive information like…
The viewer will learn how to count occurrences of each item in an array.
The viewer will learn the basics of jQuery including how to code hide show and toggles. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery…

758 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now