Solved

Calling replaceChild, works in FF, [Object error] for IE, no error msg but not working in Chromium

Posted on 2009-03-30
7
1,811 Views
Last Modified: 2013-12-08
Dear experts,

The page is rendered in transitional mode.

In the parent page,
<body>
  ...
  <iframe id="child" src="child.html"></iframe>
  <div id="divToReplace">def</div>
  ...
</body>

In the child page,
<head>
  <script language="JavaScript">
    function fillContent() {
      var elemName = new Array("divToReplace");
      var templateElem, realContentElem;
      for (var i = 0; i < elemName.length;i++){
         templateElem = document.getElementById(elemName[i]);
         realContentElem = parent.document.getElementById(elemName[i]);
         if (realContentElem != null) try{templateElem.parentNode.replaceChild(realContentElem,templateElem);}catch(err){alert(err);}
        }
    }
  </script>
</head>
<body onload="fillContent();">
  <div id="divToReplace">abc</div>
</body>

This function gives [Object error] for IE, no error message but not working in Chromium. It only works in FF. Why?

Thanks for your help!
0
Comment
Question by:candychan611
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
  • 2
7 Comments
 
LVL 18

Expert Comment

by:Pawel Witkowski
ID: 24016733
As I remember there was problem in direct moving elements between frames (like replaceChild, appendChild etc.)
Maybe here you will find more informations.

http://bindzus.wordpress.com/2007/12/24/adding-dynamic-contents-to-iframes/
http://www.highdots.com/forums/javascript/how-appendchild-iframes-216238.html

I also had some problems when replacing element from himself - like you have templateElem.parentNode.replaceChild. You can also try to replace it from known node.
0
 

Author Comment

by:candychan611
ID: 24017065
Thanks! They are really nice to read. Therefore can I conclude that the common way perform this task is like the following?
1. instead of replacing, create an element and copy the content from the parent.
2. try to append it from its parent node
3. remove the element in the parent page

And for "replace it from known node". Can I,
var parent = templateElem.parentNode;
parent.replaceChild(...);

Or I must,
ver parent = document.getElementById("parentId");
parent.replaceChild(...);
to totally avoid that problem?
Just curious, as I must know which is the parent node as a designer.
0
 
LVL 18

Expert Comment

by:Pawel Witkowski
ID: 24017112
Well try this second method. If it wont work - then yes you probably will need to create diffrent element for that. Its not well known problem but as you see this is more complicated than simple adding elements inside one frame/document
0
Don't Cry: How Liquid Web is Ensuring Security

WannaCry is just the start. Read how Liquid Web is protecting itself and its customers against new threats.

 
LVL 4

Expert Comment

by:jwmcpeak
ID: 24019654
This code will work in IE6, IE7, IE8, Firefox, Chrome, Opera, and I assume Safari.

There appears to be a bug in IE6 & 7 in that cloned nodes cannot be appended to another document. In the case of those two browsers, you have to recreate the element in the second document.
function fillContent() {
    var elemName = new Array("divToReplace");
    var templateElem, realContentElem;
    for (var i = 0; i < elemName.length;i++){
        templateElem = document.getElementById(elemName[i]);
        realContentElem = parent.document.getElementById(elemName[i]);
        
        if (realContentElem != null) {
            var clone;
            if (typeof Object.defineProperty !== "undefined" || typeof __defineGetter__ !== "undefined") {
                clone = realContentElem.cloneNode(true);
            } else {
                clone = copyElement(realContentElem);
                
            }
            
            realContentElem.parentNode.removeChild(realContentElem);
            templateElem.parentNode.replaceChild(clone, templateElem);
        }
    }
}
 
function copyElement(el) {
    var newEl = document.createElement(el.tagName);
    
    
    // recreate attributes
    for (var i = 0, att; (att = el.attributes[i]) != null; i++) {
        
        if (att.nodeValue) {
            var newAtt = document.createAttribute(att.nodeName);
            newAtt.nodeValue = att.nodeValue;
            el.attributes.setNamedItem(newAtt);
        }
    }
    
    // copy innerHTML   
    newEl.innerHTML = el.innerHTML;
    
    // return new element
    return newEl;
}

Open in new window

0
 

Author Comment

by:candychan611
ID: 24025225
Dear jwmcpeak,

Your code works perfectly in Firefox, Chrome (assume Safari) and should be in IE8 too (no chance to check yet). Thanks!

There is only a small problem in older IEs that need to run the copyElement function. The cloned element appended has lost all css style! This seems strange to me as we have already copied all the attributes.
0
 
LVL 4

Accepted Solution

by:
jwmcpeak earned 250 total points
ID: 24025637
That would be, I'm assuming, because of a typo in copyElement(). I don't have IE 6 or 7 on this machine, so I can't properly test it until Tuesday morning. It should work with the revised copyElement() function below:
function copyElement(el) {
    var newEl = document.createElement(el.tagName);
    
    // recreate attributes
    for (var i = 0, att; (att = el.attributes[i]) != null; i++) {
        if (att.nodeValue) {
            var newAtt = document.createAttribute(att.nodeName);
            newAtt.nodeValue = att.nodeValue;
            // Ooops! 
            // el.attributes.setNamedItem(newAtt);
            newEl.attributes.setNamedItem(newAtt);
        }
    }
    
    // copy innerHTML   
    newEl.innerHTML = el.innerHTML;
    
    // return new element
    return newEl;
}

Open in new window

0
 

Author Closing Comment

by:candychan611
ID: 31564208
WORKS PERFECTLY!
Silly me... unable to find out this by myself,sigh!
0

Featured Post

PeopleSoft Has Never Been Easier

PeopleSoft Adoption Made Smooth & Simple!

On-The-Job Training Is made Intuitive & Easy With WalkMe's On-Screen Guidance Tool.  Claim Your Free WalkMe Account Now

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

JavaScript can be used in a browser to change parts of a webpage dynamically. It begins with the following pattern: If condition W is true, do thing X to target Y after event Z. Below are some tips and tricks to help you get started with JavaScript …
Boost your ability to deliver ambitious and competitive web apps by choosing the right JavaScript framework to best suit your project’s needs.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.
The viewer will learn the benefit of using external CSS files and the relationship between class and ID selectors. Create your external css file by saving it as style.css then set up your style tags: (CODE) Reference the nav tag and set your prop…

724 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question