Solved

Firebird+Delphi 7 Problem with 0 results found

Posted on 2009-03-31
4
308 Views
Last Modified: 2013-12-09
Hey all,

Provided some code before which I use to update a record in my Firebird database; however, sometimes the main_boost.caption isn't found in the db (which is correct, not every entry is in the db) - and if a record isn't found then nothing should happen, if the record is found however then the Edit/Post procedure should begin.
Lag.close;

Lag.sql.text := 'select * from lag where klubb = '''+main_boost.caption+'''';

Lag.Open;

Lag.First;

Lag.Edit;

Lag['Off'] := inttostr(strtoint(Lag['Off']) - 3);

Lag['Def'] := inttostr(strtoint(Lag['Def']) - 3);

Lag.Post;

end;

Open in new window

0
Comment
Question by:MerlaP83
  • 3
4 Comments
 
LVL 37

Expert Comment

by:Geert Gruwez
ID: 24030698
have you ever heard of a update statement ?


Lag.SQL.Text := 

  'update lag                       '+

  'set Off = Off - 3, Def = Def - 3 '+

  'where klubb = :klubb             ';

Lag.Prepare;

Lag.ParamByName('klubb').AsString := main_boost.caption;

Lag.ExecuteSql;

// number of changed records:

ShowMessage(Format('Affected records: %d ', [Lag.AffectedRecords]));

Open in new window

0
 
LVL 37

Accepted Solution

by:
Geert Gruwez earned 125 total points
ID: 24030721
or


Lag.close;

Lag.sql.text := 'select * from lag where klubb = ' + QuotedStr(main_boost.caption);

Lag.Open;

if not Lag.IsEmpty then 

begin

  Lag.Edit;

  Lag['Off'] := inttostr(strtoint(Lag['Off']) - 3);

  Lag['Def'] := inttostr(strtoint(Lag['Def']) - 3);

  Lag.Post;

end;

Open in new window

0
 

Author Comment

by:MerlaP83
ID: 24030788
Thank you.

Which solution would you prefer?

The first solution gave me Undeclared identifier on Prepare, Parambyname, ExecuteSQL and AffectedRecords (Using Firebird+Zeos). The second solution worked perfect.
0
 
LVL 37

Expert Comment

by:Geert Gruwez
ID: 24030888
well most certainly try and do as many changes with a update statement
don't have zeos here atm, i'll have to check that tomorrow ...
i'm guessing:
ParamByName('X') should be Parameters.ParamByName('X)
ExecuteSql should be Execute
...

but this is for sample 1:
send script to server (some 100 bytes over network)
let server execute script
server returns number of records (some 10 bytes over network)

sample 2:
send script to server (some 100 bytes over network)
server returns the dataset (if any, probably 100 bytes per record)
dataset copies this set to memory
for each record
  you check the record in memory
  you edit the data locally
  you tell the server the record changed (probably 100 bytes per record)
  server returns number of records affected (some 10 bytes over network)

do you understand why you need to go for script 1 ?
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Entering a date in Microsoft Access can be tricky. A typo can cause month and day to be shuffled, entering the day only causes an error, as does entering, say, day 31 in June. This article shows how an inputmask supported by code can help the user a…
Never store passwords in plain text or just their hash: it seems a no-brainier, but there are still plenty of people doing that. I present the why and how on this subject, offering my own real life solution that you can implement right away, bringin…
Video by: Steve
Using examples as well as descriptions, step through each of the common simple join types, explaining differences in syntax, differences in expected outputs and showing how the queries run along with the actual outputs based upon a simple set of dem…
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now