Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

Firebird+Delphi 7 Problem with 0 results found

Posted on 2009-03-31
4
Medium Priority
?
326 Views
Last Modified: 2013-12-09
Hey all,

Provided some code before which I use to update a record in my Firebird database; however, sometimes the main_boost.caption isn't found in the db (which is correct, not every entry is in the db) - and if a record isn't found then nothing should happen, if the record is found however then the Edit/Post procedure should begin.
Lag.close;
Lag.sql.text := 'select * from lag where klubb = '''+main_boost.caption+'''';
Lag.Open;
Lag.First;
Lag.Edit;
Lag['Off'] := inttostr(strtoint(Lag['Off']) - 3);
Lag['Def'] := inttostr(strtoint(Lag['Def']) - 3);
Lag.Post;
end;

Open in new window

0
Comment
Question by:MerlaP83
  • 3
4 Comments
 
LVL 38

Expert Comment

by:Geert Gruwez
ID: 24030698
have you ever heard of a update statement ?


Lag.SQL.Text := 
  'update lag                       '+
  'set Off = Off - 3, Def = Def - 3 '+
  'where klubb = :klubb             ';
Lag.Prepare;
Lag.ParamByName('klubb').AsString := main_boost.caption;
Lag.ExecuteSql;
// number of changed records:
ShowMessage(Format('Affected records: %d ', [Lag.AffectedRecords]));

Open in new window

0
 
LVL 38

Accepted Solution

by:
Geert Gruwez earned 500 total points
ID: 24030721
or


Lag.close;
Lag.sql.text := 'select * from lag where klubb = ' + QuotedStr(main_boost.caption);
Lag.Open;
if not Lag.IsEmpty then 
begin
  Lag.Edit;
  Lag['Off'] := inttostr(strtoint(Lag['Off']) - 3);
  Lag['Def'] := inttostr(strtoint(Lag['Def']) - 3);
  Lag.Post;
end;

Open in new window

0
 

Author Comment

by:MerlaP83
ID: 24030788
Thank you.

Which solution would you prefer?

The first solution gave me Undeclared identifier on Prepare, Parambyname, ExecuteSQL and AffectedRecords (Using Firebird+Zeos). The second solution worked perfect.
0
 
LVL 38

Expert Comment

by:Geert Gruwez
ID: 24030888
well most certainly try and do as many changes with a update statement
don't have zeos here atm, i'll have to check that tomorrow ...
i'm guessing:
ParamByName('X') should be Parameters.ParamByName('X)
ExecuteSql should be Execute
...

but this is for sample 1:
send script to server (some 100 bytes over network)
let server execute script
server returns number of records (some 10 bytes over network)

sample 2:
send script to server (some 100 bytes over network)
server returns the dataset (if any, probably 100 bytes per record)
dataset copies this set to memory
for each record
  you check the record in memory
  you edit the data locally
  you tell the server the record changed (probably 100 bytes per record)
  server returns number of records affected (some 10 bytes over network)

do you understand why you need to go for script 1 ?
0

Featured Post

 [eBook] Windows Nano Server

Download this FREE eBook and learn all you need to get started with Windows Nano Server, including deployment options, remote management
and troubleshooting tips and tricks

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Creating a Cordova application which allow user to save to/load from his Dropbox account the application database.
Creating a Cordova application which allow user to save to/load from his Dropbox account the application database.
In this video, Percona Director of Solution Engineering Jon Tobin discusses the function and features of Percona Server for MongoDB. How Percona can help Percona can help you determine if Percona Server for MongoDB is the right solution for …
In this video, Percona Solution Engineer Rick Golba discuss how (and why) you implement high availability in a database environment. To discuss how Percona Consulting can help with your design and architecture needs for your database and infrastr…

927 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question