• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1149
  • Last Modified:

WPF Memory Leak

Hello every one,
I have encountered a strange situation in my application developed using WPF.
The memory usage in the task manager is gradually increasing and the system is getting creashed.
The memory is gradually incresing as i move from form1 to form 2 using the code on click event
form2 obj=new form2();
obj.someProperty=this.SomeProperty;
this.close();
obj.showDialog();
I'm explicitly killing the objects in form close as its not necessary as we are closing the form.
0
kmsmabu
Asked:
kmsmabu
  • 7
  • 6
1 Solution
 
unmeshdaveCommented:
r u calling form2.close()?
0
 
kmsmabuAuthor Commented:
Hi unmeshdave:
I need to open form2 from form1 and close the form1 object.
If i use form1.close the form1 is getting closed but the memory is not released
0
 
unmeshdaveCommented:
the very simple reason for this is, you are trying to use the thread/memory which is already made free on onclose event. I mean, when you can use form1.hide() instead of close and then when u close form2, you can close form1 as well.
 

  private void button1_Click(object sender, EventArgs e)
        {
            Form2 obj = new Form2(this);
            this.Hide();
            obj.Show();
        }
===========Form2 class=====================
    public partial class Form2 : Form
    {
        Form1 frmPrev;
        public Form2(Form1 frm1)
        {
            InitializeComponent();
            frmPrev = frm1;
        }
 
        private void Form2_FormClosed(object sender, FormClosedEventArgs e)
        {
            frmPrev.Close();
        }
 
    }

Open in new window

0
Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

 
kmsmabuAuthor Commented:
Hi,
The snippet that u hvae placed is abt windows forms.
form1 and form2 are wpf window objects
Even i chkd with ur implimentation My concern is the memory is gradually incresing.I will be opening the forms like
Win1-->Win2--Win3--Win4.......Win20
I close the Win1 and open Win2 though the memory usage in task manager is gradually increasing.
0
 
unmeshdaveCommented:
the reason for memory leak I already told you. you are createing form2 inside handler of form1 and then you release form1 object without releasing form2 becuase you want your form2 to display. So this will never show your form2 and crash your application.
I havent tried this with WPF. but the solution I gave to you will work with WPF. Its about logic not with technology.
0
 
kmsmabuAuthor Commented:
Ya Wat ever u said is reasonalbe.
But the code above
Window1 objNext=new Window1();
objNext.Property=value;
this.close();
objNext.Showdialog();

The Next window is getting showed eventhough i am closing the parent before showdialog()
Even i was amazed by this but its  working in WPF.
At the same time the memory goes on increasing.could you plz help on this
0
 
unmeshdaveCommented:
well I tried with WPF. I am not able to see memory leak with the code u mentioned. I guees u put some more code to understand what exactly you are doing?
show what you are doing in closed event as well.
0
 
kmsmabuAuthor Commented:
In closed event of window i will be assigning the objects to null
Try to have some controls in the both the forms
and navigate from window1 to window2  closing the window1
and from window2 to back to window1 closing the window2
The memory usage 1st when u open Window1 will be lessthan that of when u come from window2 to window1
0
 
unmeshdaveCommented:
I can do it myself but how you are implementing that is important. That is the reason I  am asking for your code. what I notice is not inside application, but even after you close application, CLR takes some time to release memory.
0
 
kmsmabuAuthor Commented:
In main i have an static variable of type window Default.xaml and instance is created in the main and loaded from main as showdialog
I have a default form where i will be loading the other windows onload event i will be calling login page
----Default.xaml------

load--->ShowLogin(null);

public void ShowLogin(Window objParentWin)
        {
            if (objParentWin != null)
            {
                objParentWin.Close();              
            }
            LoginWin m_frmLogin = new LoginWin ();
            m_frmLogin .ShowDialog();
            m_frmLogin = null;
        }

public void ShowEmpInfo(Window objParentWin)
        {
            if (objParentWin != null)
            {
                objParentWin.Close();              
            }
            frmEmpInfo m_frmEmpInfo = new frmEmpInfo();
            m_frmEmpInfo.ShowDialog();
            m_frmEmpInfo = null;
        }

---IN login once credentials re verified iemp info will be shown if user click back button in the screen provided

main.Default.ShowLogin(this);







0
 
kmsmabuAuthor Commented:
In the default i will be having methods for all the windows in the application.
I am unable to find the memory leak as when i come back to login form the memory showed in task mgr for first itme is less than when i come from empindo screen
similar to all windows
0
 
kmsmabuAuthor Commented:
Hi unmeshdave:
Thanks for ur help.
Actually the issue was i was somehow retainig the reference of previous form i chkd in the stack tace and impliemnted a common page from which the forms of application will be loaded closing the previous form
0
 
unmeshdaveCommented:
gud that u got the problem. Actually u can see my comment above with ID: 24041651. I have mentioned same problem.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: CompTIA Cloud+

The CompTIA Cloud+ Basic training course will teach you about cloud concepts and models, data storage, networking, and network infrastructure.

  • 7
  • 6
Tackle projects and never again get stuck behind a technical roadblock.
Join Now