Solved

Access VBA & ADO speed issue

Posted on 2009-03-31
2
204 Views
Last Modified: 2012-06-27
Hi

I am running the following ADO code but the procedure is taking over 10 minutes to finish.

Basically it opens a first recordset to get a user id.  The user id is then used as criteria for a sql string which opens a second recordset based on membership records.  Various tests are performed on the records in the second recordset before this recordset is closed and the next user id is got from the first recordset etc etc

The User table has approx 15000 records whilst the Membership table has approx 27000.

The code works but is slow.  I am fairly new to ADO so my question is simply is there any way I could speed this up by using different cursors or methods

Many thanks

Ken
objcon.Open CurrentProject.Connection
 

        objrst.Open "Users", objcon, adOpenKeyset, adLockOptimistic
 

        

        With objrst
 

        Do Until .EOF = True
 

            lonCurrID = !UserID             
 

          	strSQL2 = "SELECT UserID, StartDate, EndDate, GroupID, TypeID from Membership where UserID = lonCurrID"
 

               objrst2.Open strSQL2, objcon, adOpenKeyset, adLockOptimistic

                   

                        With objrst2

                        

                            	Do Until .EOF = True

                              

                        		select case
 

				<do various tests>
 

			end select                     	    	

                                    

                                	.MoveNext

                            Loop

                        

                        End With

            

                        objrst2.Close
 

            .MoveNext

            Loop
 

        End With
 

        objrst.Close
 

        objcon.Close

Open in new window

0
Comment
Question by:kenabbott
2 Comments
 
LVL 28

Accepted Solution

by:
TextReport earned 250 total points
Comment Utility
Ultimately using SQL would be quicker rather than the way you are doing but it depends on what the TESTS are that you are doing. For example a UPDATE statement with the criteria required would be quicker than walking through the records.
You should be able to do this by creating a single recordset and looping through that rather than 2 recordsets

Hope this makes sense and you can expand on the tests that you are carrying out.

Cheers, Andrew
0
 
LVL 119

Assisted Solution

by:Rey Obrero
Rey Obrero earned 250 total points
Comment Utility
try using the recordcount instead of testing the EOF

dim recCnt1 as integer, recCnt2 as integer,x,j

objrst.movelast
recCnt1=objrst.recordcount
objrst.movefirst

for x=1 to recCnt1




next x


i used this in DAO, and prove to run faster than using .EOF


0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Today's users almost expect this to happen in all search boxes. After all, if their favourite search engine juggles with tens of thousand keywords while they type, and suggests matching phrases on the fly, why shouldn't they expect the same from you…
Experts-Exchange is a great place to come for help with solutions for your database issues, and many problems are resolved within minutes of being posted.  Others take a little more time and effort and often providing a sample database is very helpf…
Familiarize people with the process of utilizing SQL Server stored procedures from within Microsoft Access. Microsoft Access is a very powerful client/server development tool. One of the SQL Server objects that you can interact with from within Micr…
Using Microsoft Access, learn some simple rules for how to construct tables in a relational database. Split up all multi-value fields into single values: Split up fields that belong to other things into separate tables: Make sure that all record…

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now