asked on

xml parsing, output to txt

I have the following code and am trying to output to a file which works but it only grabs the last record in the db and outputs to a txt. It should loop through all records and output all records the the file. also, how would I adjust it so that there is a line break after each record in the txt?

<cfif qOrdersToProcess.recordcount GT 0>
 
<cfloop query=qOrdersToProcess>
<cfset xmlString="#orderString#">
<cfif isXML(xmlString)>
<cfset parsed=XmlParse(xmlString)>
<cfset mystring="">
 
<cfloop from=1 to="#arrayLen(parsed.xmlRoot.Order.xmlChildren)#" step=1 index=i>
<cfset mystring=mystring & #evaluate("parsed.xmlRoot.Order.x#i#.xmlText")# & ','>
</cfloop>
 
<cfset myString = Left(myString, Len(myString)-1)>
<cffile action="write" file="#srcDir#CNV#counter##dateFormat(endDate,'mmdd')#"  output="#mystring#">
 
</cfif>
</cfloop>
 
</cfif>

Open in new window

ASKER CERTIFIED SOLUTION

_agx_

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

_agx_

Also, have you tried using array notation to eliminate the need for evaluate(..)?

<cfset mystring = listAppend(mystring, parsed.xmlRoot.Order["x"& i ].xmlText)>

Mike Waller

ASKER

_agx_, is using an array notation better than what I'm doing? Let me know if you see a better way.

_agx_

Yes, it saves a little extra processing that you really do not need. IMO it is also cleaner code.

(BTW, using listAppend will prevent trailing commas in your variable.)

Mike Waller

ASKER

_agx_, I'm trying to pull back the ids and place them in a ValueList. I've tried this but it pulls back all ids and repeats them for every iteration..

<cfif isXML(xmlString)>
<cfoutput>#ValueList(qOrdersToProcess.id)#</cfoutput>
<cfset updateids = ValueList(qOrdersToProcess.id)>
<cfoutput>#updateids#</cfoutput>
..

Any ideas?

_agx_

Yes, you can't really do that. If you try and combine valueList (all values) with a loop through _individual_ records you are going to get duplicates.

How does this relate to the xml in the original post?

Mike Waller

ASKER

actually, I figured it out.

Mike Waller

ASKER

I just placed an update statment under the cffile statement and that worked.

_agx_

So what did you do differently? Also, is the original question answered as well?

_agx_

> I just placed an update statment under the cffile statement and that worked.

Outside of the loop, yes? Otherwise the update would run many, many times.

Mike Waller

ASKER

Actually, there is one last piece I need to do. I have a isXML statement in there to make that the record is correctly formatted. However, I need to make sure the parent node is a certain value, say "Order". So my xml statement would look like..

<?xml version="1.0" encoding="UTF-8"?><ns1:Order xmlns:ns1="http://www.url.com"><Order><x1>module6-1</x1><x2>module6-2</x2></Order></ns1:Order>

Is there a statement to check for that?

Mike Waller

ASKER

Yes, I placed it outside the loop.

_agx_

> I need to make sure the parent node is a certain value, say "Order"

You are already referencing the parent node here:

.... <cfloop from=1 to="#arrayLen(parsed.xmlRoot.Order.xmlChildren)#"

Mike Waller

ASKER

Ok, but how can I be sure that the parent node is correct? In other words, a third party will be inserted those xml strings into the db so I want to make sure Order is correct and not Orders and so on. Is there a way to check for that?

_agx_

Yes, you can test for the existence of the key "Order". Then do something else if it was not found

<cfif structKeyExists(parsed.xmlRoot, "Order")>
do your existing code here
<cfelse>
"Order" key not found. do something else
</cfif>

Mike Waller

ASKER

_agx_, would that go on the inside or outside of the cfloop?

_agx_

It depends on what you want to do if the key does not exist. But probably Inside the loop, after the isXML check

<cfif isXML(xmlString)>
    <cfset parsed=XmlParse(xmlString)>
    <cfif structKeyExists(parsed.xmlRoot, "Order")>
    ... do the loop and file append here
   </cfif>
</cfif>

Open in new window

Mike Waller

ASKER

Cool, thx _aqx_

Mike Waller

ASKER

Thx