Solved

xml parsing, output to txt

Posted on 2009-04-01
19
198 Views
Last Modified: 2013-12-24
I have the following code and am trying to output to a file which works but it only grabs the last record in the db and outputs to a txt.  It should loop through all records and output all records the the file.  also, how would I adjust it so that there is a line break after each record in the txt?
<cfif qOrdersToProcess.recordcount GT 0>
 

<cfloop query=qOrdersToProcess>

<cfset xmlString="#orderString#">

<cfif isXML(xmlString)>

<cfset parsed=XmlParse(xmlString)>

<cfset mystring="">
 

<cfloop from=1 to="#arrayLen(parsed.xmlRoot.Order.xmlChildren)#" step=1 index=i>

<cfset mystring=mystring & #evaluate("parsed.xmlRoot.Order.x#i#.xmlText")# & ','>

</cfloop>
 

<cfset myString = Left(myString, Len(myString)-1)>

<cffile action="write" file="#srcDir#CNV#counter##dateFormat(endDate,'mmdd')#"  output="#mystring#">
 

</cfif>

</cfloop>
 

</cfif>

Open in new window

0
Comment
Question by:COwebmaster
  • 10
  • 9
19 Comments
 
LVL 52

Accepted Solution

by:
_agx_ earned 500 total points
Comment Utility
Using action="write" overwrites any existing file.  Since you are inside a loop, each iteration overwrites the previous line, leaving only the last line in the query.

Try using append instead:

<cffile action="append" addNewLine="yes"
file="#srcDir#CNV#counter##dateFormat(endDate,'mmdd')#"  
output="#mystring#">
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
Also, have you tried using array notation to eliminate the need for evaluate(..)?

<cfset mystring = listAppend(mystring, parsed.xmlRoot.Order["x"& i ].xmlText)>
0
 

Author Comment

by:COwebmaster
Comment Utility
_agx_, is using an array notation better than what I'm doing?  Let me know if you see a better way.
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
Yes, it saves a little extra processing that you really do not need.  IMO it is also cleaner code.  

 (BTW, using listAppend will prevent trailing commas in your variable.)
0
 

Author Comment

by:COwebmaster
Comment Utility
_agx_, I'm trying to pull back the ids and place them in a ValueList.  I've tried this but it pulls back all ids and repeats them for every iteration..

<cfif isXML(xmlString)>
<cfoutput>#ValueList(qOrdersToProcess.id)#</cfoutput>
<cfset updateids = ValueList(qOrdersToProcess.id)>
<cfoutput>#updateids#</cfoutput>
..

Any ideas?
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
Yes, you can't really do that. If you try and combine valueList (all values) with a loop through _individual_ records you are going to get duplicates.

How does this relate to the xml in the original post?  
0
 

Author Comment

by:COwebmaster
Comment Utility
actually, I figured it out.
0
 

Author Comment

by:COwebmaster
Comment Utility
I just placed an update statment under the cffile statement and that worked.
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
So what did you do differently?  Also, is the original question answered as well?
0
Do You Know the 4 Main Threat Actor Types?

Do you know the main threat actor types? Most attackers fall into one of four categories, each with their own favored tactics, techniques, and procedures.

 
LVL 52

Expert Comment

by:_agx_
Comment Utility
> I just placed an update statment under the cffile statement and that worked.

Outside of the loop, yes? Otherwise the update would run many, many times.
0
 

Author Comment

by:COwebmaster
Comment Utility
Actually, there is one last piece I need to do.  I have a isXML statement in there to make that the record is correctly formatted.  However, I need to make sure the parent node is a certain value, say "Order".  So my xml statement would look like..

<?xml version="1.0" encoding="UTF-8"?><ns1:Order xmlns:ns1="http://www.url.com"><Order><x1>module6-1</x1><x2>module6-2</x2></Order></ns1:Order>

Is there a statement to check for that?                                                            
0
 

Author Comment

by:COwebmaster
Comment Utility
Yes, I placed it outside the loop.
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
> I need to make sure the parent node is a certain value, say "Order"

You are already referencing the parent node here:

 .... <cfloop from=1 to="#arrayLen(parsed.xmlRoot.Order.xmlChildren)#"
0
 

Author Comment

by:COwebmaster
Comment Utility
Ok, but how can I be sure that the parent node is correct?  In other words, a third party will be inserted those xml strings into the db so I want to make sure Order is correct and not Orders and so on.  Is there a way to check for that?
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
Yes, you can test for the existence of the key "Order". Then do something else if it was not found

<cfif structKeyExists(parsed.xmlRoot, "Order")>
      do your existing code here
<cfelse>
      "Order" key not found. do something else
</cfif>
0
 

Author Comment

by:COwebmaster
Comment Utility
_agx_, would that go on the inside or outside of the cfloop?
0
 
LVL 52

Expert Comment

by:_agx_
Comment Utility
It depends on what you want to do if the key does not exist. But probably Inside the loop, after the isXML check

<cfif isXML(xmlString)>

    <cfset parsed=XmlParse(xmlString)>

    <cfif structKeyExists(parsed.xmlRoot, "Order")>

    ... do the loop and file append here

   </cfif>

</cfif>

Open in new window

0
 

Author Comment

by:COwebmaster
Comment Utility
Cool, thx _aqx_
0
 

Author Closing Comment

by:COwebmaster
Comment Utility
Thx
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Suggested Solutions

This is a guide to setting up a new WHM/cPanel Server to be used for web hosting accounts. It is intended for web hosting company administrators and dedicated server owners. For under $99 per month (considering normal rate of Big Data Cetnters like …
If you don't have the right permissions set for your WordPress location in IIS, you won't be able to perform automatic updates. Here's how to fix the problem.
In this seventh video of the Xpdf series, we discuss and demonstrate the PDFfonts utility, which lists all the fonts used in a PDF file. It does this via a command line interface, making it suitable for use in programs, scripts, batch files — any pl…
This video gives you a great overview about bandwidth monitoring with SNMP and WMI with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're looking for how to monitor bandwidth using netflow or packet s…

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now