Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 854
  • Last Modified:

Convert an Array to a String or StreamReader??

I know this sounds far fetched but here's what I would like to do.
I would like to pass a text file (i.e. ProofOfConcept -f c:\data.txt) into a Console app called ProofOfConcept as an argument. Next I would like to take that one Argument in the string[] args Array, and pass it into a StreamReader to open that file up, and , eventually store all the data in that pass in file to an Array or ArrayList. (Uncompleted code below)
Is there some way to do this?
Thank you for your time and expertise,
Wally
static void Main(string[] args)
        {
List<Program> nodeList = new List<Program>();
            List<string> workstations;
 
            StreamReader sr = new StreamReader();
            args.
 
            int idx = Array.IndexOf(args, "-f");
            string filename = "";
            if (idx != 1)
            {
                filename = args[idx + 1];
            }
 
            if (args.Length > 0)
            {
                // Load command line arg into List<string> collection
                // assuming comma-seperated values
                workstations = new List<string>(filename.Split(','));
                foreach (string wkstn in workstations)
                {
                    Program node = new Program();
                    node.NodeToPing = wkstn;
                    nodeList.Add(node);
                }
 
            }

Open in new window

0
wally_davis
Asked:
wally_davis
1 Solution
 
Carl TawnSystems and Integration DeveloperCommented:
Try this:
            List<string> workstations = new List<string>();
 
            int idx = Array.IndexOf(args, "-f");
            string filename = "";
 
            if (idx != -1)
            {
                filename = args[idx + 1];
 
                if (System.IO.File.Exists(filename))
                {
                    System.IO.FileStream fs = new System.IO.FileStream(filename, System.IO.FileMode.Open, System.IO.FileAccess.Read);
 
                    using (System.IO.StreamReader sr = new System.IO.StreamReader(fs))
                    {
                        string line;
 
                        while ((line = sr.ReadLine()) != null)
                        {
                            workstations.Add(line);
                        }
                    }
                }
            }

Open in new window

0
 
Fernando SotoCommented:
Hi wally_davis;

The code sample below shows a way of doing what you want.

Fernando
using System;
using System.Collections.Generic;
using System.Text;
using System.IO;
 
namespace ConsoleApplication4
{
    class Program
    {
 
        private static List<string> workstations = new List<string>();
 
        static void Main(string[] args)
        {
            //Check to see if the command line parameter length = 2, one for -f the other the filename
            if (args.Length == 2)
            {
                // Check to see if the parameter is -f
                if (args[0] != "-f")
                {
                    // It was not -f, display message and exit.
                    Console.WriteLine("Input option error, no such option as " + args[0] + " \nHit any key to continue.");
                    Console.ReadLine();
                }
                else
                {
                    // It was -f and now check to see if the file exist
                    if( File.Exists(args[1]) )
                    {
                        // The file was found, fill the workstations list with its values
                        workstations.AddRange(File.ReadAllLines(args[1]));
                    }
                }
            }
            else
            {
                // Invalid number of command line parameters were found
                if (args.Length == 0)
                {
                    Console.WriteLine("Workstation file was NOT provided as an input parameter.");
                }
                else
                {
                    Console.WriteLine("Too many input parameter were provided.");
                }
                Console.Write("Hit any key to cotinue");
                Console.ReadLine();
                return;
            }
 
            // Display Workstation list
            foreach (string ws in workstations)
            {
                Console.WriteLine(ws);
            }
 
            // Keep the application open while I read the screen
            Console.ReadLine();
        }
    }
}

Open in new window

0
 
MarkGMurphyCommented:
Wally,
I notice you have a "-f" passed as an argument in addition to your filename.  Will you want to identify the filename by argument position?  If not, you can use a switch to identify multiple arguments of different types (i.e. ProofOfConcept /f:true /i:c:\data.txt).
I take it you are passing in a list of machine names or IP addresses you wish to act on in some way.  Please confirm these details and I will reply with some code for you.
Thanks,
Mark
0
NFR key for Veeam Agent for Linux

Veeam is happy to provide a free NFR license for one year.  It allows for the non‑production use and valid for five workstations and two servers. Veeam Agent for Linux is a simple backup tool for your Linux installations, both on‑premises and in the public cloud.

 
wally_davisAuthor Commented:
Hi Carl/Guys, This is almost a done deal.
See code below. The data that is being collected in the "nodeList.Add(node);" List<> Collection is getting lost. I'm passing in a Text file (c:\data.txt) using the Properties\Debug\Command Line arguments section.
In that file are 3 workstations. Everything in the code you provided Carl is great until it gets to the
"if (nodeList.Count > 0)" statement. <-- Right here, there are no workstations stored in the ListArray after it exits the "While" routine. For whatever reason, the values are getting lost. Thanks again for all your help.

if (idx != 1)
            {
                filename = args[idx + 1];
                filename.ToUpper();
 
                if (File.Exists(filename))
                {
                    FileStream fs = new FileStream(filename, FileMode.Open, FileAccess.Read);
                    using (StreamReader sr = new StreamReader(fs))
                    {
                        Program node = new Program();
                        while ((node.NodeToPing = sr.ReadLine()) != null)
                        {
                            nodeList.Add(node);
                        }
                    }
                }
 
 
                if (nodeList.Count > 0)
                {
                    System.Threading.ThreadPool.SetMaxThreads(65, 10);
                    System.Threading.ThreadPool.SetMinThreads(65, 10);
 
                    foreach (Program node in nodeList)
                    {
                        System.Threading.ThreadPool.QueueUserWorkItem(new System.Threading.WaitCallback(PingWorkstations), node.NodeToPing);
                    }
                }
            }

Open in new window

0
 
wally_davisAuthor Commented:
Sorry, left the List<> Collections out but its in the code.

List<Program> nodeList = new List<Program>();
List<string> workstations = new List<string>();
0
 
Carl TawnSystems and Integration DeveloperCommented:
Where are you declaring nodeList?
0
 
Carl TawnSystems and Integration DeveloperCommented:
Have you stepped through the code using the debugger to see if it is actually reading anything from the file and adding nodes to the list?
0
 
wally_davisAuthor Commented:
yes, I stepped through the code and its storing them there but once out of that WHILE Loop it appears to drop all of the element values.
0
 
Carl TawnSystems and Integration DeveloperCommented:
There must be something odd going on because, as long as the file contains data, there should be something in the list.

You do however have another issue with your code, in that you only instantiate Program once, so each time you set the NodeToPing property and add the node to the List you are in fact altering a single instance and adding it multiple times to the list.

Your loop should be more like the following. Try this first and let us know if the list still says it is empty:


                if (File.Exists(filename))
                {
                    FileStream fs = new FileStream(filename, FileMode.Open, FileAccess.Read);
                    using (StreamReader sr = new StreamReader(fs))
                    {
                        string line;
                        while ((line = sr.ReadLine()) != null)
                        {
                            Program node = new Program();     // create a new instance otherwise we'll just be modifying the same object each time
                            node.NodeToPing = line;
     
                            nodeList.Add(node);
                        }
                    }
                }

Open in new window

0
 
wally_davisAuthor Commented:
Carl, that made perfect sense and moving the instation called to Program did the trick. The code now works except that the multithreading piece is not working but that's another problem in and of itself.
0

Featured Post

How to Use the Help Bell

Need to boost the visibility of your question for solutions? Use the Experts Exchange Help Bell to confirm priority levels and contact subject-matter experts for question attention.  Check out this how-to article for more information.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now