MonthCalendar and DataGridView - Very Slow Loading.

I have a DataGridView with several columns.  If a user selects a cell in the date column a monthCalendar control appears at that location.  

My issue is that it is extremely slow (it appears fast, but attempting to select a date seems to take a long time).  I have used the exact same code (posted below) for a textBox click event and it works perfectly fast.  Does anybody know what may be wrong?

if (dataGridView.CurrentRow.Cells["transactionDate"].Selected)
                    {
                        monthCalendar.Visible = true;
                        monthCalendar.Top = 40;
                        monthCalendar.Left = 50;
                        monthCalendar.BringToFront();
                        monthCalendar.Capture = true;
                        while (monthCalendar.Visible == true)
                        {
                            Application.DoEvents();
                        }
                        dataGridView.CurrentRow.Cells["transactionDate"].Value = _accountDate;
                        return;
                    }
 
 private void monthCalendar_MouseUp(object sender, MouseEventArgs e)
        {
            switch (monthCalendar.HitTest(e.Location).HitArea)
            {
                case MonthCalendar.HitArea.Date:
                    monthCalendar.Visible = false;
                    break;
                case MonthCalendar.HitArea.NextMonthDate:
                    break;
                case MonthCalendar.HitArea.PrevMonthDate:
                    break;
            }
            _accountDate = monthCalendar.SelectionStart.ToShortDateString();
        }

Open in new window

LVL 15
angus_young_acdcAsked:
Who is Participating?
 
oobaylyConnect With a Mentor Commented:
Well, when you add the CalendarColumn to your project, it should appear in your list of available column types when editing the columns for a DataGridView, so editing them should be pretty easy, and you could dump the DataGridViewTextBoxColumn that is currently displaying the date.

Fair enough about using the date as a string if the datasource is xml, though I tend to do the conversions when loading and saving my tables, so any controls have the datatype that they expect. I suppose it's personal preference.

I'd use if instead of switch as your only checking for a single case. If you were handling any other HitArea then I'd definitely use a switch statement. Again, it's personal preference as I find it easier to read.
0
 
oobaylyCommented:
I'd suggest using a custom DataGridViewColumn that hosts a DateTimePicker control, once you've created it, it can be used all over the place with very little code.

This MSDN article explains how to do it. Once you understand how it works, it's simple to create a whole host (no pun intended) of custom columns. So far I've got a DateTimePicker column, a NumericUpDown column and a column that allows editing of binary data by displaying it as a hex string.

http://msdn.microsoft.com/en-us/library/7tas5c80.aspxhttp://msdn.microsoft.com/en-us/library/7tas5c80.aspx
0
 
angus_young_acdcAuthor Commented:
In the example provided it is adding the CalendarColumn to the grid as a new column.  How can I assign the custom class to a column that already exists?  Or how can I actually use this?  I currently have lots of code for the other columns and seems like a re-write would be required.
0
Cloud Class® Course: Microsoft Office 2010

This course will introduce you to the interfaces and features of Microsoft Office 2010 Word, Excel, PowerPoint, Outlook, and Access. You will learn about the features that are shared between all products in the Office suite, as well as the new features that are product specific.

 
oobaylyCommented:
Well, presuming that your columns are autogenerated when binding to a datatable, you can just add the following code:
It uses the same header text and dataproperty as the original column that contains a date, inserts itself in the same position, and then hides the original.

As for your code, I'm guessing it's to do with the while loop. Why not remove the loop, and set the column's date after you hide the Calendar control:
dataGridView.CurrentRow.Cells["transactionDate"].Value = monthCalendar.SelectionStart;

Why are you converting the date selected by the user to a string, is the Date column not DateTime?
You're only testing for one hittest type, so why use switch?
// Using Calendar column
      DataGridViewColumn autoGenDateCol = dataGridView1.Columns["Date Column"];
      CalendarColumn  calendarCol = new CalendarColumn ();
      calendarCol.HeaderText = autoGenDateCol.HeaderText;
      calendarCol.DataPropertyName = autoGenDateCol.DataPropertyName;
      calendarCol.Name = "Date Column2";
      dataGridView1.Columns.Insert(autoGenDateCol.Index, calendarCol);
      autoGenDateCol.Visible = false;
 
// Your modified code
if (dataGridView.CurrentRow.Cells["transactionDate"].Selected)
                    {
                        monthCalendar.Visible = true;
                        monthCalendar.Top = 40;
                        monthCalendar.Left = 50;
                        monthCalendar.BringToFront();
                        monthCalendar.Capture = true;
                        dataGridView.Enabled = false;
                        return;
                    }
 
 private void monthCalendar_MouseUp(object sender, MouseEventArgs e)
        {
            if (monthCalendar.HitTest(e.Location).HitArea == MonthCalendar.HitArea.Date){
              dataGridView.CurrentRow.Cells["transactionDate"].Value = monthCalendar.SelectionStart;
              monthCalendar.Visible = false;
              dataGridView.Enabled = true;
            }
        }

Open in new window

0
 
angus_young_acdcAuthor Commented:
Hi oobayly

Unfortunately not, they have been created just via Edit Columns as there is no real binding, it's taking a value from XML to populate the table.  

Good idea about hiding after populating the date, shall try that out now.  

I'm converting the date to a string as that's just the way it is read/written to the XML, so just seemed easier (albeit uglier) rather than just converting it later.

As for the switch... I'm not sure, should I just change it to an if statement for the HitArea.Date?
0
 
angus_young_acdcAuthor Commented:
Hi again,

I have tried that code but unfortunately I can't seem to get it working correctly.  I'm either getting a null reference exception or an invalid cast exception.

They all happen here:

 public override void InitializeEditingControl(int rowIndex, object
            initialFormattedValue, DataGridViewCellStyle dataGridViewCellStyle)
        {
            // Set the value of the editing control to the current cell value.
            base.InitializeEditingControl(rowIndex, initialFormattedValue,
                dataGridViewCellStyle);
            CalendarEditingControl ctl =
                DataGridView.EditingControl as CalendarEditingControl;
            ctl.Value = (DateTime)this.Value;  // Exception thrown
        }
0
 
angus_young_acdcAuthor Commented:
Got it working by removing code and doing a bit of a hack.  Also it is a lot faster (most likely due to your suggestion about the loop).  Thanks a lot1
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.