Solved

VBScript: How do I run a command that contains a object or variable?

Posted on 2009-04-07
10
342 Views
Last Modified: 2012-05-06
I am trying to write a script that will help me to copy a large number of USB Disks.  I have most of the code written but having trouble w/ a small section.  I need to run a command that uses one of output from a WMI query.  I have option explicit turned on and have "Dim'd" all necessary variables.

      formatUSB = "cmd /c format " & objItem.DeviceID, "/FS:NTFS /Q"
      WScript.Echo "Formatting USB Drive..."
      Set objShell = CreateObject ("WScript.Shell")
      Set objExec2 = objShell.Exec (formatUSB)

When I run this script, I get Expected ')" or Expected end of statement.  Is this possible to do?
0
Comment
Question by:jleleux
  • 6
  • 3
10 Comments
 
LVL 67

Expert Comment

by:sirbounty
ID: 24089524
remove the comma (,) after DeviceID
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24089527

formatUSB = "cmd /c format " & objItem.DeviceID " /FS:NTFS /Q"

      WScript.Echo "Formatting USB Drive..."

      Set objShell = CreateObject ("WScript.Shell")

      Set objExec2 = objShell.Exec (formatUSB)

Open in new window

0
 
LVL 38

Expert Comment

by:Shift-3
ID: 24089569
You'll need another ampersand in there too.
 

formatUSB = "cmd /c format " & objItem.DeviceID & " /FS:NTFS /Q"

Open in new window

0
 
LVL 1

Author Comment

by:jleleux
ID: 24090523
Now I get the following error:

Microsoft VBScript runtime error: Object required: ''
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24090536
try this - if the error persists, please indicate which line throws the error.
formatUSB = "cmd /c format " & objItem.DeviceID & " /FS:NTFS /Q"

WScript.Echo "Formatting USB Drive..."

Set objShell = CreateObject ("WScript.Shell")

Set objExec2 = objShell.Exec (formatUSB)

Open in new window

0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 1

Author Comment

by:jleleux
ID: 24090584
Here is the whole program, this might be more helpful.  The error is happening on line 38, col 2.

Option Explicit
'On Error Resume Next
Dim strComputer
Dim objWMIService
Dim colItems
Dim objItem
Dim copyDev
Dim formatUSB
Dim choice
Dim objShell
Dim objExec1
Dim objExec2

Const wbemFlagReturnImmediately = &h10
Const wbemFlagForwardOnly = &h20
Const DriveType = 2

strComputer = "."
   WScript.Echo
   Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\CIMV2")
   Set colItems = objWMIService.ExecQuery("SELECT * FROM Win32_LogicalDisk where DriveType =" & DriveType, _
                                         "WQL",wbemFlagReturnImmediately + wbemFlagForwardOnly)
     
Do
      For Each objItem In colItems
          WScript.Echo "DeviceID: " & objItem.DeviceID
          WScript.Echo "VolumeName: " & objItem.VolumeName
      'If objItem.VolumeName Or objItem.DeviceID    
      Next
      
      ' Copy Microsoft DevCon utility
      copyDev = "cmd /c xcopy P:\Software\Miscellaneous\devcon.exe c:\windows\system32 /y"
      WScript.Echo "Copying needed utility..."
      Set objShell = CreateObject ("WScript.Shell")
      Set objExec1 = objShell.Exec (copyDev)
      
      ' Format Drive
      formatUSB = "cmd /c format " & objItem.DeviceID & " /FS:NTFS /Q"
      WScript.Echo "Formatting USB Drive..."
      Set objShell = CreateObject ("WScript.Shell")
      Set objExec2 = objShell.Exec (formatUSB)
      
      
      ' Asks the user if they want to copy another drive or exit the script.
      WScript.StdOut.Write "Do you want to copy another drive? (y/n)"
      choice = WScript.StdIn.ReadLine
Loop While choice = "y" Or choice = "Y"
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24090652
yep, it's your objitem - I'll clean up the script for you...
0
 
LVL 67

Accepted Solution

by:
sirbounty earned 500 total points
ID: 24090690
Try this - unless there's more to it, there was some code that was either redundant or unnecessary...
Option Explicit

'On Error Resume Next
 

Const wbemFlagReturnImmediately = &h10

Const wbemFlagForwardOnly = &h20

Const DriveType = 2

Dim objExec, objDrive, strCommand, strDrive, choice
 

Dim objShell : Set objShell = CreateObject ("WScript.Shell")

Dim objWMIService : Set objWMIService = GetObject("winmgmts:\\.\root\CIMV2")

Dim colItems : Set colItems = objWMIService.ExecQuery("SELECT * FROM Win32_LogicalDisk where DriveType =" & DriveType, _

                                         "WQL",wbemFlagReturnImmediately + wbemFlagForwardOnly)
 

DevConCopy 'no need to repeat per loop?
 

Dim objItem      

Do 

  For Each objItem In colItems

    WScript.Echo "DeviceID: " & objItem.DeviceID

    WScript.Echo "VolumeName: " & objItem.VolumeName

    FormatDrive (objItem.DeviceID)

  Next

 

  ' Asks the user if they want to copy another drive or exit the script.

  WScript.StdOut.Write "Do you want to copy another drive? (y/n)"

  choice = WScript.StdIn.ReadLine

Loop While choice = "y" Or choice = "Y"
 

Sub FormatDrive (strDrive)  ' Format Drive

  strCommand = "cmd /c format " & strDrive & " /FS:NTFS /Q"

  WScript.Echo "Formatting USB Drive..."

  objShell.Run strCommand

End Sub
 

Sub DevConCopy()  ' Copy Microsoft DevCon utility

  strCommand = "cmd /c xcopy P:\Software\Miscellaneous\devcon.exe c:\windows\system32 /y"

  WScript.Echo "Copying needed utility..."

  objShell.Run strCommand

End Sub

Open in new window

0
 
LVL 1

Author Closing Comment

by:jleleux
ID: 31567615
Thanks all for helping a noob scripter!!!!  I really appreciate!!!!
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24090945
Glad I could lend a hand - thanx for the grade! :^)
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Well hello again!  Glad to see you've made it this far without giving up.  In this, the fourth installment of my popular series, I'm going to cover functions and subroutines, what they are, and why they are useful.  Just in case you stumbled onto th…
When it comes to writing scripts for a Client/Server computing environment it is essential to consider some way of enabling the authentication functionality within a script. This sort of consideration mainly comes into the picture when we are dealin…
This video demonstrates how to create an example email signature rule for a department in a company using CodeTwo Exchange Rules. The signature will be inserted beneath users' latest emails in conversations and will be displayed in users' Sent Items…
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …

947 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now