• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1705
  • Last Modified:

C-sharp How to Find the biggest integer?

I just started coding and iam doing c-sharp first. So far all i know is If and else statements. I am trying to figure out a way to find the biggest integer out of 5 integers the user inputs. My problem is that i cant get it to work here is my code:

Whenever the first integer is bigger then the second integer that i have inputted the code messes up. It assigns biggest to the first integer and it does not check the rest.

How do i fix that?

i tried adding more if statements that checked 1 vs 3 and 1 vs 4 1vs5 but i either did not do it correctly or it did not work that way...
using System;
using System.Collections.Generic;
using System.Text;
 
namespace Ch3
{
    class ch3practice
    {
        static void Main(string[] args)
        {
            int number1, number2, number3, number4, number5;
            int biggest = 0;
           
            // initialize the integers
 
            Console.Write("Integer please:  ");
            //promt for integer
            number1 = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number2 = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number3 = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number4 = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number5 = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");           
          
            //check 1v2
            if (number1 >= number2)
              
                biggest = number1;
            else 
 
            if (number2 >= number3)
                                    biggest = number2;
                                else
                                    if (number3 >= number4)
                                        biggest = number3;
                                    else
                                        if (number4 >= number5)
                                            biggest = number4;
                                        else
                                            if (number5 >= number1)
                                                biggest = number5;
                           
            
                
   
 
         Console.WriteLine("{0}  Is the bigest #", biggest );                
            Console.ReadLine();
 
        }
    }
}

Open in new window

0
Bulg
Asked:
Bulg
1 Solution
 
CebikCommented:
try this :)

using System;
using System.Collections.Generic;
using System.Text;
 
namespace ConsoleApplication1
{
    class Program
    {
        static void Main(string[] args)
        {
            List<int> values = new List<int>();
 
            while (true)
            {
                Console.Write("\nEnter value " + (values.Count + 1).ToString() + " :");
                string inputValue = Console.ReadLine();
 
                if (inputValue == "")
                    break;
 
                int value;
                if (int.TryParse(inputValue, out value) == false)
                    continue;
 
                values.Add(value);
            }
 
            int bigest = int.MinValue;
            foreach (int i in values)
                if (i > bigest)
                    bigest = i;
 
            Console.WriteLine("\n\nThe bigest number is: " + bigest.ToString());
            Console.ReadLine();
        }
    }
}

Open in new window

0
 
CebikCommented:
in yout example will be

if (number1 > bigest) bigest = number1;
if (number2 > bigest) bigest = number2;
if (number3 > bigest) bigest = number3;
(...)
if (numberN> bigest) bigest = numberN;

Open in new window

0
 
CebikCommented:
but... at the begining add

bigest = int.MinValue;

Open in new window

0
Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

 
BulgAuthor Commented:
show me an example please i can only use if and else statements so far ;/ thats why the first code is of no use to me.

added a few more lines but it doesn't work ;/
using System;
using System.Collections.Generic;
using System.Text;
 
namespace Ch3
{
    class ch3practice
    {
        static void Main(string[] args)
        {
            int number1, number2, number3, number4, number5;
            int biggest = 0;
 
 
           
 
            // initialize the integers
 
            Console.Write("Integer please:  ");
            //promt for integer
            number1 = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number2 = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number3 = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number4 = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number5 = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");           
          
            //check 1v2
            if (number1 >= number2)
              
                biggest = number1;
            
            else 
 
            if (number2 >= number3)
                                    biggest = number2;
                                else
                                    if (number3 >= number4)
                                        biggest = number3;
                                    else
                                        if (number4 >= number5)
                                            biggest = number4;
                                        else
                                            if (number5 >= number1)
                                                biggest = number5;
                            if (biggest <=number3 )
                                biggest = number3;
                            if (number4 >= biggest)
                                biggest = number4;
                            if (number4 >= biggest)
                                biggest = number5;
            
                
   
 
         Console.WriteLine("{0}  Is the bigest #", biggest );                
            Console.ReadLine();
 
        }
    }
}

Open in new window

0
 
DaRakNaCommented:
Try to use this:
using System;
using System.Collections.Generic;
using System.Text;
 
namespace Ch3
{
    class ch3practice
    {
        static void Main(string[] args)
        {
            int number[6];
            int biggest = 0;
           
            // initialize the integers
 
            Console.Write("Integer please:  ");
            //promt for integer
            number[1] = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number[2] = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number[3] = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number[4] = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number[5] = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");           
          
            //check 
            for(int i=1;i<=5;i++)
               {
                  if(number[i]>biggest)
                     {
                         biggest=number[i];i=1;
                     }
               }
         Console.WriteLine("{0}  Is the bigest #", biggest );                
            Console.ReadLine();
 
        }
    }
}

Open in new window

0
 
CebikCommented:
fixed your mistakes

static void Main(string[] args)
        {
            int[] number = new int[6];
            int biggest = 0;
           
            // initialize the integers
 
            Console.Write("Integer please:  ");
            //promt for integer
            number[0] = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number[1] = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number[2] = Convert.ToInt32(Console.ReadLine());
            //take integer 
            Console.Write("Integer please:  ");
            //promt for integer
            number[3] = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");
            Console.Write("Integer please:  ");
            //promt for integer
            number[4] = Convert.ToInt32(Console.ReadLine());
            //take integer Console.Write("Integer please");           
          
            //check 
            for(int i=0;i<number.Length;i++)
            {
              if(number[i]>biggest)
                     biggest=number[i];i=1;
            }
 
           Console.WriteLine("{0}  Is the bigest #", biggest );                
           Console.ReadLine();
 
        }

Open in new window

0
 
CebikCommented:
Bulg:


static void Main(string[] args)
{
    int number1, number2, number3, number4, number5;
   
    // initialize the integers
 
    Console.Write("Integer please:  ");
    //promt for integer
    number1 = Convert.ToInt32(Console.ReadLine());
    //take integer 
    Console.Write("Integer please:  ");
    //promt for integer
    number2 = Convert.ToInt32(Console.ReadLine());
    //take integer Console.Write("Integer please");
    Console.Write("Integer please:  ");
    //promt for integer
    number3 = Convert.ToInt32(Console.ReadLine());
    //take integer 
    Console.Write("Integer please:  ");
    //promt for integer
    number4 = Convert.ToInt32(Console.ReadLine());
    //take integer Console.Write("Integer please");
    Console.Write("Integer please:  ");
    //promt for integer
    number5 = Convert.ToInt32(Console.ReadLine());
    //take integer Console.Write("Integer please");           
  
    int biggest = int.MinValue;
    if (number1 > biggest)
        biggest = number1;
    if (number2 > biggest)
        biggest = number2;
    if (number3 > biggest)
        biggest = number3;
    if (number4 > biggest)
        biggest = number4;
    if (number5 > biggest)
        biggest = number5;
       
 Console.WriteLine("{0}  Is the bigest #", biggest );                
    Console.ReadLine();
 
}

Open in new window

0
 
CebikCommented:
but in my post id: 24091592 is if statement in line 30...
this is much more better solution..
0
 
zultiCommented:
I would change line 28 in Cebik's answer to be
28:     int biggest = number1 ;

and you can remove lines 29 and 30
other than that this is the answer you asked for.....
0
 
CebikCommented:
shure... can be in this way also..
0
 
CebikCommented:

static void Main(string[] args)
{
    int number1, number2, number3, number4, number5;
   
    // initialize the integers
 
    Console.Write("Integer please:  ");
    //promt for integer
    number1 = Convert.ToInt32(Console.ReadLine());
    //take integer 
    Console.Write("Integer please:  ");
    //promt for integer
    number2 = Convert.ToInt32(Console.ReadLine());
    //take integer Console.Write("Integer please");
    Console.Write("Integer please:  ");
    //promt for integer
    number3 = Convert.ToInt32(Console.ReadLine());
    //take integer 
    Console.Write("Integer please:  ");
    //promt for integer
    number4 = Convert.ToInt32(Console.ReadLine());
    //take integer Console.Write("Integer please");
    Console.Write("Integer please:  ");
    //promt for integer
    number5 = Convert.ToInt32(Console.ReadLine());
    //take integer Console.Write("Integer please");           
  
    biggest = number1;
    if (number2 > biggest)
        biggest = number2;
    if (number3 > biggest)
        biggest = number3;
    if (number4 > biggest)
        biggest = number4;
    if (number5 > biggest)
        biggest = number5;
       
    Console.WriteLine("{0}  Is the bigest #", biggest);                
    Console.ReadLine();
}

Open in new window

0
 
CebikCommented:
sorry...
line 28

int biggest = number1;

Open in new window

0
 
BulgAuthor Commented:
Thank you. It makes perfect seance. Sometimes the simplest things get me.
0

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Tackle projects and never again get stuck behind a technical roadblock.
Join Now