Solved

VB.net Loop problem with executereader

Posted on 2009-04-08
2
538 Views
Last Modified: 2013-11-27
I import a csv file into a dataset and then I want to take this information from this dataset and import it to my database. It runs over the first row but then it states:

"Error: System.Data: There is already an open DataReader associated with this Command which must be closed first"

I added cmdstudent.executereader.close() in the loop but it still does not work.

Any suggestions?
Private Sub btn1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btn1.Click

 

        Dim conn As SqlConnection

        Dim cmdStudent As New SqlCommand

        Dim cmdStudent1 As New SqlCommand

        Dim daStudent As New SqlDataAdapter

        Dim dsStudent As New DataSet

        Dim dtStudent As New DataTable

 

        Dim ds1 As New DataSet

        Dim sCon As String = "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=c:\;Extended Properties=Text;"

        Dim objConn As New OleDbConnection(sCon)

 

        objConn.Open()

 

        Dim objCmdSelect As New OleDbCommand("SELECT * FROM daily.csv", objConn)

 

        Dim objAdapter1 As New OleDbDataAdapter

 

        objAdapter1.SelectCommand = objCmdSelect

 

        objAdapter1.Fill(ds1, "daily")

 

        DGV1.DataSource = ds1.Tables(0).DefaultView()

 

        objConn.Close()

 

        Dim i As Integer

 

        Try

            conn = GetConnect()

            conn.Open()

 

 

            For i = 0 To (ds1.Tables(0).Rows.Count - 1)

                cmdStudent = conn.CreateCommand

                cmdStudent.CommandText = "INSERT INTO dailyrounds (date,name,price,no,url,high,highnum,mid,midnum,low,lownum)" & _

                   "VALUES ('" & Date.Today & "','" & _

                   ds1.Tables(0).Rows(i)("name") & "'," & _

                   ds1.Tables(0).Rows(i)("price") & "," & _

                   ds1.Tables(0).Rows(i)("no") & ",'" & _

                   ds1.Tables(0).Rows(i)("url") & "','" & _

                   ds1.Tables(0).Rows(i)("high") & "'," & _

                   ds1.Tables(0).Rows(i)("highnum") & ",'" & _

                   ds1.Tables(0).Rows(i)("mid") & "'," & _

                   ds1.Tables(0).Rows(i)("midnum") & ",'" & _

                   ds1.Tables(0).Rows(i)("low") & "'," & _

                   ds1.Tables(0).Rows(i)("lownum") & ") "

 

                cmdStudent.ExecuteReader.Read()

                cmdStudent.ExecuteReader.Close()

            Next i

 

            Refresh_Form()

            conn.Close()

 

        Catch ex As Exception

            MsgBox("Error: " & ex.Source & ": " & ex.Message, MsgBoxStyle.OkOnly, "Connection Error !!")

        End Try

 

    End Sub

Open in new window

0
Comment
Question by:ralphcarter2008
2 Comments
 
LVL 16

Accepted Solution

by:
sunithnair earned 500 total points
Comment Utility
I think your line number 50 should be cmdStudent.ExecuteNonQuery() since you are trying to insert the values into a database table. ExecuteReader is just for reading the data and ExecuteNonQuery is used for DML queries.
0
 
LVL 1

Author Closing Comment

by:ralphcarter2008
Comment Utility
Good catch!!
0

Featured Post

Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

Join & Write a Comment

Introduction In a recent article (http://www.experts-exchange.com/A_7811-A-Better-Concatenate-Function.html) for the Excel community, I showed an improved version of the Excel Concatenate() function.  While writing that article I realized that no o…
Have you ever wanted to restrict the users input in a textbox to numbers, and while doing that make sure that they can't 'cheat' by pasting in non-numeric text? Of course you can do that with code you write yourself but it's tedious and error-prone …
Get people started with the process of using Access VBA to control Excel using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Excel. Using automation, an Access application can laun…
Show developers how to use a criteria form to limit the data that appears on an Access report. It is a common requirement that users can specify the criteria for a report at runtime. The easiest way to accomplish this is using a criteria form that a…

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now