Solved

Is .net Response.OutputStream.Write asynchronous?

Posted on 2009-04-08
2
1,354 Views
Last Modified: 2013-11-08
On Micorsofts website (http://support.microsoft.com/?kbid=812406) there's an article showing how to download very large files from a website.

Works great but...

In their sample code (see code section) they allocate a 10,000 byte buffer to chunk the byte file stream to the output stream. Fine. But in the loop they re-allocate a new 10,000 byte buffer for each chunk. Seems like a waste of memory.

I can only image that response.outputstream.write is running in a separate thread and may still be using the original buffer. I can't find any info on threading for this method.

Any thoughts on why/if the reallocation is necessary?
System.IO.Stream iStream = null;
 

// Buffer to read 10K bytes in chunk:

byte[] buffer = new Byte[10000];
 

// Length of the file:

int length;
 

// Total bytes to read:

long dataToRead;
 

// Identify the file to download including its path.

string filepath  = "DownloadFileName";
 

// Identify the file name.

string  filename  = System.IO.Path.GetFileName(filepath);
 

try

{

	// Open the file.

	iStream = new System.IO.FileStream(filepath, System.IO.FileMode.Open, 

					System.IO.FileAccess.Read,System.IO.FileShare.Read);
 
 

	// Total bytes to read:

	dataToRead = iStream.Length;
 

	Response.ContentType = "application/octet-stream";

	Response.AddHeader("Content-Disposition", "attachment; filename=" + filename);
 

	// Read the bytes.

	while (dataToRead > 0)

	{

		// Verify that the client is connected.

		if (Response.IsClientConnected) 

		{

			// Read the data in buffer.

			length = iStream.Read(buffer, 0, 10000);
 

			// Write the data to the current output stream.

			Response.OutputStream.Write(buffer, 0, length);
 

			// Flush the data to the HTML output.

			Response.Flush();
 

			buffer= new Byte[10000];

			dataToRead = dataToRead - length;

		}

		else

		{

			//prevent infinite loop if user disconnects

			dataToRead = -1;

		}

	}

}

catch (Exception ex) 

{

	// Trap the error, if any.

	Response.Write("Error : " + ex.Message);

}

finally

{

	if (iStream != null) 

	{

		//Close the file.

		iStream.Close();

	}

	Response.Close();

}

Open in new window

0
Comment
Question by:mduffin06
2 Comments
 
LVL 5

Accepted Solution

by:
burningmace earned 500 total points
ID: 24100186
It isn't necessary at all - the code would simply overwrite the old data with the new. You can comment line 46 out with no problems at all. I think the programmer did this just to make sure that the old data would not cause complications. However, it wouldn't be a waste of memory as the garbage collector would recognise that line 46 causes the old buffer asset to become orphaned and would unallocate it. I'm not sure how GC scheduling is handled in .NET, but the use of New may signal GC automatically to check if an old asset is being replaced. If not, then this method probably wastes around 500K of memory at peak before GC notices and clear it. Not really a huge issue with most systems having 1GB of memory or more these days. But yes, it is bad practice to do things like that.
0
 

Author Closing Comment

by:mduffin06
ID: 31568143
Per burningmace advice, removed new allocation. Seems to work fine. No problems to date.
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Problem Hi all,    While many today have fast Internet connection, there are many still who do not, or are connecting through devices with a slower connect, so light web pages and fast load times are still popular.    If your ASP.NET page …
Exception Handling is in the core of any application that is able to dignify its name. In this article, I'll guide you through the process of writing a DRY (Don't Repeat Yourself) Exception Handling mechanism, using Aspect Oriented Programming.
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
Sending a Secure fax is easy with eFax Corporate (http://www.enterprise.efax.com). First, Just open a new email message.  In the To field, type your recipient's fax number @efaxsend.com. You can even send a secure international fax — just include t…

747 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now