Solved

Is .net Response.OutputStream.Write asynchronous?

Posted on 2009-04-08
2
1,374 Views
Last Modified: 2013-11-08
On Micorsofts website (http://support.microsoft.com/?kbid=812406) there's an article showing how to download very large files from a website.

Works great but...

In their sample code (see code section) they allocate a 10,000 byte buffer to chunk the byte file stream to the output stream. Fine. But in the loop they re-allocate a new 10,000 byte buffer for each chunk. Seems like a waste of memory.

I can only image that response.outputstream.write is running in a separate thread and may still be using the original buffer. I can't find any info on threading for this method.

Any thoughts on why/if the reallocation is necessary?
System.IO.Stream iStream = null;
 
// Buffer to read 10K bytes in chunk:
byte[] buffer = new Byte[10000];
 
// Length of the file:
int length;
 
// Total bytes to read:
long dataToRead;
 
// Identify the file to download including its path.
string filepath  = "DownloadFileName";
 
// Identify the file name.
string  filename  = System.IO.Path.GetFileName(filepath);
 
try
{
	// Open the file.
	iStream = new System.IO.FileStream(filepath, System.IO.FileMode.Open, 
					System.IO.FileAccess.Read,System.IO.FileShare.Read);
 
 
	// Total bytes to read:
	dataToRead = iStream.Length;
 
	Response.ContentType = "application/octet-stream";
	Response.AddHeader("Content-Disposition", "attachment; filename=" + filename);
 
	// Read the bytes.
	while (dataToRead > 0)
	{
		// Verify that the client is connected.
		if (Response.IsClientConnected) 
		{
			// Read the data in buffer.
			length = iStream.Read(buffer, 0, 10000);
 
			// Write the data to the current output stream.
			Response.OutputStream.Write(buffer, 0, length);
 
			// Flush the data to the HTML output.
			Response.Flush();
 
			buffer= new Byte[10000];
			dataToRead = dataToRead - length;
		}
		else
		{
			//prevent infinite loop if user disconnects
			dataToRead = -1;
		}
	}
}
catch (Exception ex) 
{
	// Trap the error, if any.
	Response.Write("Error : " + ex.Message);
}
finally
{
	if (iStream != null) 
	{
		//Close the file.
		iStream.Close();
	}
	Response.Close();
}

Open in new window

0
Comment
Question by:mduffin06
2 Comments
 
LVL 5

Accepted Solution

by:
burningmace earned 500 total points
ID: 24100186
It isn't necessary at all - the code would simply overwrite the old data with the new. You can comment line 46 out with no problems at all. I think the programmer did this just to make sure that the old data would not cause complications. However, it wouldn't be a waste of memory as the garbage collector would recognise that line 46 causes the old buffer asset to become orphaned and would unallocate it. I'm not sure how GC scheduling is handled in .NET, but the use of New may signal GC automatically to check if an old asset is being replaced. If not, then this method probably wastes around 500K of memory at peak before GC notices and clear it. Not really a huge issue with most systems having 1GB of memory or more these days. But yes, it is bad practice to do things like that.
0
 

Author Closing Comment

by:mduffin06
ID: 31568143
Per burningmace advice, removed new allocation. Seems to work fine. No problems to date.
0

Featured Post

3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Javascript to set controls visibility 5 34
2 questions 10 25
Getting error in connectionstring with Excel. 30 32
JSON  parse help 7 25
Introduction This article shows how to use the open source plupload control to upload multiple images. The images are resized on the client side before uploading and the upload is done in chunks. Background I had to provide a way for user…
Wouldn’t it be nice if you could test whether an element is contained in an array by using a Contains method just like the one available on List objects? Wouldn’t it be good if you could write code like this? (CODE) In .NET 3.5, this is possible…
Email security requires an ever evolving service that stays up to date with counter-evolving threats. The Email Laundry perform Research and Development to ensure their email security service evolves faster than cyber criminals. We apply our Threat…
Although Jacob Bernoulli (1654-1705) has been credited as the creator of "Binomial Distribution Table", Gottfried Leibniz (1646-1716) did his dissertation on the subject in 1666; Leibniz you may recall is the co-inventor of "Calculus" and beat Isaac…

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question