Solved

vbscript registry append

Posted on 2009-04-08
4
1,421 Views
Last Modified: 2012-05-06
I created a script to append to a registry key, this work fine, except, I want to put this as a GPO start up script and it will re-write the entry every time it's run.  How can I adjust the script to tell if it already exist to not write?  Keep in mind that there could be any number of entries in this reg key?

Help is appreciated!
Option Explicit
On Error Resume Next
Dim WSHShell, rtnValue, newValue
Set WSHShell = WScript.CreateObject("WScript.Shell")
rtnValue = WSHShell.RegRead("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride")
If Right(Trim(rtnValue),1)=";" Then newValue = "*.test.com" Else newValue = "*.test.com"
WSHShell.RegWrite "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride", rtnValue & _
newValue, "REG_SZ"
Set WSHShell = Nothing

Open in new window

0
Comment
Question by:rtmcmullen
  • 2
  • 2
4 Comments
 
LVL 67

Accepted Solution

by:
sirbounty earned 500 total points
ID: 24106913
I think you're saying that it would endlessly append *.test.com and you don't want that.

By the way, I'm not a fan of "On Error" statements unless you're actually performing error trapping routines.  I'd suggest removing that or you could mask a problem...


Const NewProxy = "*.test.com"
Dim WSHShell : Set WSHShell = WScript.CreateObject("WScript.Shell")
rtnValue = WSHShell.RegRead("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride")
 
If Instr(rtnValue,NewProxy) > 0 Then 
  'value already present.  Do not update rtnValue
Else 'Add value
  If Right(Trim(rtnValue), 1) <> ";" Then rtnValue = rtnValue & ";" 'ensure trailing semicolon
  rtnValue = rtnValue & NewProxy & ";"
  WSHShell.RegWrite "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride",rtnValue, "REG_SZ"
End If
 
Set WSHShell = Nothing

Open in new window

0
 

Author Closing Comment

by:rtmcmullen
ID: 31568324
Absolutely Perfect!
0
 

Author Comment

by:rtmcmullen
ID: 24106970
Perfect!  Many thanks sirbounty!
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24106975
Glad I could help - thanx for the grade! :^)
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Over the years I have built up my own little library of code snippets that I refer to when programming or writing a script.  Many of these have come from the web or adaptations from snippets I find on the Web.  Periodically I add to them when I come…
With User Account Control (UAC) enabled in Windows 7, one needs to open an elevated Command Prompt in order to run scripts under administrative privileges. Although the elevated Command Prompt accomplishes the task, the question How to run as script…
The Email Laundry PDF encryption service allows companies to send confidential encrypted  emails to anybody. The PDF document can also contain attachments that are embedded in the encrypted PDF. The password is randomly generated by The Email Laundr…

809 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question