Solved

vbscript registry append

Posted on 2009-04-08
4
1,418 Views
Last Modified: 2012-05-06
I created a script to append to a registry key, this work fine, except, I want to put this as a GPO start up script and it will re-write the entry every time it's run.  How can I adjust the script to tell if it already exist to not write?  Keep in mind that there could be any number of entries in this reg key?

Help is appreciated!
Option Explicit

On Error Resume Next

Dim WSHShell, rtnValue, newValue

Set WSHShell = WScript.CreateObject("WScript.Shell")

rtnValue = WSHShell.RegRead("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride")

If Right(Trim(rtnValue),1)=";" Then newValue = "*.test.com" Else newValue = "*.test.com"

WSHShell.RegWrite "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride", rtnValue & _

newValue, "REG_SZ"

Set WSHShell = Nothing

Open in new window

0
Comment
Question by:rtmcmullen
  • 2
  • 2
4 Comments
 
LVL 67

Accepted Solution

by:
sirbounty earned 500 total points
ID: 24106913
I think you're saying that it would endlessly append *.test.com and you don't want that.

By the way, I'm not a fan of "On Error" statements unless you're actually performing error trapping routines.  I'd suggest removing that or you could mask a problem...


Const NewProxy = "*.test.com"

Dim WSHShell : Set WSHShell = WScript.CreateObject("WScript.Shell")

rtnValue = WSHShell.RegRead("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride")
 

If Instr(rtnValue,NewProxy) > 0 Then 

  'value already present.  Do not update rtnValue

Else 'Add value

  If Right(Trim(rtnValue), 1) <> ";" Then rtnValue = rtnValue & ";" 'ensure trailing semicolon

  rtnValue = rtnValue & NewProxy & ";"

  WSHShell.RegWrite "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride",rtnValue, "REG_SZ"

End If
 

Set WSHShell = Nothing

Open in new window

0
 

Author Closing Comment

by:rtmcmullen
ID: 31568324
Absolutely Perfect!
0
 

Author Comment

by:rtmcmullen
ID: 24106970
Perfect!  Many thanks sirbounty!
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24106975
Glad I could help - thanx for the grade! :^)
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In this article we want to have a look at the directory attributes which are used by Microsoft to store the so called Security Identifiers (SID). These SIDs plays an important role in delegating and granting permissions and in authentication of trus…
I met Paul Devereux (@pdevereux) today when I responded to his tweet asking “Anybody know how to automate adding files from disk to a folder in #outlook  ?”.  I replied back and told Paul that using automation, in this case scripting, to add files t…
Internet Business Fax to Email Made Easy - With eFax Corporate (http://www.enterprise.efax.com), you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…
Learn how to create flexible layouts using relative units in CSS.  New relative units added in CSS3 include vw(viewports width), vh(viewports height), vmin(minimum of viewports height and width), and vmax (maximum of viewports height and width).

864 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now