Solved

vbscript registry append

Posted on 2009-04-08
4
1,417 Views
Last Modified: 2012-05-06
I created a script to append to a registry key, this work fine, except, I want to put this as a GPO start up script and it will re-write the entry every time it's run.  How can I adjust the script to tell if it already exist to not write?  Keep in mind that there could be any number of entries in this reg key?

Help is appreciated!
Option Explicit

On Error Resume Next

Dim WSHShell, rtnValue, newValue

Set WSHShell = WScript.CreateObject("WScript.Shell")

rtnValue = WSHShell.RegRead("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride")

If Right(Trim(rtnValue),1)=";" Then newValue = "*.test.com" Else newValue = "*.test.com"

WSHShell.RegWrite "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride", rtnValue & _

newValue, "REG_SZ"

Set WSHShell = Nothing

Open in new window

0
Comment
Question by:rtmcmullen
  • 2
  • 2
4 Comments
 
LVL 67

Accepted Solution

by:
sirbounty earned 500 total points
Comment Utility
I think you're saying that it would endlessly append *.test.com and you don't want that.

By the way, I'm not a fan of "On Error" statements unless you're actually performing error trapping routines.  I'd suggest removing that or you could mask a problem...


Const NewProxy = "*.test.com"

Dim WSHShell : Set WSHShell = WScript.CreateObject("WScript.Shell")

rtnValue = WSHShell.RegRead("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride")
 

If Instr(rtnValue,NewProxy) > 0 Then 

  'value already present.  Do not update rtnValue

Else 'Add value

  If Right(Trim(rtnValue), 1) <> ";" Then rtnValue = rtnValue & ";" 'ensure trailing semicolon

  rtnValue = rtnValue & NewProxy & ";"

  WSHShell.RegWrite "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride",rtnValue, "REG_SZ"

End If
 

Set WSHShell = Nothing

Open in new window

0
 

Author Closing Comment

by:rtmcmullen
Comment Utility
Absolutely Perfect!
0
 

Author Comment

by:rtmcmullen
Comment Utility
Perfect!  Many thanks sirbounty!
0
 
LVL 67

Expert Comment

by:sirbounty
Comment Utility
Glad I could help - thanx for the grade! :^)
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Welcome back!  My apologies for taking so long to write part two of this series; it's been a long time coming!  As I promised in Part 1, this article will focus on how to locate those elusive AD properties that you are searching for.  Why is this us…
I met Paul Devereux (@pdevereux) today when I responded to his tweet asking “Anybody know how to automate adding files from disk to a folder in #outlook  ?”.  I replied back and told Paul that using automation, in this case scripting, to add files t…
This video discusses moving either the default database or any database to a new volume.
In this tutorial you'll learn about bandwidth monitoring with flows and packet sniffing with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're interested in additional methods for monitoring bandwidt…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now