Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 997
  • Last Modified:

HTML definition List (DL) onclick event problem

I am learning HTML and Javascript. I encountered an issue when I ran the attached code. If I select the bottom drop down list item, the debug message for the definition list (dl) event handler (markLoadPage) is popped up instead of the one (setColor) for the drop down list. This issue won't show if I move the drop down list to the top of the definition list. Is there anything wrong for the dl onclick event syntax? Thanks!
<html>
  <head>
    <title>Test</title>
    <script language="javascript"> <!--
 
      function markLoadPage( page_url )
      {
	    alert( 'markLoadPage() called!' );
      }
      
      function setColor()
     {
	  alert( 'setColor() called!' );
	  	  
	    var idx = document.getElementById( "color_list" ).selectedIndex;
	    if( idx > 0 )
	    {
	      document.bgColor = document.getElementById( "color_list" ).options[ idx ].value;
          }
      } 
//--></script>
  </head>
  <body>
   <form action="">
     <h2>Categories</h2>
     <dl><a href="red_rose.html" target="P3" onclick="markLoadPage( 'red_rose.html' )">Red rose</dl>
     <dl><a href="pink_rose.html" target="P3" onclick="markLoadPage( 'pink_rose.html' )">Pink rose</dl>
     <dl><a href="yellow_rose.html" target="P3" onclick="markLoadPage( 'yellow_rose.html' )">Yellow rose</dl>
     <dl><a href="white_rose.html" target="P3" onclick="markLoadPage( 'white_rose.html' )">White rose</dl>
     <dl><a href="orange_rose.html" target="P3" onclick="markLoadPage( 'orange_rose.html' )">Orange rose</dl>
     <dl><a href="lavender_rose.html" target="P3" onclick="markLoadPage( 'lavender_rose.html' )">Lavender rose</dl>
     <p/><p/>
     <select name="color_list" id="color_list" onchange="setColor()">
       <option value="prompt">Choose a colour</option>
       <option value="red">red</option>
       <option value="pink">pink</option>
       <option value="yellow">yellow</option>
       <option value="white">white</option>
       <option value="orange">orange</option>
       <option value="lavender">lavender</option>
     </select>
     <p/>
     <input type="button" class="bt_style" value="Save Selection" name="bt_save">  
   </form>
  </body>
</html>

Open in new window

0
gs_kanata
Asked:
gs_kanata
  • 2
3 Solutions
 
GarthSnyderCommented:
Your <a> tags are unclosed, so the browser sees them as extending all the way to the end of the document. So the entire <select> popup is included in the link for lavender_rose and therefore has an onclick event.

Just close the <a>'s with </a> and you should be fine.
0
 
David S.Commented:
The HTML validator can be quite helpful: http://validator.w3.org/
0
 
Michel PlungjanIT ExpertCommented:
I also strongly advice to change


      function markLoadPage( page_url )
      {
            alert( 'markLoadPage() called!' );
            return false; // cancel the link
      }

and

 onclick="return markLoadPage( '...' )"
0
 
Michel PlungjanIT ExpertCommented:
Why "B" ???
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now