Solved

converting SimpleXML string to decimal number

Posted on 2009-04-09
4
609 Views
Last Modified: 2013-12-12
I am having an issue in regard to converting a string ("1.9") to a decimal value when SimpleXML is used.

Why does the code below round the value down to 1, and how can i store the full decimal value of the number?
$xmlstr = <<<XML

<numbers>

	<number>

		<value>1.9</value>

	</number>

</numbers>

XML;
 

$xml = new SimpleXMLElement($xmlstr);

$total=0;

foreach ($xml->number as $number) {

	echo '<p>'.$number->value.'</p>'; // 1.9

	$total+=$number->value;

}

echo '<p>'.$total.'</p>'; // 1

Open in new window

0
Comment
Question by:astrotoggle
  • 2
4 Comments
 
LVL 34

Accepted Solution

by:
Beverley Portlock earned 500 total points
ID: 24106083
Just use a "cast" to indicate to PHP that you want it handled as a double.

$total += (double) $number->value

Amended code below
<?php
 

$xmlstr = <<<XML

<numbers>

        <number>

                <value>1.9</value>

        </number>

</numbers>

XML;

 

$xml = new SimpleXMLElement($xmlstr);

$total=0;

foreach ($xml->number as $number) {

        echo '<p>'.$number->value.'</p>'; // 1.9

        $total+= (double) $number->value;

}

echo '<p>'.$total.'</p>'; // 1
 

?>

Open in new window

0
 
LVL 16

Expert Comment

by:Chris Harte
ID: 24106168
An xml element is just an array, php does not know that it is a number or a string, it just has a pointer to a memory location. To make the element what you wish it to be you can cast it, as suggested by bportlock, or just parse it with double quotes.

$total += "$number->value";
0
 
LVL 34

Expert Comment

by:Beverley Portlock
ID: 24106339
Casting or use of floatval should be preferred as it makes the programmer's intention explicit both to himself and anyone who has to maintain that code. If you think that it is silly to make things clear to yourself, try maintaining code you wrote 12 months ago ....

One other point, never allow systems to run to defaults or set default values - always set them yourself. That way if the default ever changes then your code does not behave unexpectedly. That is what happened here. PHP forced this to an integer, but in PHP6 (say) that behaviour could change. If you depended on this "feature" to truncate floating point strings into integers then upgrading to a new version could break your code. By forcing it with a cast you

- protect your code against environment differences
- document your code
- reduce scope for errors
0
 

Author Closing Comment

by:astrotoggle
ID: 31568466
easy as that.  thank you very much for your help.  that was starting to do my head in.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
Nothing in an HTTP request can be trusted, including HTTP headers and form data.  A form token is a tool that can be used to guard against request forgeries (CSRF).  This article shows an improved approach to form tokens, making it more difficult to…
The viewer will learn how to count occurrences of each item in an array.
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now