DropDown Validation Function

I have a drop down javascript function that is not working, can anyone assit me in correcting this script or is there a better way to validate both empty text boxes and a dropdown together.
<script language="JavaScript"> 
<!--
     
function validateform(form_groups) { 
var msg = "";
    if (!textvalid(form_groups.p_DisplayName)) msg += "* Unit Identifier\n"; 
    if (!textvalid(form_groups.p_GroupTitle)) msg += "* Command Name\n"; 
    if (!validate.form_groups.p_service.SelectedIndex == 0)) msg += "* Please select a service \n"; 
    if (msg== "") {return true;} 
    
    else {alert("The following fields have errors. Please change them to continue.\n" + msg); return false;} 
 } 
   
function validate(form_groups) 
{ 
   if (form_groups.p_service.selectedIndex.Value = "") 
   { 
       alert("Please select a service") 
       return false; 
    } 
  return true;  
} 
function textvalid(formfield) { 
    if (formfield.value.length != 0) { 
        return true; 
    } 
    return false;
} 
//-->
</script>

Open in new window

j1haskinsAsked:
Who is Participating?
 
Michel PlungjanConnect With a Mentor IT ExpertCommented:
syntax error

form_groups.p_service.selectedIndex.Value = ""

should be

if (form_groups.p_service.options[form_groups.p_service.selectedIndex].value == "") ...

or if you have "please seelct"
then use

if (form_groups.p_service.selectedIndex<1) ...

0
 
j1haskinsAuthor Commented:
I didn't think I had to use the function again within the other funtion. Thank you for the quick reply.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.