[Okta Webinar] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 362
  • Last Modified:

Shorten My Code

How can i shorten the code below?
Is there any other to make this code shorter?

Private Sub Marker()
Dim i As Integer
For i = 0 To 12
        cmdTableIndex(i).BackColor = vbWhite
        cmdTableIndex(i).Caption = ""
        cmdTabBill(i).BackColor = vbWhite
Next
    Dim cn As ADODB.Connection
    Dim rs As ADODB.Recordset
    Dim sql As String
 
    Call OPEN_CON(cn, "MyTable", "Winpos")
    Set rs = New ADODB.Recordset
    sql = "SELECT * FROM The_Table WHERE Table_No in (101,102,103,104,105,106,107,108,109,110,111,112,114)"
    rs.LockType = adLockOptimistic
    rs.CursorType = adOpenKeyset
    rs.Open sql, cn
    With rs
        Do While Not .EOF
            Select Case Trim(.Fields("Table_No").Value)
                Case 100
                     cmdTableIndex(0).BackColor = vbRed
                     cmdTableIndex(0).Caption = "Accomodated" & vbNewLine & "100"
                     cmdTabBill(0).BackColor = vbRed
                     
                Case 101
                     cmdTableIndex(1).BackColor = vbRed
                     cmdTableIndex(1).Caption = "Accomodated" & vbNewLine & "101"
                     cmdTabBill(1).BackColor = vbRed
                Case 102
                     cmdTableIndex(2).BackColor = vbRed
                     cmdTableIndex(2).Caption = "Accomodated" & vbNewLine & "102"
                     cmdTabBill(2).BackColor = vbRed
                Case 103
                     cmdTableIndex(3).BackColor = vbRed
                     cmdTableIndex(3).Caption = "Accomodated" & vbNewLine & "103"
                     cmdTabBill(3).BackColor = vbRed
                Case 104
                     cmdTableIndex(4).BackColor = vbRed
                     cmdTableIndex(4).Caption = "Accomodated" & vbNewLine & "104"
                     cmdTabBill(4).BackColor = vbRed
                Case 105
                     cmdTableIndex(5).BackColor = vbRed
                     cmdTableIndex(5).Caption = "Accomodated" & vbNewLine & "105"
                     cmdTabBill(5).BackColor = vbRed
                Case 106
                     cmdTableIndex(6).BackColor = vbRed
                     cmdTableIndex(6).Caption = "Accomodated" & vbNewLine & "106"
                     cmdTabBill(6).BackColor = vbRed
                Case 107
                     cmdTableIndex(7).BackColor = vbRed
                     cmdTableIndex(7).Caption = "Accomodated" & vbNewLine & "107"
                     cmdTabBill(7).BackColor = vbRed
                Case 108
                     cmdTableIndex(8).BackColor = vbRed
                     cmdTableIndex(8).Caption = "Accomodated" & vbNewLine & "108"
                     cmdTabBill(8).BackColor = vbRed
                Case 109
                     cmdTableIndex(9).BackColor = vbRed
                     cmdTableIndex(9).Caption = "Accomodated" & vbNewLine & "109"
                     cmdTabBill(9).BackColor = vbRed
                Case 110
                     cmdTableIndex(10).BackColor = vbRed
                     cmdTableIndex(10).Caption = "Accomodated" & vbNewLine & "110"
                     cmdTabBill(10).BackColor = vbRed
                Case 111
                     cmdTableIndex(11).BackColor = vbYellow
                     cmdTableIndex(11).Caption = "Accomodated" & vbNewLine & "111"
                     cmdTabBill(11).BackColor = vbRed
            End Select
            Call .MoveNext
        Loop
        .Close
    End With
    Set rs = Nothing
    Set cn = Nothing
End Sub

Open in new window

0
Whing Dela Cruz
Asked:
Whing Dela Cruz
  • 3
  • 2
  • 2
2 Solutions
 
jpaulinoCommented:
Try this way:
Private Sub Marker()
Dim i As Integer
For i = 0 To 12
        cmdTableIndex(i).BackColor = vbWhite
        cmdTableIndex(i).Caption = ""
        cmdTabBill(i).BackColor = vbWhite
Next
    Dim cn As ADODB.Connection
    Dim rs As ADODB.Recordset
    Dim sql As String
 
    Call OPEN_CON(cn, "MyTable", "Winpos")
    Set rs = New ADODB.Recordset
    sql = "SELECT * FROM The_Table WHERE Table_No in (101,102,103,104,105,106,107,108,109,110,111,112,114)"
    rs.LockType = adLockOptimistic
    rs.CursorType = adOpenKeyset
    rs.Open sql, cn
    With rs
        Dim strTable As String
        Dim intTable As Integer
        
        Do While Not .EOF
        
            strTable = Right(Trim(.Fields("Table_No").Value), 2)
            intTable = CInt(strTable)
            
            If intTable >= 0 And intTable <= 11 Then
                     cmdTableIndex(intTable).BackColor = vbRed
                     cmdTableIndex(intTable).Caption = "Accomodated" & vbNewLine & "1" & strTable
                     cmdTabBill(intTable).BackColor = vbRed
           End If
           .MoveNext
        Loop
        .Close
    End With
    Set rs = Nothing
    Set cn = Nothing
End Sub

Open in new window

0
 
Whing Dela CruzAuthor Commented:
Thanks Its working..,
What about the line 14? is there any other way to shorten that line? If yes then i will post another question for that.
Thanks!
0
 
Éric MoreauSenior .Net ConsultantCommented:
jpaulino, that is not that easy. there is no direct relation between the Table_no and the index on the form. for example, there is no item 113.

ERWIIN, an easy way to do it would be to give the Index property of your control the same value as your Table_No values (101 to 114). You don't have to keep the default 0 to x values. Only then, you would be able to use something like jpaulino showed:

        Do While Not .EOF
        
            inTable = cint(.Fields("Table_No").Value)
            
                     cmdTableIndex(intTable).BackColor = vbRed
                     cmdTableIndex(intTable).Caption = "Accomodated" & vbNewLine & intTable
                     cmdTabBill(intTable).BackColor = vbRed
           .MoveNext
        Loop

Open in new window

0
VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

 
Whing Dela CruzAuthor Commented:
Sorry but you mean to say that i must change the  index as from 0 to 101 or 1 to 102 and so on..? and then proceed the given code?
0
 
Éric MoreauSenior .Net ConsultantCommented:
yes
0
 
jpaulinoCommented:
emoreau for 113 you're right but I have assumed that he want's to skip it.
0
 
Whing Dela CruzAuthor Commented:
Ah Thanks!
i will try it and maybe i post another question in relation with this topic.
thanks!
0

Featured Post

VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

  • 3
  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now