Solved

image upload and resize

Posted on 2009-04-10
7
264 Views
Last Modified: 2013-12-12
i have a few questions...  below is my current code for resizing my images


my first question would be what would be the best size to use for a profile picture/avator ??  at the moment is have $modwidth = 200; but if i have a long picture then it looks too big..if you upload a picure nearly in all perportions then it looks great... is there anyway to make it more perpotionate or anything?

my second question would be how could i stop anything but images beeing uploaded?

3rd;y is there any more enhnace ments any 1 can suggest?
<?php

error_reporting(E_ALL); 

session_start();

require_once '../settings.php';

include "../info.php"; // sets username/id ect

?><form action="<?php echo $_server['php-self'];  ?>" method="post" enctype="multipart/form-data" id="something" class="uniForm">

        <input name="new_image" id="new_image" size="30" type="file" class="fileUpload" />

        <button name="submit" type="submit" class="submitButton">Upload/Resize Image</button>

</form>

<?php

        if(isset($_POST['submit'])){

          if (isset ($_FILES['new_image'])){

              			  $file_name = $_FILES['new_image']['name'];

			   	$getExt = explode ('.', $file_name);

               	$file_ext = $getExt[count($getExt)-1];

				$imagename = "$id.$file_ext";

				

              $source = $_FILES['new_image']['tmp_name'];

              $target = "images/$id.$file_ext";

			  

              move_uploaded_file($source, $target);

 

              $imagepath = $imagename;

              $save = "images/thumbs/" . $imagepath; //This is the new file you saving

              $file = "images/" . $imagepath; //This is the original file

 

              list($width, $height) = getimagesize($file) ; 

 

              $modwidth = 200; 

 

              $diff = $width / $modwidth;

 

              $modheight = $height / $diff; 

              $tn = imagecreatetruecolor($modwidth, $modheight) ; 

              $image = imagecreatefromjpeg($file) ; 

              imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ; 

			  imagejpeg($tn, $save, 100) ; 

 

              $imagepath = $imagename;

              $save = "images/mini/" . $imagepath; //This is the new file you saving

              $file = "images/" . $imagepath; //This is the original file

 

              list($width, $height) = getimagesize($file) ; 

 

              $modwidth = 80; 

 

              $diff = $width / $modwidth;

 

              $modheight = $height / $diff; 

              $tn = imagecreatetruecolor($modwidth, $modheight) ; 

              $image = imagecreatefromjpeg($file) ; 

              imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ;  

 

              imagejpeg($tn, $save, 100) ; 

			  

			  

			  $imagepath = $imagename;

              $save = "images/tiny/" . $imagepath; //This is the new file you saving

              $file = "images/" . $imagepath; //This is the original file

 

              list($width, $height) = getimagesize($file) ; 

 

              $modwidth = 40; 

 

              $diff = $width / $modwidth;

 

              $modheight = $height / $diff; 

              $tn = imagecreatetruecolor($modwidth, $modheight) ; 

              $image = imagecreatefromjpeg($file) ; 

              imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ; 

 

              imagejpeg($tn, $save, 100) ; 

			  $sql = "UPDATE `users` SET image = '".$id.".".$file_ext."' WHERE ID=$id";

mysql_query($sql) or die(mysql_error());

			  

            echo "Large image: <img src='images/thumbs/".$imagepath."'><br>"; 

            echo "MINI: <img src='images/mini/".$imagepath."'>"; 

			echo "TINY: <img src='images/tiny/".$imagepath."'><br>";  

 

          }

        }

?>

Open in new window

0
Comment
Question by:runnerjp
  • 3
  • 2
7 Comments
 
LVL 9

Accepted Solution

by:
Mahdii7 earned 250 total points
ID: 24120295
Answers to 1 & 2
<?php

error_reporting(E_ALL); 

session_start();

require_once '../settings.php';

include "../info.php"; // sets username/id ect

?><form action="<?php echo $_server['php-self'];  ?>" method="post" enctype="multipart/form-data" id="something" class="uniForm">

        <input name="new_image" id="new_image" size="30" type="file" class="fileUpload" />

        <button name="submit" type="submit" class="submitButton">Upload/Resize Image</button>

</form>

<?php

        if(isset($_POST['submit'])){

          if (isset ($_FILES['new_image'])){

                                  $file_name = $_FILES['new_image']['name'];

                                $getExt = explode ('.', $file_name);

                $file_ext = $getExt[count($getExt)-1];

				// Adding extension verification

				$allowed_ext = "|jpg|png|gif|jpeg|svg|bmp|";

				if (!strpos($allowed_ext, "|".$file_ext."|")) die("Extension: $file_ext is not allowed!");		

				// End extension verification		

                                $imagename = "$id.$file_ext";

                                

              $source = $_FILES['new_image']['tmp_name'];

              $target = "images/$id.$file_ext";

                          

              move_uploaded_file($source, $target);

 

              $imagepath = $imagename;

              $save = "images/thumbs/" . $imagepath; //This is the new file you saving

              $file = "images/" . $imagepath; //This is the original file

 

              list($width, $height) = getimagesize($file) ; 

 

              // Adding proportionate image resizing, with max values

			  

			  /*

			  $modwidth = 200; 

 

              $diff = $width / $modwidth;

 

              $modheight = $height / $diff; 

              */

			  

			  $max_w = 200;

			  $max_h = 200;

			  

			  if($width <= $max_w && $height <= $max_h){ // if it fits

	             $modheight = $height; 

				 $modwidth = $width;

			  }else{ // Then resize

			  	$diff = ($width > $height) ? ($width/$max_w) :  ($height/$max_h); // Check which is bigger, and fit it to that max value. This will prevent stretching (80x800)

	            $modheight = $height / $diff; 

				$modwidth = $width / $diff;

			  }

			  

			  // End 

			  

			  $tn = imagecreatetruecolor($modwidth, $modheight) ; 

              $image = imagecreatefromjpeg($file) ; 

              imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ; 

                          imagejpeg($tn, $save, 100) ; 

 

              $imagepath = $imagename;

              $save = "images/mini/" . $imagepath; //This is the new file you saving

              $file = "images/" . $imagepath; //This is the original file

 

              list($width, $height) = getimagesize($file) ; 

 

              $modwidth = 80; 

 

              $diff = $width / $modwidth;

 

              $modheight = $height / $diff; 

              $tn = imagecreatetruecolor($modwidth, $modheight) ; 

              $image = imagecreatefromjpeg($file) ; 

              imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ;  

 

              imagejpeg($tn, $save, 100) ; 

                          

                          

                          $imagepath = $imagename;

              $save = "images/tiny/" . $imagepath; //This is the new file you saving

              $file = "images/" . $imagepath; //This is the original file

 

              list($width, $height) = getimagesize($file) ; 

 

              $modwidth = 40; 

 

              $diff = $width / $modwidth;

 

              $modheight = $height / $diff; 

              $tn = imagecreatetruecolor($modwidth, $modheight) ; 

              $image = imagecreatefromjpeg($file) ; 

              imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ; 

 

              imagejpeg($tn, $save, 100) ; 

                          $sql = "UPDATE `users` SET image = '".$id.".".$file_ext."' WHERE ID=$id";

mysql_query($sql) or die(mysql_error());

                          

            echo "Large image: <img src='images/thumbs/".$imagepath."'><br>"; 

            echo "MINI: <img src='images/mini/".$imagepath."'>"; 

                        echo "TINY: <img src='images/tiny/".$imagepath."'><br>";  

 

          }

        }

?>

Open in new window

0
 
LVL 19

Expert Comment

by:Michael701
ID: 24120899
Hello Mahdii7,

Take a look at pathinfo() to extract the extension.



<?php 
 

$path_parts = pathinfo("/www/htdocs/index.html"); 
 

echo $path_parts["dirname"] . "\n"; 

echo $path_parts["basename"] . "\n"; 

echo $path_parts["extension"] . "\n"; 
 

?>

Open in new window

0
 

Author Comment

by:runnerjp
ID: 24121423
ermm for some reason with the below code it says Extension: jpg is not allowed! :S:S
      // Adding extension verification

                                $allowed_ext = "|jpg|png|gif|jpeg|svg|bmp|";

                                if (!strpos($allowed_ext, "|".$file_ext."|")) die("Extension: $file_ext is not allowed!");  

Open in new window

0
What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

 
LVL 19

Expert Comment

by:Michael701
ID: 24122048
I bet it's a case issue


if (!strpos($allowed_ext, "|".strtolower($file_ext)."|"))


oh it's NOT a case issue

if (strpos($allowed_ext, "|".strtolower($file_ext)."|")!==false)

---
strpos was returning 0 (first position of the string), that's different than false (not found)
0
 

Author Comment

by:runnerjp
ID: 24125723
i chnaged it to if (strpos($allowed_ext, "|".strtolower($file_ext)."|")!==false) and i still get Extension: jpg is not allowed!
0
 
LVL 19

Assisted Solution

by:Michael701
Michael701 earned 250 total points
ID: 24126166
this is one of those LOL moments

normally I think

if (good extension)
{
  do something
}

but you want your program to die

so let's reverse the logic
$allowed_ext = "|jpg|png|gif|jpeg|svg|bmp|";

if (strpos($allowed_ext, "|".strtolower($file_ext)."|")===false) 

  die("Extension: $file_ext is not allowed!");  

Open in new window

0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Things That Drive Us Nuts Have you noticed the use of the reCaptcha feature at EE and other web sites?  It wants you to read and retype something that looks like this.Insanity!  It's not EE's fault - that's just the way reCaptcha works.  But it is …
This article discusses four methods for overlaying images in a container on a web page
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

758 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now